You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "aaronbee (via GitHub)" <gi...@apache.org> on 2024/12/20 22:10:24 UTC

[PR] HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value [hbase]

aaronbee opened a new pull request, #6556:
URL: https://github.com/apache/hbase/pull/6556

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value [hbase]

Posted by "aaronbee (via GitHub)" <gi...@apache.org>.
aaronbee commented on code in PR #6556:
URL: https://github.com/apache/hbase/pull/6556#discussion_r1896041049


##########
hbase-server/src/main/resources/hbase-webapps/regionserver/processRS.jsp:
##########
@@ -68,8 +70,8 @@ pageContext.setAttribute("pageTitle", "Process info for PID: " + JSONMetricUtil.
         <td><%= new Date(runtimeBean.getStartTime()) %></td>
         <td><%= StringUtils.humanTimeDiff(runtimeBean.getUptime()) %></td>
         <td><%= JSONMetricUtil.getProcessPID() %></td>
-        <td><%= (long)JSONMetricUtil.getValueFromMBean(rsMetrics, "pauseWarnThresholdExceeded")
-          + (long)JSONMetricUtil.getValueFromMBean(rsMetrics, "pauseInfoThresholdExceeded") %></td>
+        <td><%= pauseWarnThresholdExceeded != null && pauseInfoThresholdExceeded != null ?
+                (long)pauseWarnThresholdExceeded + (long)pauseInfoThresholdExceeded : -1 %></td>

Review Comment:
   Changed the value to 0 when the metrics are null. And fixed the spacing on line 65.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6556:
URL: https://github.com/apache/hbase/pull/6556#issuecomment-2560372108

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 29s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
   |||| _ Prechecks _ |
   |||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 18s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 28s |  |  master passed  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  1s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 26s |  |  the patch passed  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 183m 13s |  |  hbase-server in the patch passed.  |
   |  |   | 195m 19s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/6556 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux 4d6bd5276e33 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 7cabaf17bd80478c3462d7790232136361f163e0 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/2/testReport/ |
   | Max. process+thread count | 5031 (vs. ulimit of 30000) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/2/console |
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value [hbase]

Posted by "aaronbee (via GitHub)" <gi...@apache.org>.
aaronbee commented on code in PR #6556:
URL: https://github.com/apache/hbase/pull/6556#discussion_r1896039507


##########
hbase-server/src/main/resources/hbase-webapps/regionserver/processRS.jsp:
##########
@@ -68,8 +70,8 @@ pageContext.setAttribute("pageTitle", "Process info for PID: " + JSONMetricUtil.
         <td><%= new Date(runtimeBean.getStartTime()) %></td>
         <td><%= StringUtils.humanTimeDiff(runtimeBean.getUptime()) %></td>
         <td><%= JSONMetricUtil.getProcessPID() %></td>
-        <td><%= (long)JSONMetricUtil.getValueFromMBean(rsMetrics, "pauseWarnThresholdExceeded")
-          + (long)JSONMetricUtil.getValueFromMBean(rsMetrics, "pauseInfoThresholdExceeded") %></td>
+        <td><%= pauseWarnThresholdExceeded != null && pauseInfoThresholdExceeded != null ?
+                (long)pauseWarnThresholdExceeded + (long)pauseInfoThresholdExceeded : -1 %></td>

Review Comment:
   Happy to replace with whatever is preferred. How about the string "unknown"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6556:
URL: https://github.com/apache/hbase/pull/6556#issuecomment-2557939917

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 20s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
   |||| _ Prechecks _ |
   |||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 18s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 29s |  |  master passed  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 41s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 27s |  |  the patch passed  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 185m 17s |  |  hbase-server in the patch passed.  |
   |  |   | 196m 51s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/6556 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux bc2022827495 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 399cba54fa7f3b9d40cf02186e314993e82a3a1d |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/1/testReport/ |
   | Max. process+thread count | 5171 (vs. ulimit of 30000) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/1/console |
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6556:
URL: https://github.com/apache/hbase/pull/6556#issuecomment-2560181744

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 35s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain any @author tags.  |
   |||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 49s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 43s |  |  branch has no errors when running spotless:check.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  6s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks issues.  |
   | +1 :green_heart: |  spotless  |   1m  3s |  |  patch has no errors when running spotless:check.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 15s |  |  The patch does not generate ASF License warnings.  |
   |  |   |  11m  5s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/2/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/6556 |
   | Optional Tests | dupname asflicense javac codespell detsecrets spotless |
   | uname | Linux 9cc67021bfce 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 7cabaf17bd80478c3462d7790232136361f163e0 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 83 (vs. ulimit of 30000) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/2/console |
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value [hbase]

Posted by "guluo2016 (via GitHub)" <gi...@apache.org>.
guluo2016 commented on code in PR #6556:
URL: https://github.com/apache/hbase/pull/6556#discussion_r1895654326


##########
hbase-server/src/main/resources/hbase-webapps/regionserver/processRS.jsp:
##########
@@ -68,8 +70,8 @@ pageContext.setAttribute("pageTitle", "Process info for PID: " + JSONMetricUtil.
         <td><%= new Date(runtimeBean.getStartTime()) %></td>
         <td><%= StringUtils.humanTimeDiff(runtimeBean.getUptime()) %></td>
         <td><%= JSONMetricUtil.getProcessPID() %></td>
-        <td><%= (long)JSONMetricUtil.getValueFromMBean(rsMetrics, "pauseWarnThresholdExceeded")
-          + (long)JSONMetricUtil.getValueFromMBean(rsMetrics, "pauseInfoThresholdExceeded") %></td>
+        <td><%= pauseWarnThresholdExceeded != null && pauseInfoThresholdExceeded != null ?
+                (long)pauseWarnThresholdExceeded + (long)pauseInfoThresholdExceeded : -1 %></td>

Review Comment:
   Is it better to display 0 if it's null?  I'm not sure, maybe we can hear other people's opinions?
   
   `<th>JvmPauseMonitor Count </th>` , Can you also remove this space in line65?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6556:
URL: https://github.com/apache/hbase/pull/6556#issuecomment-2557818019

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 27s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain any @author tags.  |
   |||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  6s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 45s |  |  branch has no errors when running spotless:check.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 52s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks issues.  |
   | +1 :green_heart: |  spotless  |   0m 41s |  |  patch has no errors when running spotless:check.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 10s |  |  The patch does not generate ASF License warnings.  |
   |  |   |   9m 19s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/1/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/6556 |
   | Optional Tests | dupname asflicense javac codespell detsecrets spotless |
   | uname | Linux 24bf095091fa 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 399cba54fa7f3b9d40cf02186e314993e82a3a1d |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 83 (vs. ulimit of 30000) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/1/console |
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value [hbase]

Posted by "aaronbee (via GitHub)" <gi...@apache.org>.
aaronbee commented on code in PR #6556:
URL: https://github.com/apache/hbase/pull/6556#discussion_r1896041049


##########
hbase-server/src/main/resources/hbase-webapps/regionserver/processRS.jsp:
##########
@@ -68,8 +70,8 @@ pageContext.setAttribute("pageTitle", "Process info for PID: " + JSONMetricUtil.
         <td><%= new Date(runtimeBean.getStartTime()) %></td>
         <td><%= StringUtils.humanTimeDiff(runtimeBean.getUptime()) %></td>
         <td><%= JSONMetricUtil.getProcessPID() %></td>
-        <td><%= (long)JSONMetricUtil.getValueFromMBean(rsMetrics, "pauseWarnThresholdExceeded")
-          + (long)JSONMetricUtil.getValueFromMBean(rsMetrics, "pauseInfoThresholdExceeded") %></td>
+        <td><%= pauseWarnThresholdExceeded != null && pauseInfoThresholdExceeded != null ?
+                (long)pauseWarnThresholdExceeded + (long)pauseInfoThresholdExceeded : -1 %></td>

Review Comment:
   Changed the value to 0 when the metrics are null. Add fixed the spacing on line 65.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value [hbase]

Posted by "guluo2016 (via GitHub)" <gi...@apache.org>.
guluo2016 commented on code in PR #6556:
URL: https://github.com/apache/hbase/pull/6556#discussion_r1896714692


##########
hbase-server/src/main/resources/hbase-webapps/regionserver/processRS.jsp:
##########
@@ -68,8 +70,8 @@ pageContext.setAttribute("pageTitle", "Process info for PID: " + JSONMetricUtil.
         <td><%= new Date(runtimeBean.getStartTime()) %></td>
         <td><%= StringUtils.humanTimeDiff(runtimeBean.getUptime()) %></td>
         <td><%= JSONMetricUtil.getProcessPID() %></td>
-        <td><%= (long)JSONMetricUtil.getValueFromMBean(rsMetrics, "pauseWarnThresholdExceeded")
-          + (long)JSONMetricUtil.getValueFromMBean(rsMetrics, "pauseInfoThresholdExceeded") %></td>
+        <td><%= pauseWarnThresholdExceeded != null && pauseInfoThresholdExceeded != null ?
+                (long)pauseWarnThresholdExceeded + (long)pauseInfoThresholdExceeded : -1 %></td>

Review Comment:
   I have no more questions. let's wait for others to review.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value [hbase]

Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 merged PR #6556:
URL: https://github.com/apache/hbase/pull/6556


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org