[GitHub] incubator-quickstep pull request #28: Add option to enable Google Profiler.

[zuyu <gi...@git.apache.org>]

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/28#discussion_r66727801
  
    --- Diff: cli/QuickstepCli.cpp ---
    @@ -440,6 +462,13 @@ int main(int argc, char* argv[]) {
         }
       }
     
    +#ifdef QUICKSTEP_ENABLE_GOOGLE_PROFILER
    +  if (!query_num && !quickstep::FLAGS_profile_file_name.empty()) {
    --- End diff --
    
    Look like a bug to me: `query_num` would be `non-zero` if we start to profile.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---