You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "neilconway (via GitHub)" <gi...@apache.org> on 2026/05/14 21:25:54 UTC

[PR] chore: Switch over stray old-style string builder in `substr` [datafusion]

neilconway opened a new pull request, #22183:
URL: https://github.com/apache/datafusion/pull/22183

   ## Which issue does this PR close?
   
   - N/A
   
   ## Rationale for this change
   
   In #21519, we optimized `substr` to use the new bulk-NULL string builders. That PR neglected to convert over one corner-case code path (for handling `Utf8` / `LargeUtf8` values larger than 2GB). For consistency (and a small perf win), this PR converts that case as well.
   
   ## What changes are included in this PR?
   
   * Swap Arrow's `StringViewBuilder` for the new `StringViewArrayBuilder` in `generic_string_substr_copy`
   
   ## Are these changes tested?
   
   Yes, covered by existing tests.
   
   ## Are there any user-facing changes?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] chore: Replace stray old-style string builder in `substr` [datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #22183:
URL: https://github.com/apache/datafusion/pull/22183#issuecomment-4493949421

   Thanks @neilconway & @adriangb 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] chore: Replace stray old-style string builder in `substr` [datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #22183:
URL: https://github.com/apache/datafusion/pull/22183


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org