You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/03/12 12:08:22 UTC

Review Request 31980: LENS-407 : JDBCDriver should rewrite query only once

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31980/
-----------------------------------------------------------

Review request for lens, Jaideep dhok and Rajat Khandelwal.


Bugs: LENS-407
    https://issues.apache.org/jira/browse/LENS-407


Repository: lens


Description
-------

Changes include:

- Adding final driver query in QueryContext
- Added one more gauge in rewrite flow. This also makes sure rewrite is called only once.


Diffs
-----

  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java d67e1da 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 6c1d77e 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 432c863 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 94b5daf 

Diff: https://reviews.apache.org/r/31980/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.078s]
[INFO] Lens .............................................. SUCCESS [1.734s]
[INFO] Lens API .......................................... SUCCESS [5.275s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.726s]
[INFO] Lens Cube ......................................... SUCCESS [2:21.813s]
[INFO] Lens DB storage ................................... SUCCESS [10.547s]
[INFO] Lens Query Library ................................ SUCCESS [4.660s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:37.461s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [22.726s]
[INFO] Lens Server ....................................... SUCCESS [4:31.794s]
[INFO] Lens client ....................................... SUCCESS [20.647s]
[INFO] Lens CLI .......................................... SUCCESS [1:50.966s]
[INFO] Lens Examples ..................................... SUCCESS [0.843s]
[INFO] Lens Distribution ................................. SUCCESS [9.288s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.902s]
[INFO] Lens Regression ................................... SUCCESS [0.476s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:31.960s
[INFO] Finished at: Thu Mar 12 11:07:55 UTC 2015
[INFO] Final Memory: 110M/971M
[INFO] ------------------------------------------------------------------------


Thanks,

Amareshwari Sriramadasu

Re: Review Request 31980: LENS-407 : JDBCDriver should rewrite query only once

Posted by Amareshwari Sriramadasu <am...@apache.org>.

> On March 16, 2015, 5:59 a.m., Jaideep dhok wrote:
> > Is this because of some merge issues?

Yes


- Amareshwari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31980/#review76525
-----------------------------------------------------------


On March 13, 2015, 10:43 a.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31980/
> -----------------------------------------------------------
> 
> (Updated March 13, 2015, 10:43 a.m.)
> 
> 
> Review request for lens, Jaideep dhok and Rajat Khandelwal.
> 
> 
> Bugs: LENS-407
>     https://issues.apache.org/jira/browse/LENS-407
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Changes include:
> 
> - Adding final driver query in QueryContext
> - Added one more gauge in rewrite flow. This also makes sure rewrite is called only once.
> 
> 
> Diffs
> -----
> 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 6f9dd5b 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java f3be3fb 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 432c863 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 94b5daf 
> 
> Diff: https://reviews.apache.org/r/31980/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.078s]
> [INFO] Lens .............................................. SUCCESS [1.734s]
> [INFO] Lens API .......................................... SUCCESS [5.275s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.726s]
> [INFO] Lens Cube ......................................... SUCCESS [2:21.813s]
> [INFO] Lens DB storage ................................... SUCCESS [10.547s]
> [INFO] Lens Query Library ................................ SUCCESS [4.660s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.461s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [22.726s]
> [INFO] Lens Server ....................................... SUCCESS [4:31.794s]
> [INFO] Lens client ....................................... SUCCESS [20.647s]
> [INFO] Lens CLI .......................................... SUCCESS [1:50.966s]
> [INFO] Lens Examples ..................................... SUCCESS [0.843s]
> [INFO] Lens Distribution ................................. SUCCESS [9.288s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.902s]
> [INFO] Lens Regression ................................... SUCCESS [0.476s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:31.960s
> [INFO] Finished at: Thu Mar 12 11:07:55 UTC 2015
> [INFO] Final Memory: 110M/971M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Re: Review Request 31980: LENS-407 : JDBCDriver should rewrite query only once

Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31980/#review76525
-----------------------------------------------------------

Ship it!


Is this because of some merge issues?

- Jaideep dhok


On March 13, 2015, 10:43 a.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31980/
> -----------------------------------------------------------
> 
> (Updated March 13, 2015, 10:43 a.m.)
> 
> 
> Review request for lens, Jaideep dhok and Rajat Khandelwal.
> 
> 
> Bugs: LENS-407
>     https://issues.apache.org/jira/browse/LENS-407
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Changes include:
> 
> - Adding final driver query in QueryContext
> - Added one more gauge in rewrite flow. This also makes sure rewrite is called only once.
> 
> 
> Diffs
> -----
> 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 6f9dd5b 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java f3be3fb 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 432c863 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 94b5daf 
> 
> Diff: https://reviews.apache.org/r/31980/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.078s]
> [INFO] Lens .............................................. SUCCESS [1.734s]
> [INFO] Lens API .......................................... SUCCESS [5.275s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.726s]
> [INFO] Lens Cube ......................................... SUCCESS [2:21.813s]
> [INFO] Lens DB storage ................................... SUCCESS [10.547s]
> [INFO] Lens Query Library ................................ SUCCESS [4.660s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.461s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [22.726s]
> [INFO] Lens Server ....................................... SUCCESS [4:31.794s]
> [INFO] Lens client ....................................... SUCCESS [20.647s]
> [INFO] Lens CLI .......................................... SUCCESS [1:50.966s]
> [INFO] Lens Examples ..................................... SUCCESS [0.843s]
> [INFO] Lens Distribution ................................. SUCCESS [9.288s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.902s]
> [INFO] Lens Regression ................................... SUCCESS [0.476s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:31.960s
> [INFO] Finished at: Thu Mar 12 11:07:55 UTC 2015
> [INFO] Final Memory: 110M/971M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Re: Review Request 31980: LENS-407 : JDBCDriver should rewrite query only once

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31980/
-----------------------------------------------------------

(Updated March 13, 2015, 10:43 a.m.)


Review request for lens, Jaideep dhok and Rajat Khandelwal.


Changes
-------

Updated to master


Bugs: LENS-407
    https://issues.apache.org/jira/browse/LENS-407


Repository: lens


Description
-------

Changes include:

- Adding final driver query in QueryContext
- Added one more gauge in rewrite flow. This also makes sure rewrite is called only once.


Diffs (updated)
-----

  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 6f9dd5b 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java f3be3fb 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 432c863 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 94b5daf 

Diff: https://reviews.apache.org/r/31980/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.078s]
[INFO] Lens .............................................. SUCCESS [1.734s]
[INFO] Lens API .......................................... SUCCESS [5.275s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.726s]
[INFO] Lens Cube ......................................... SUCCESS [2:21.813s]
[INFO] Lens DB storage ................................... SUCCESS [10.547s]
[INFO] Lens Query Library ................................ SUCCESS [4.660s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:37.461s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [22.726s]
[INFO] Lens Server ....................................... SUCCESS [4:31.794s]
[INFO] Lens client ....................................... SUCCESS [20.647s]
[INFO] Lens CLI .......................................... SUCCESS [1:50.966s]
[INFO] Lens Examples ..................................... SUCCESS [0.843s]
[INFO] Lens Distribution ................................. SUCCESS [9.288s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.902s]
[INFO] Lens Regression ................................... SUCCESS [0.476s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:31.960s
[INFO] Finished at: Thu Mar 12 11:07:55 UTC 2015
[INFO] Final Memory: 110M/971M
[INFO] ------------------------------------------------------------------------


Thanks,

Amareshwari Sriramadasu

Re: Review Request 31980: LENS-407 : JDBCDriver should rewrite query only once

Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31980/#review76340
-----------------------------------------------------------

Ship it!


Ship It!

- Jaideep dhok


On March 12, 2015, 11:08 a.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31980/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 11:08 a.m.)
> 
> 
> Review request for lens, Jaideep dhok and Rajat Khandelwal.
> 
> 
> Bugs: LENS-407
>     https://issues.apache.org/jira/browse/LENS-407
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Changes include:
> 
> - Adding final driver query in QueryContext
> - Added one more gauge in rewrite flow. This also makes sure rewrite is called only once.
> 
> 
> Diffs
> -----
> 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java d67e1da 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 6c1d77e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 432c863 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 94b5daf 
> 
> Diff: https://reviews.apache.org/r/31980/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.078s]
> [INFO] Lens .............................................. SUCCESS [1.734s]
> [INFO] Lens API .......................................... SUCCESS [5.275s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.726s]
> [INFO] Lens Cube ......................................... SUCCESS [2:21.813s]
> [INFO] Lens DB storage ................................... SUCCESS [10.547s]
> [INFO] Lens Query Library ................................ SUCCESS [4.660s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.461s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [22.726s]
> [INFO] Lens Server ....................................... SUCCESS [4:31.794s]
> [INFO] Lens client ....................................... SUCCESS [20.647s]
> [INFO] Lens CLI .......................................... SUCCESS [1:50.966s]
> [INFO] Lens Examples ..................................... SUCCESS [0.843s]
> [INFO] Lens Distribution ................................. SUCCESS [9.288s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.902s]
> [INFO] Lens Regression ................................... SUCCESS [0.476s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:31.960s
> [INFO] Finished at: Thu Mar 12 11:07:55 UTC 2015
> [INFO] Final Memory: 110M/971M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>