You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@cxf.apache.org by Philippe Merle <ph...@inria.fr> on 2009/08/11 18:53:40 UTC
patchs for the client part of the jaxrs frontend
Hi,
I am integrating the Apache CXF 2.2.3 jaxrs frontend into the FraSCAti
platform (an SCA implementation).
During this work, I found some issues in the ClientProxyImpl class. See
the attached patched ClientProxyImpl class and a diff file.
The patch in method setRequestHeaders() around line 255 is for the case
a method is annotated with @Produces. I think that produce types if
defined must be put in request headers else text/plain or
application/xml must be put.
I am not sure but perhaps the loop in line 268 must be moved outside the
if statement.
The patch in method handleForm() at line 354 deals with the case where
the type of parameters is not String, e.g. an Integer, a Char, etc.
The last patch in method doChainedInvocation() at line 398 calls the
handleForm() method when required.
I hope these patches are adequate and could be integrated into a future
release of Apache CXF.
Best regards and A+
Philippe Merle
Re: patchs for the client part of the jaxrs frontend
Posted by Sergey Beryozkin <se...@iona.com>.
Hi Philippe
Your patch has been applied, I've added some comments at
https://issues.apache.org/jira/browse/CXF-2389
thanks, Sergey
Philippe Merle-3 wrote:
>
> Hi Dan,
>
> Daniel Kulp a écrit :
>> Philippe,
>>
>> Can you open a JIRA (or two) for these and attach the patches there:
>> https://issues.apache.org/jira/browse/CXF
>>
>> Legally, we need to keep track where the patches came from and have the
>> "grant
>> to apache" checkbox checked and all that.
>>
>> I'll let Sergey review the rest, but just wanted to get the bits into a
>> form
>> we can legally use.
>>
>
>
> This is done. See https://issues.apache.org/jira/browse/CXF-2389
>
> A+
> Philippe
>
>> Thanks!
>>
>> Dan
>>
>>
>>
>> On Tue August 11 2009 12:53:40 pm Philippe Merle wrote:
>>
>>> Hi,
>>>
>>> I am integrating the Apache CXF 2.2.3 jaxrs frontend into the FraSCAti
>>> platform (an SCA implementation).
>>> During this work, I found some issues in the ClientProxyImpl class. See
>>> the attached patched ClientProxyImpl class and a diff file.
>>>
>>> The patch in method setRequestHeaders() around line 255 is for the case
>>> a method is annotated with @Produces. I think that produce types if
>>> defined must be put in request headers else text/plain or
>>> application/xml must be put.
>>>
>>> I am not sure but perhaps the loop in line 268 must be moved outside the
>>> if statement.
>>>
>>> The patch in method handleForm() at line 354 deals with the case where
>>> the type of parameters is not String, e.g. an Integer, a Char, etc.
>>>
>>> The last patch in method doChainedInvocation() at line 398 calls the
>>> handleForm() method when required.
>>>
>>> I hope these patches are adequate and could be integrated into a future
>>> release of Apache CXF.
>>>
>>> Best regards and A+
>>> Philippe Merle
>>>
>>
>>
>
>
>
--
View this message in context: http://www.nabble.com/patchs-for-the-client-part-of-the-jaxrs-frontend-tp24921526p24935293.html
Sent from the cxf-user mailing list archive at Nabble.com.
Re: patchs for the client part of the jaxrs frontend
Posted by Philippe Merle <ph...@inria.fr>.
Hi Dan,
Daniel Kulp a écrit :
> Philippe,
>
> Can you open a JIRA (or two) for these and attach the patches there:
> https://issues.apache.org/jira/browse/CXF
>
> Legally, we need to keep track where the patches came from and have the "grant
> to apache" checkbox checked and all that.
>
> I'll let Sergey review the rest, but just wanted to get the bits into a form
> we can legally use.
>
This is done. See https://issues.apache.org/jira/browse/CXF-2389
A+
Philippe
> Thanks!
>
> Dan
>
>
>
> On Tue August 11 2009 12:53:40 pm Philippe Merle wrote:
>
>> Hi,
>>
>> I am integrating the Apache CXF 2.2.3 jaxrs frontend into the FraSCAti
>> platform (an SCA implementation).
>> During this work, I found some issues in the ClientProxyImpl class. See
>> the attached patched ClientProxyImpl class and a diff file.
>>
>> The patch in method setRequestHeaders() around line 255 is for the case
>> a method is annotated with @Produces. I think that produce types if
>> defined must be put in request headers else text/plain or
>> application/xml must be put.
>>
>> I am not sure but perhaps the loop in line 268 must be moved outside the
>> if statement.
>>
>> The patch in method handleForm() at line 354 deals with the case where
>> the type of parameters is not String, e.g. an Integer, a Char, etc.
>>
>> The last patch in method doChainedInvocation() at line 398 calls the
>> handleForm() method when required.
>>
>> I hope these patches are adequate and could be integrated into a future
>> release of Apache CXF.
>>
>> Best regards and A+
>> Philippe Merle
>>
>
>
Re: patchs for the client part of the jaxrs frontend
Posted by Daniel Kulp <dk...@apache.org>.
Philippe,
Can you open a JIRA (or two) for these and attach the patches there:
https://issues.apache.org/jira/browse/CXF
Legally, we need to keep track where the patches came from and have the "grant
to apache" checkbox checked and all that.
I'll let Sergey review the rest, but just wanted to get the bits into a form
we can legally use.
Thanks!
Dan
On Tue August 11 2009 12:53:40 pm Philippe Merle wrote:
> Hi,
>
> I am integrating the Apache CXF 2.2.3 jaxrs frontend into the FraSCAti
> platform (an SCA implementation).
> During this work, I found some issues in the ClientProxyImpl class. See
> the attached patched ClientProxyImpl class and a diff file.
>
> The patch in method setRequestHeaders() around line 255 is for the case
> a method is annotated with @Produces. I think that produce types if
> defined must be put in request headers else text/plain or
> application/xml must be put.
>
> I am not sure but perhaps the loop in line 268 must be moved outside the
> if statement.
>
> The patch in method handleForm() at line 354 deals with the case where
> the type of parameters is not String, e.g. an Integer, a Char, etc.
>
> The last patch in method doChainedInvocation() at line 398 calls the
> handleForm() method when required.
>
> I hope these patches are adequate and could be integrated into a future
> release of Apache CXF.
>
> Best regards and A+
> Philippe Merle
--
Daniel Kulp
dkulp@apache.org
http://www.dankulp.com/blog