You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2023/01/01 22:00:34 UTC
[GitHub] [superset] villebro opened a new pull request, #22563: fix(websocket): bump ts-node to fix startup error
villebro opened a new pull request, #22563:
URL: https://github.com/apache/superset/pull/22563
### SUMMARY
Currently the websocket server is unable to start with the following error:
```
$ npm run dev-server
> superset-websocket@0.0.1 dev-server
> ts-node src/index.ts start
/Users/ville/apple/apache-superset/superset-websocket/node_modules/typescript/lib/typescript.js:43495
ts.Debug.assert(typeof typeReferenceDirectiveName === "string", "Non-string value passed to `ts.resolveTypeReferenceDirective`, likely by a wrapping package working with an outdated `resolveTypeReferenceDirectives` signature. This is probably not a problem in TS itself.");
^
Error: Debug Failure. False expression: Non-string value passed to `ts.resolveTypeReferenceDirective`, likely by a wrapping package working with an outdated `resolveTypeReferenceDirectives` signature. This is probably not a problem in TS itself.
at Object.resolveTypeReferenceDirective (/Users/ville/apple/apache-superset/superset-websocket/node_modules/typescript/lib/typescript.js:43495:18)
at /Users/ville/apple/apache-superset/superset-websocket/node_modules/ts-node/src/index.ts:623:55
at Array.map (<anonymous>)
at Object.resolveTypeReferenceDirectives (/Users/ville/apple/apache-superset/superset-websocket/node_modules/ts-node/src/index.ts:622:33)
at actualResolveTypeReferenceDirectiveNamesWorker (/Users/ville/apple/apache-superset/superset-websocket/node_modules/typescript/lib/typescript.js:119377:163)
at resolveTypeReferenceDirectiveNamesWorker (/Users/ville/apple/apache-superset/superset-websocket/node_modules/typescript/lib/typescript.js:119677:26)
at processTypeReferenceDirectives (/Users/ville/apple/apache-superset/superset-websocket/node_modules/typescript/lib/typescript.js:121180:31)
at findSourceFileWorker (/Users/ville/apple/apache-superset/superset-websocket/node_modules/typescript/lib/typescript.js:121065:21)
at findSourceFile (/Users/ville/apple/apache-superset/superset-websocket/node_modules/typescript/lib/typescript.js:120917:26)
at processImportedModules (/Users/ville/apple/apache-superset/superset-websocket/node_modules/typescript/lib/typescript.js:121326:25)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! superset-websocket@0.0.1 dev-server: `ts-node src/index.ts start`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the superset-websocket@0.0.1 dev-server script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/ville/.npm/_logs/2022-12-31T10_58_28_930Z-debug.log
```
This fixes the problem by bumping `ts-node` to the most recent stable version. Now the server starts as expected:
```
$ npm run dev-server
> superset-websocket@0.0.1 dev-server
> ts-node src/index.ts start
{"message":"Server started on port 8080","level":"info"}
```
In addition, the version referenced by `.nvmrc` is updated to reflect the requirement specified in `package.json`, and the build steps are changed to use `npm ci` instead of running `npm install`.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro closed pull request #22563: fix(websocket): bump ts-node to fix startup error
Posted by GitBox <gi...@apache.org>.
villebro closed pull request #22563: fix(websocket): bump ts-node to fix startup error
URL: https://github.com/apache/superset/pull/22563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro closed pull request #22563: fix(websocket): bump ts-node to fix startup error
Posted by GitBox <gi...@apache.org>.
villebro closed pull request #22563: fix(websocket): bump ts-node to fix startup error
URL: https://github.com/apache/superset/pull/22563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #22563: fix(websocket): bump ts-node to fix startup error
Posted by GitBox <gi...@apache.org>.
villebro merged PR #22563:
URL: https://github.com/apache/superset/pull/22563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org