You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/12/07 21:57:22 UTC
[GitHub] [superset] codyml opened a new pull request, #22364: feat(dashboard): Add edit button to dashboard native filters filter cards
codyml opened a new pull request, #22364:
URL: https://github.com/apache/superset/pull/22364
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR adds an Edit button (pencil icon next to title) to the filter cards that appear when hovering over a native filter in either vertical or horizontal mode. The Edit button only appears in situations when the primary Add/Edit Filters button appears (when the user has edit dashboard permissions for the current dashboard). Clicking the Edit button opens the Add/Edit Filters dashboard with the specified filter already selected.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before, admin/owner:
<img width="914" alt="Screen Shot 2022-12-07 at 2 45 13 PM" src="https://user-images.githubusercontent.com/13007381/206303450-b5d75e90-c30f-48ba-80a9-0347a81ad073.png">
Before, viewer:
<img width="924" alt="Screen Shot 2022-12-07 at 2 45 29 PM" src="https://user-images.githubusercontent.com/13007381/206303464-65f35c21-667f-41eb-89f5-34a40a65d67d.png">
After, admin/owner:
<img width="1081" alt="Screen Shot 2022-12-07 at 2 44 49 PM" src="https://user-images.githubusercontent.com/13007381/206303509-b51c1bc4-a367-4023-9afd-5ba56adcd868.png">
After, viewer:
<img width="866" alt="Screen Shot 2022-12-07 at 2 44 57 PM" src="https://user-images.githubusercontent.com/13007381/206303538-328cde4b-d328-4215-8c20-e7a8a5108781.png">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
- Confirm that for a user with dashboard edit preferences (admin or dashboard owner), the edit button is visible and clicking it opens the Add/Edit Filters with the specified filter selected.
- Confirm that for a user without dashboard edit preferences, the card does not have an edit button.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22364: feat(dashboard): Add edit button to dashboard native filters filter cards
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22364:
URL: https://github.com/apache/superset/pull/22364#issuecomment-1342411592
@kgabryje Ephemeral environment spinning up at http://34.219.222.117:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on a diff in pull request #22364: feat(dashboard): Add edit button to dashboard native filters filter cards
Posted by GitBox <gi...@apache.org>.
codyml commented on code in PR #22364:
URL: https://github.com/apache/superset/pull/22364#discussion_r1043648003
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/FilterCard.test.tsx:
##########
@@ -217,90 +225,116 @@ const getTextInHTMLTags =
return nodeHasText && childrenDontHaveText;
};
+const hidePopover = jest.fn();
+
const renderContent = (filter = baseFilter, initialState = baseInitialState) =>
- render(<FilterCardContent filter={filter} />, {
+ render(<FilterCardContent filter={filter} hidePopover={hidePopover} />, {
useRedux: true,
initialState,
});
-describe('Filter Card', () => {
- it('Basic', () => {
- renderContent();
- expect(screen.getByText('Native filter 1')).toBeVisible();
- expect(screen.getByLabelText('filter-small')).toBeVisible();
+test('filter card title, type, scope, dependencies', () => {
+ renderContent();
+ expect(screen.getByText('Native filter 1')).toBeVisible();
+ expect(screen.getByLabelText('filter-small')).toBeVisible();
- expect(screen.getByText('Filter type')).toBeVisible();
- expect(screen.getByText('Select filter')).toBeVisible();
+ expect(screen.getByText('Filter type')).toBeVisible();
+ expect(screen.getByText('Select filter')).toBeVisible();
- expect(screen.getByText('Scope')).toBeVisible();
- expect(screen.getByText('All charts')).toBeVisible();
+ expect(screen.getByText('Scope')).toBeVisible();
+ expect(screen.getByText('All charts')).toBeVisible();
- expect(screen.queryByText('Dependencies')).not.toBeInTheDocument();
- });
+ expect(screen.queryByText('Dependencies')).not.toBeInTheDocument();
+ screen.logTestingPlaygroundURL();
Review Comment:
Oops good catch, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #22364: feat(dashboard): Add edit button to dashboard native filters filter cards
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on code in PR #22364:
URL: https://github.com/apache/superset/pull/22364#discussion_r1043732427
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/FilterCard.test.tsx:
##########
@@ -204,6 +205,13 @@ jest.mock('@superset-ui/core', () => ({
}),
}));
+jest.mock(
Review Comment:
Given that our icons load asynchronously, you can either mock the icons as you did or wait for them to render. We generally mock them when they're not the focus of the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on a diff in pull request #22364: feat(dashboard): Add edit button to dashboard native filters filter cards
Posted by GitBox <gi...@apache.org>.
codyml commented on code in PR #22364:
URL: https://github.com/apache/superset/pull/22364#discussion_r1043646724
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/FilterCard.test.tsx:
##########
@@ -204,6 +205,13 @@ jest.mock('@superset-ui/core', () => ({
}),
}));
+jest.mock(
Review Comment:
I thought this is what you had to add to avoid `act` warnings when running tests – without it all of the tests output a bunch of `act` icon errors. @michael-s-molina I know you worked on this, is this still the best case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22364: feat(dashboard): Add edit button to dashboard native filters filter cards
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22364:
URL: https://github.com/apache/superset/pull/22364#issuecomment-1343039903
# [Codecov](https://codecov.io/gh/apache/superset/pull/22364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22364](https://codecov.io/gh/apache/superset/pull/22364?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aed9279) into [master](https://codecov.io/gh/apache/superset/commit/2731cbacbf5ce7220d114ac85186e27136926deb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2731cba) will **increase** coverage by `0.00%`.
> The diff coverage is `77.14%`.
> :exclamation: Current head aed9279 differs from pull request most recent head 630af0c. Consider uploading reports for the commit 630af0c to get more accurate results
```diff
@@ Coverage Diff @@
## master #22364 +/- ##
=======================================
Coverage 66.86% 66.87%
=======================================
Files 1847 1847
Lines 70559 70572 +13
Branches 7736 7741 +5
=======================================
+ Hits 47180 47195 +15
+ Misses 21378 21376 -2
Partials 2001 2001
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.85% <76.47%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rontend/src/components/DropdownContainer/index.tsx](https://codecov.io/gh/apache/superset/pull/22364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRHJvcGRvd25Db250YWluZXIvaW5kZXgudHN4) | `72.83% <ø> (ø)` | |
| [...Filters/FilterBar/FiltersDropdownContent/index.tsx](https://codecov.io/gh/apache/superset/pull/22364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlcnNEcm9wZG93bkNvbnRlbnQvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
| [...s/FilterBar/FiltersOutOfScopeCollapsible/index.tsx](https://codecov.io/gh/apache/superset/pull/22364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlcnNPdXRPZlNjb3BlQ29sbGFwc2libGUvaW5kZXgudHN4) | `20.00% <ø> (ø)` | |
| [...nents/nativeFilters/FilterCard/DependenciesRow.tsx](https://codecov.io/gh/apache/superset/pull/22364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ2FyZC9EZXBlbmRlbmNpZXNSb3cudHN4) | `80.00% <ø> (ø)` | |
| [...oard/components/nativeFilters/FilterCard/index.tsx](https://codecov.io/gh/apache/superset/pull/22364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ2FyZC9pbmRleC50c3g=) | `8.33% <0.00%> (-1.67%)` | :arrow_down: |
| [...ore/components/controls/DateFilterControl/types.ts](https://codecov.io/gh/apache/superset/pull/22364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC90eXBlcy50cw==) | `100.00% <ø> (ø)` | |
| [...ols/DndColumnSelectControl/ColumnSelectPopover.tsx](https://codecov.io/gh/apache/superset/pull/22364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0NvbHVtblNlbGVjdFBvcG92ZXIudHN4) | `3.37% <0.00%> (ø)` | |
| [...d/src/filters/components/Time/TimeFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/22364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL1RpbWVGaWx0ZXJQbHVnaW4udHN4) | `0.00% <0.00%> (ø)` | |
| [...tend/src/filters/components/Time/transformProps.ts](https://codecov.io/gh/apache/superset/pull/22364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL3RyYW5zZm9ybVByb3BzLnRz) | `0.00% <ø> (ø)` | |
| [...rset-frontend/src/filters/components/Time/types.ts](https://codecov.io/gh/apache/superset/pull/22364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| ... and [15 more](https://codecov.io/gh/apache/superset/pull/22364/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on a diff in pull request #22364: feat(dashboard): Add edit button to dashboard native filters filter cards
Posted by GitBox <gi...@apache.org>.
codyml commented on code in PR #22364:
URL: https://github.com/apache/superset/pull/22364#discussion_r1043646724
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/FilterCard.test.tsx:
##########
@@ -204,6 +205,13 @@ jest.mock('@superset-ui/core', () => ({
}),
}));
+jest.mock(
Review Comment:
I thought this is what you had to add to avoid `act` warnings when running tests – without it all of the tests output a bunch of `act` icon errors. @michael-s-molina I know you worked on this, is this still the best solution to avoiding those test warnings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22364: feat(dashboard): Add edit button to dashboard native filters filter cards
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22364:
URL: https://github.com/apache/superset/pull/22364#issuecomment-1344342955
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kasiazjc commented on pull request #22364: feat(dashboard): Add edit button to dashboard native filters filter cards
Posted by GitBox <gi...@apache.org>.
kasiazjc commented on PR #22364:
URL: https://github.com/apache/superset/pull/22364#issuecomment-1344276154
> @kasiazjc Fixed icon size:
>
> <img alt="Screen Shot 2022-12-08 at 6 28 34 PM" width="884" src="https://user-images.githubusercontent.com/13007381/206602696-ad14196e-063d-4ab4-96ff-7cb1572e9670.png">
Perfect, thank you! 😌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #22364: feat(dashboard): Add edit button to dashboard native filters filter cards
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #22364:
URL: https://github.com/apache/superset/pull/22364#issuecomment-1342407898
/testenv up FEATURE_HORIZONTAL_FILTER_BAR=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a diff in pull request #22364: feat(dashboard): Add edit button to dashboard native filters filter cards
Posted by GitBox <gi...@apache.org>.
kgabryje commented on code in PR #22364:
URL: https://github.com/apache/superset/pull/22364#discussion_r1043631518
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/FilterCard.test.tsx:
##########
@@ -204,6 +205,13 @@ jest.mock('@superset-ui/core', () => ({
}),
}));
+jest.mock(
Review Comment:
do we need that? I think that testing icons didnt require hacks before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a diff in pull request #22364: feat(dashboard): Add edit button to dashboard native filters filter cards
Posted by GitBox <gi...@apache.org>.
kgabryje commented on code in PR #22364:
URL: https://github.com/apache/superset/pull/22364#discussion_r1043630758
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/FilterCard.test.tsx:
##########
@@ -217,90 +225,116 @@ const getTextInHTMLTags =
return nodeHasText && childrenDontHaveText;
};
+const hidePopover = jest.fn();
+
const renderContent = (filter = baseFilter, initialState = baseInitialState) =>
- render(<FilterCardContent filter={filter} />, {
+ render(<FilterCardContent filter={filter} hidePopover={hidePopover} />, {
useRedux: true,
initialState,
});
-describe('Filter Card', () => {
- it('Basic', () => {
- renderContent();
- expect(screen.getByText('Native filter 1')).toBeVisible();
- expect(screen.getByLabelText('filter-small')).toBeVisible();
+test('filter card title, type, scope, dependencies', () => {
+ renderContent();
+ expect(screen.getByText('Native filter 1')).toBeVisible();
+ expect(screen.getByLabelText('filter-small')).toBeVisible();
- expect(screen.getByText('Filter type')).toBeVisible();
- expect(screen.getByText('Select filter')).toBeVisible();
+ expect(screen.getByText('Filter type')).toBeVisible();
+ expect(screen.getByText('Select filter')).toBeVisible();
- expect(screen.getByText('Scope')).toBeVisible();
- expect(screen.getByText('All charts')).toBeVisible();
+ expect(screen.getByText('Scope')).toBeVisible();
+ expect(screen.getByText('All charts')).toBeVisible();
- expect(screen.queryByText('Dependencies')).not.toBeInTheDocument();
- });
+ expect(screen.queryByText('Dependencies')).not.toBeInTheDocument();
+ screen.logTestingPlaygroundURL();
Review Comment:
do we need that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on pull request #22364: feat(dashboard): Add edit button to dashboard native filters filter cards
Posted by GitBox <gi...@apache.org>.
codyml commented on PR #22364:
URL: https://github.com/apache/superset/pull/22364#issuecomment-1343720021
@kasiazjc Fixed icon size:
<img width="884" alt="Screen Shot 2022-12-08 at 6 28 34 PM" src="https://user-images.githubusercontent.com/13007381/206602696-ad14196e-063d-4ab4-96ff-7cb1572e9670.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #22364: feat(dashboard): Add edit button to dashboard native filters filter cards
Posted by GitBox <gi...@apache.org>.
kgabryje merged PR #22364:
URL: https://github.com/apache/superset/pull/22364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org