You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/07/23 11:38:20 UTC

[GitHub] [zookeeper] lgxbslgx opened a new pull request, #1908: Java classpath should contain libs about metrics providers

lgxbslgx opened a new pull request, #1908:
URL: https://github.com/apache/zookeeper/pull/1908

   Hi all,
   
   When developing zookeeper, we often start or debug it by using the current source code instead of the built package. So it is good to add the classes about metrics providers to the classpath to avoid ClassNotFound exception. This ClassNotFound exception happens when we use the config `metricsProvider.className=org.apache.zookeeper.metrics.prometheus.PrometheusMetricsProvider` to start zookeeper.
   
   Thanks for taking the time to review.
   
   Best Regards,
   -- Guoxiong


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] lgxbslgx commented on pull request #1908: [ZOOKEEPER-4671] Java classpath should contain libs about metrics providers

Posted by "lgxbslgx (via GitHub)" <gi...@apache.org>.
lgxbslgx commented on PR #1908:
URL: https://github.com/apache/zookeeper/pull/1908#issuecomment-1446578968

   Thanks for the review. What should I do now? Just wait this patch to be integrated by someone with commit privilege?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] maoling commented on pull request #1908: Java classpath should contain libs about metrics providers

Posted by "maoling (via GitHub)" <gi...@apache.org>.
maoling commented on PR #1908:
URL: https://github.com/apache/zookeeper/pull/1908#issuecomment-1408672252

   Good catch @lgxbslgx .
   1. Thanks for this contribution. It's better to create a [JIRA](https://issues.apache.org/jira/projects/ZOOKEEPER/) issue (sign up JIRA if you don't have an account) to bind this PR to a JIRA-ID. ZooKeeper uses the GitHub workflow. The contributor guideline is [here](https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute) 
   2. This issue also exists in the `window` OS? and we also need to update the `zkEnv.cmd` shell?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] lgxbslgx commented on pull request #1908: [ZOOKEEPER-4671] Java classpath should contain libs about metrics providers

Posted by "lgxbslgx (via GitHub)" <gi...@apache.org>.
lgxbslgx commented on PR #1908:
URL: https://github.com/apache/zookeeper/pull/1908#issuecomment-1473254437

   Thanks for the review. Could I get your help to sponsor this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] eolivelli commented on pull request #1908: [ZOOKEEPER-4671] Java classpath should contain libs about metrics providers

Posted by "eolivelli (via GitHub)" <gi...@apache.org>.
eolivelli commented on PR #1908:
URL: https://github.com/apache/zookeeper/pull/1908#issuecomment-1446625305

   we need another reviewer to review and sponsor the patch.
   if you want you could advertise about it on dev@zookeeper.apache.org
   
   let me tag a few people
   @tisonkun @maoling @ztzg @symat @anmolnar 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] tisonkun commented on pull request #1908: [ZOOKEEPER-4671] Java classpath should contain libs about metrics providers

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #1908:
URL: https://github.com/apache/zookeeper/pull/1908#issuecomment-1473269946

   Merging...
   
   Thanks for your contribnution @lgxbslgx!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] lgxbslgx commented on pull request #1908: [ZOOKEEPER-4671] Java classpath should contain libs about metrics providers

Posted by "lgxbslgx (via GitHub)" <gi...@apache.org>.
lgxbslgx commented on PR #1908:
URL: https://github.com/apache/zookeeper/pull/1908#issuecomment-1418645312

   > 1. Thanks for this contribution. It's better to create a [JIRA](https://issues.apache.org/jira/projects/ZOOKEEPER/) issue (sign up JIRA if you don't have an account) to bind this PR to a JIRA-ID. ZooKeeper uses the GitHub workflow. The contributor guideline is [here](https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute)
   
   Thanks for your guide. I created the issue and edited the title of this PR just now.
   
   > 2. This issue also exists in the `window` OS? and we also need to update the `zkEnv.cmd` shell?
   
   The `zkEnv.cmd` may have such similar problem. But my dev enviroment is linux and I don't have `windows` OS now, so I can't verify it and provide the right patch to solve it. I need some help. Or can someone else who uses `windows` system provide another patch to solve this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] maoling commented on pull request #1908: [ZOOKEEPER-4671] Java classpath should contain libs about metrics providers

Posted by "maoling (via GitHub)" <gi...@apache.org>.
maoling commented on PR #1908:
URL: https://github.com/apache/zookeeper/pull/1908#issuecomment-1446398606

   @eolivelli PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] tisonkun merged pull request #1908: [ZOOKEEPER-4671] Java classpath should contain libs about metrics providers

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #1908:
URL: https://github.com/apache/zookeeper/pull/1908


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org