You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/07 13:35:47 UTC
[GitHub] [airflow] potiuk opened a new pull request #7380: [AIRFLOW-6755]
Fix snowlfage hook bug and tests
potiuk opened a new pull request #7380: [AIRFLOW-6755] Fix snowlfage hook bug and tests
URL: https://github.com/apache/airflow/pull/7380
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #7380:
[AIRFLOW-6755] Fix snowlfage hook bug and tests
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7380: [AIRFLOW-6755] Fix snowlfage hook bug and tests
URL: https://github.com/apache/airflow/pull/7380#discussion_r376395839
##########
File path: tests/providers/snowflake/operators/test_s3_to_snowflake.py
##########
@@ -20,7 +20,7 @@
from unittest import mock
Review comment:
Can you also update [this tests](https://github.com/apache/airflow/blob/master/tests/test_project_structure.py#L55-L57)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7380:
[AIRFLOW-6755] Fix snowflake hook bug and tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7380: [AIRFLOW-6755] Fix snowflake hook bug and tests
URL: https://github.com/apache/airflow/pull/7380#discussion_r376423542
##########
File path: tests/providers/snowflake/operators/test_s3_to_snowflake.py
##########
@@ -20,7 +20,7 @@
from unittest import mock
Review comment:
Yop. Good catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7380: [AIRFLOW-6755] Fix
snowflake hook bug and tests
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7380: [AIRFLOW-6755] Fix snowflake hook bug and tests
URL: https://github.com/apache/airflow/pull/7380
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7380: [AIRFLOW-6755] Fix
snowflake hook bug and tests
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7380: [AIRFLOW-6755] Fix snowflake hook bug and tests
URL: https://github.com/apache/airflow/pull/7380#issuecomment-583471217
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7380?src=pr&el=h1) Report
> Merging [#7380](https://codecov.io/gh/apache/airflow/pull/7380?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/52db2abfffb5ffad6d1ed9c7e1b65762b51cda48?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7380/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7380?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7380 +/- ##
==========================================
+ Coverage 86.06% 86.12% +0.05%
==========================================
Files 871 871
Lines 40642 40643 +1
==========================================
+ Hits 34980 35003 +23
+ Misses 5662 5640 -22
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7380?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/snowflake/hooks/snowflake.py](https://codecov.io/gh/apache/airflow/pull/7380/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvc25vd2ZsYWtlL2hvb2tzL3Nub3dmbGFrZS5weQ==) | `81.48% <100%> (+81.48%)` | :arrow_up: |
| [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7380/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0%> (-64.16%)` | :arrow_down: |
| [airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7380/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==) | `30.43% <0%> (-45.66%)` | :arrow_down: |
| [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7380/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55% <0%> (-45%)` | :arrow_down: |
| [airflow/providers/apache/hive/hooks/hive.py](https://codecov.io/gh/apache/airflow/pull/7380/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvaG9va3MvaGl2ZS5weQ==) | `76.02% <0%> (-1.54%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7380/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `90.9% <0%> (-0.83%)` | :arrow_down: |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7380/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.19% <0%> (-0.15%)` | :arrow_down: |
| [airflow/providers/snowflake/operators/snowflake.py](https://codecov.io/gh/apache/airflow/pull/7380/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvc25vd2ZsYWtlL29wZXJhdG9ycy9zbm93Zmxha2UucHk=) | `95.83% <0%> (+95.83%)` | :arrow_up: |
| [...w/providers/snowflake/operators/s3\_to\_snowflake.py](https://codecov.io/gh/apache/airflow/pull/7380/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvc25vd2ZsYWtlL29wZXJhdG9ycy9zM190b19zbm93Zmxha2UucHk=) | `100% <0%> (+100%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7380?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7380?src=pr&el=footer). Last update [52db2ab...4e7b5d3](https://codecov.io/gh/apache/airflow/pull/7380?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services