[GitHub] xiaohui-sun commented on a change in pull request #3603: [TE] Endpoints for create and edit alert yaml along with validators

[GitBox <gi...@apache.org>]

xiaohui-sun commented on a change in pull request #3603: [TE] Endpoints for create and edit alert yaml along with validators
URL: https://github.com/apache/incubator-pinot/pull/3603#discussion_r240669078
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/test/resources/com/linkedin/thirdeye/detection/yaml/alertconfig/alert-config-2.yaml
 ##########
 @@ -0,0 +1,42 @@
+subscriptionGroupName: "Subscription Group Name"
+cron: "0 0/5 * 1/1 * ? *"
+application: "test_application"
+active: true
+fromAddress: thirdeye@thirdeye.com
+
+type: DIMENSIONAL_ALERTER_PIPELINE
+dimensionRecipients:
+ "android":
+  - "android-thirdeye@thirdeye.com"
+ "ios":
+  - "ios-thirdeye@thirdeye.com"
+dimension: app_name
+
+detectionConfigIds:
+ - 5773069
 
 Review comment:
   Is there a unique name to identify the detection config? Using the name would be more user friendly instead of id. We can do the conversion in backend.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org