You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "hermanschaaf (via GitHub)" <gi...@apache.org> on 2023/04/11 08:17:43 UTC
[GitHub] [arrow] hermanschaaf opened a new pull request, #35028: GH-35027: [Go]: Use base64.StdEncoding in FixedSizeBinaryBuilder Unmarshal
hermanschaaf opened a new pull request, #35028:
URL: https://github.com/apache/arrow/pull/35028
This changes `FixedSizeBinaryBuilder`'s Unmarshal to use `base64.StdEncoding` instead of `base64.RawStdEncoding`. The previous implementation caused an error when unmarshaling from JSON previously produced by a `FixedSizeBinary` array instance.
I also added a test for Marshal/Unmarshal to set the expectation that these operations should mirror one another.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35028: GH-35027: [Go]: Use base64.StdEncoding in FixedSizeBinaryBuilder Unmarshal
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35028:
URL: https://github.com/apache/arrow/pull/35028#issuecomment-1502890351
* Closes: #35027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #35028: GH-35027: [Go]: Use base64.StdEncoding in FixedSizeBinaryBuilder Unmarshal
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #35028:
URL: https://github.com/apache/arrow/pull/35028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35028: GH-35027: [Go]: Use base64.StdEncoding in FixedSizeBinaryBuilder Unmarshal
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35028:
URL: https://github.com/apache/arrow/pull/35028#issuecomment-1510638418
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b4c230c792204f67a9ea8ee12a887263...81eb4f2025a3492ea594fa0566aa14ba/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] disq commented on pull request #35028: GH-35027: [Go]: Use base64.StdEncoding in FixedSizeBinaryBuilder Unmarshal
Posted by "disq (via GitHub)" <gi...@apache.org>.
disq commented on PR #35028:
URL: https://github.com/apache/arrow/pull/35028#issuecomment-1508354586
> I'm not sure why some tests are failing for certain architectures and not others. Any help/advice here would be appreciated 🙇
Looks like the go 1.18 tests are more comperehensive, should work now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35028: GH-35027: [Go]: Use base64.StdEncoding in FixedSizeBinaryBuilder Unmarshal
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35028:
URL: https://github.com/apache/arrow/pull/35028#issuecomment-1502890434
:warning: GitHub issue #35027 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35028: GH-35027: [Go]: Use base64.StdEncoding in FixedSizeBinaryBuilder Unmarshal
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35028:
URL: https://github.com/apache/arrow/pull/35028#issuecomment-1503562206
@hermanschaaf It looks like the common thread is an issue with Go 1.18 (as opposed to Go 1.17 which is succeeding)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] hermanschaaf commented on pull request #35028: GH-35027: [Go]: Use base64.StdEncoding in FixedSizeBinaryBuilder Unmarshal
Posted by "hermanschaaf (via GitHub)" <gi...@apache.org>.
hermanschaaf commented on PR #35028:
URL: https://github.com/apache/arrow/pull/35028#issuecomment-1502912588
I'm not sure why some tests are failing for certain architectures and not others. Any help/advice here would be appreciated 🙇
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35028: GH-35027: [Go]: Use base64.StdEncoding in FixedSizeBinaryBuilder Unmarshal
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35028:
URL: https://github.com/apache/arrow/pull/35028#issuecomment-1510621814
Benchmark runs are scheduled for baseline = 59fe4ce90e2f5de50a62656551219d1e2c968126 and contender = 3f5457df8e6646f26834280baeb3d485aaad3320. 3f5457df8e6646f26834280baeb3d485aaad3320 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e7dca379128d47c9a7de07d15419ceea...7a9a4d94dbd04311a4d7853ea70648b4/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9273505059db430cbdb73b54c6285f00...607e515c51c942c9b91dc7f98df94e41/)
[Finished :arrow_down:3.06% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b4c230c792204f67a9ea8ee12a887263...81eb4f2025a3492ea594fa0566aa14ba/)
[Finished :arrow_down:0.49% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/fbfa33122c85433d8c13802be7868528...2195f9d6310b485bb5a0b915626885ac/)
Buildkite builds:
[Finished] [`3f5457df` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2716)
[Failed] [`3f5457df` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2750)
[Finished] [`3f5457df` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2714)
[Finished] [`3f5457df` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2741)
[Finished] [`59fe4ce9` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2715)
[Failed] [`59fe4ce9` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2749)
[Finished] [`59fe4ce9` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2713)
[Finished] [`59fe4ce9` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2740)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org