[GitHub] [incubator-hudi] xushiyan commented on pull request #1592: [Hudi-69] Spark Datasource for MOR table

[GitBox <gi...@apache.org>]

xushiyan commented on pull request #1592:
URL: https://github.com/apache/incubator-hudi/pull/1592#issuecomment-628845961


   @garyli1019 it does look very weird... getting NPE at org.apache.hudi.functional.TestDataSource.testSparkDatasourceForMergeOnRead(TestDataSource.scala:227, means the `basepath` was set to null somehow. But wouldn't it be null in L222 and L223 of the same method? The test method passes locally for me as well.  I don't have clue on why travis ran it differently..but at least try this change for that method
   
   ```java
   @Test
   def testSparkDatasourceForMergeOnRead(@TempDir tempDir: java.nio.file.Path) {
     val basePath = tempDir.toAbsolutePath.toString
   }
   ```
   junit 5 should give it a new dedicated temp dir.. see if NPE still persists..


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org