You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/25 05:35:10 UTC

[GitHub] [camel] sms0070 opened a new pull request #4680: [CAMEL-15891]ByteArrayBodyGenerator for String body

sms0070 opened a new pull request #4680:
URL: https://github.com/apache/camel/pull/4680


   The issue is due to a mistake done by async-http-client team.
   
   Commit : AsyncHttpClient/async-http-client@d47c56e#diff-5247ce5d437efdde629533d6239bf0c24358bdf0157fa204050e908c48a8c1f3
   
   They made the ByteArrayBodyGenerator constructor package level.
   Due to this change, camel had to adapt and for String type of body, they changed their implementation from ByteArrayBodyGenerator to InputStreamBodyGenerator.
   In InputStreamBodyGenerator, the content length is by default set to -1.
   Since, content length was less than 0, NettyRequestFactory in async-http-client was using Transfer-Encoding header instead of Content-Length header.
   
   Solution :
   
   Async-http-client team corrected their mistake in the following commit :
   AsyncHttpClient/async-http-client@4469c30#diff-208f8952b67ba2a28d2cb2d6881485f8fc1b2b5df53a841d4a4a48b2ed8aded0
   
   However, the change was not reverted in camel, and hence, this regression has happened.
   The change needs to be reverted in camel as well. This is causing regression when we are migrating from lower camel versions to higher versions.
   
   The change to inputStreamBodyGenerator was introduced with the following commit.
   684ef57#diff-4d41a9fe212a88af9bc5cddb7e348f8031f39ceaf2263d7275fc4b6dd09e0867


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] oscerd closed pull request #4680: [CAMEL-15891]ByteArrayBodyGenerator for String body

Posted by GitBox <gi...@apache.org>.
oscerd closed pull request #4680:
URL: https://github.com/apache/camel/pull/4680


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org