You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Cagatay Civici <ca...@gmail.com> on 2007/12/23 01:42:25 UTC
HtmlColumn 1.2
Hi,
I've noticed this weird thing in impl 1.2 build. In myfaces-build ->
HtmlColumn.xml the component type is set as;
<component-type>javax.faces.HtmlColumn</component-type>
But in the generated HtmlColumnTag.java in myfaces-impl 1.2 by faces plugin,
it is;
@Override
public String getComponentType()
{
return "javax.faces.Column";
}
Shouldn't it return "javax.faces.HtmlColumn"?
Cagatay
Re: HtmlColumn 1.2
Posted by Matthias Wessendorf <ma...@apache.org>.
I'll get to it after xmas.
-M
On Dec 23, 2007 1:14 PM, Cagatay Civici <ca...@gmail.com> wrote:
> Ok, I see.
>
> But the component-type for HtmlColumn in standart faces-config is still
> "javax.faces.HtmlColumn".
>
> I see this strange issue when using h:column and h:datatable;
>
> Caused by: java.lang.IllegalArgumentException : Component
> javax.faces.component.UIColumn is no HtmlColumn
> at
> org.apache.myfaces.taglib.html.HtmlColumnTag.setProperties(HtmlColumnTag.java:71)
>
>
>
> On Dec 23, 2007 3:09 AM, Bruno Aranda < brunoaranda@gmail.com> wrote:
> > Hi, see https://issues.apache.org/jira/browse/MYFACES-1790
> >
> > Acording to the release (section 4.1.1.1) the component type for
> > UIColumn is "javax.faces.Column", bug which was fixed last week, but
> > apparently fixing it has provoked some side effect. And the component
> > type in the xml should be that one (I don't understand why what you
> > describe happens though).
> >
> > Cheers,
> >
> > Bruno
> >
> >
> >
> >
> >
> > On 23/12/2007, Cagatay Civici <ca...@gmail.com> wrote:
> > > Hi,
> > >
> > > I've noticed this weird thing in impl 1.2 build. In myfaces-build ->
> > > HtmlColumn.xml the component type is set as;
> > >
> > > <component-type>javax.faces.HtmlColumn</component-type>
> > >
> > > But in the generated HtmlColumnTag.java in myfaces-impl 1.2 by faces
> plugin,
> > > it is;
> > >
> > > @Override
> > > public String getComponentType()
> > > {
> > > return "javax.faces.Column";
> > > }
> > >
> > > Shouldn't it return " javax.faces.HtmlColumn "?
> > >
> > > Cagatay
> > >
> > >
> > >
> >
>
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org
Re: HtmlColumn 1.2
Posted by Matthias Wessendorf <ma...@apache.org>.
this requires a change in the plugins, to
generate a check against UIColumn, instead of HtmlColumn
-M
On Dec 23, 2007 1:14 PM, Cagatay Civici <ca...@gmail.com> wrote:
> Ok, I see.
>
> But the component-type for HtmlColumn in standart faces-config is still
> "javax.faces.HtmlColumn".
>
> I see this strange issue when using h:column and h:datatable;
>
> Caused by: java.lang.IllegalArgumentException : Component
> javax.faces.component.UIColumn is no HtmlColumn
> at
> org.apache.myfaces.taglib.html.HtmlColumnTag.setProperties(HtmlColumnTag.java:71)
>
>
>
> On Dec 23, 2007 3:09 AM, Bruno Aranda < brunoaranda@gmail.com> wrote:
> > Hi, see https://issues.apache.org/jira/browse/MYFACES-1790
> >
> > Acording to the release (section 4.1.1.1) the component type for
> > UIColumn is "javax.faces.Column", bug which was fixed last week, but
> > apparently fixing it has provoked some side effect. And the component
> > type in the xml should be that one (I don't understand why what you
> > describe happens though).
> >
> > Cheers,
> >
> > Bruno
> >
> >
> >
> >
> >
> > On 23/12/2007, Cagatay Civici <ca...@gmail.com> wrote:
> > > Hi,
> > >
> > > I've noticed this weird thing in impl 1.2 build. In myfaces-build ->
> > > HtmlColumn.xml the component type is set as;
> > >
> > > <component-type>javax.faces.HtmlColumn</component-type>
> > >
> > > But in the generated HtmlColumnTag.java in myfaces-impl 1.2 by faces
> plugin,
> > > it is;
> > >
> > > @Override
> > > public String getComponentType()
> > > {
> > > return "javax.faces.Column";
> > > }
> > >
> > > Shouldn't it return " javax.faces.HtmlColumn "?
> > >
> > > Cagatay
> > >
> > >
> > >
> >
>
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org
Re: HtmlColumn 1.2
Posted by Leonardo Uribe <lu...@gmail.com>.
The changes made in trunk of 1.2.6 plugins are necessary to make this
solution work.
I think that the spec is wrong, the component type of HtmlColumnTag
should be javax.faces.HtmlColumn and not
javax.faces.Column. But we need to be according to the spec if we want
a release, so is a fact that the component
type for this tag class is javax.faces.Column.
I have made a full revision of the solution applied that comply with
the spec including the changes on plugins.
Looking the latest log on maven-faces-plugin, I have noted the changes:
org.apache.myfaces.trinidadbuild.plugin.faces.generator.taglib.MyFacesComponentTagGenerator
public void writeGetComponentType(PrettyWriter out,
ComponentBean component) throws IOException
{
String componentType = component.getComponentType();
if("javax.faces.HtmlColumn".equals(componentType))
{
componentType = "javax.faces.Column";
}
.....
This is what the spec says
protected void writeSetPropertyMethodBody(PrettyWriter out,
String componentClass,
Iterator properties)
throws IOException
{
if("HtmlColumn".equals(componentClass))
{
componentClass = "UIColumn";
}
.......
This is fine, because as side effect of set the component type now we
are creating UIColumn instances and
not HtmlColumn instances (note that HtmlColumn will not be used anymore!!! ).
The effect of this changes is generate a proper tag class.
(org.apache.myfaces.taglib.html.HtmlColumnTag)
Now the side effects of this change. The class that render columns on myfaces is
org.apache.myfaces.shared.renderkit.html.HtmlTableRendererBase
so the change that we need is this:
protected void renderColumnChildHeaderOrFooterRow(FacesContext facesContext,
ResponseWriter writer, UIComponent uiComponent, String
styleClass, boolean isHeader) throws IOException
{
if (uiComponent instanceof UIColumn)
{
// allow column to override style class, new in JSF 1.2
if (uiComponent instanceof HtmlColumn) {
HtmlColumn column = (HtmlColumn)uiComponent;
if (isHeader && column.getHeaderClass()!=null)
styleClass = column.getHeaderClass();
else if (!isHeader && column.getFooterClass()!=null)
styleClass = column.getFooterClass();
}else{
//This code corrects MYFACES-1790, because HtmlColumnTag
//has as component type javax.faces.Column, so as side
//effect it not create HtmlColumn, it create UIColumn
//classes.
UIColumn column = (UIColumn) uiComponent;
if (isHeader){
String headerClass = (String)
column.getAttributes().get("headerClass");
if (headerClass != null){
styleClass = (String) headerClass;
}
}else{
String footerClass = (String)
column.getAttributes().get("footerClass");
if (footerClass != null){
styleClass = (String) footerClass;
}
}
}
......................
Tested with myfaces only and myfaces+facelets works as jsf ri.
Re: HtmlColumn 1.2
Posted by Matthias Wessendorf <ma...@apache.org>.
ah, good.
please do it.
so, we can keep the 1.2.6 plugins, right?
Don't have time to look deeper at it, sorry
-M
On Jan 16, 2008 2:25 PM, Leonardo Uribe <lu...@gmail.com> wrote:
> Hi
>
> Checking one test for h:column headerClass and footerClass (a test for
> see if issue 4 of JSR 252), after MYFACES-1790
> does not work.
>
> The change from javax.faces.HtmlColumn to javax.faces.Column let this
> code on shared without effect:
>
> org.apache.myfaces.shared.renderkit.html.HtmlTableRendererBase
>
> protected void renderColumnChildHeaderOrFooterRow(FacesContext facesContext,
> ResponseWriter writer, UIComponent uiComponent, String
> styleClass, boolean isHeader) throws IOException
> {
> if (uiComponent instanceof UIColumn)
> {
> // allow column to override style class, new in JSF 1.2
> if (uiComponent instanceof HtmlColumn) {
> HtmlColumn column = (HtmlColumn)uiComponent;
> if (isHeader && column.getHeaderClass()!=null)
> styleClass = column.getHeaderClass();
> else if (!isHeader && column.getFooterClass()!=null)
> styleClass = column.getFooterClass();
> }
>
> .........
>
>
> I don't like what spec says (it's just my opinion), because in runtime
> HtmlColumn is never used!.
>
> Testing this against facelets, this library creates UIColumn instances.
>
> Anyway the solution is to make this:
>
> protected void renderColumnChildHeaderOrFooterRow(FacesContext facesContext,
> ResponseWriter writer, UIComponent uiComponent, String
> styleClass, boolean isHeader) throws IOException
> {
> if (uiComponent instanceof UIColumn)
> {
> // allow column to override style class, new in JSF 1.2
> if (uiComponent instanceof HtmlColumn) {
> HtmlColumn column = (HtmlColumn)uiComponent;
> if (isHeader && column.getHeaderClass()!=null)
> styleClass = column.getHeaderClass();
> else if (!isHeader && column.getFooterClass()!=null)
> styleClass = column.getFooterClass();
> }else{
> //This code corrects MYFACES-1790, because HtmlColumnTag
> //has as component type javax.faces.Column, so as side
> //effect it not create HtmlColumn, it create UIColumn
> //classes.
> UIColumn column = (UIColumn) uiComponent;
> if (isHeader){
> String headerClass = (String)
> column.getAttributes().get("headerClass");
> if (headerClass != null){
> styleClass = (String) headerClass;
> }
> }else{
> String footerClass = (String)
> column.getAttributes().get("footerClass");
> if (footerClass != null){
> styleClass = (String) footerClass;
> }
> }
> }
>
> ......................
>
> I have tested this in both environments (pure myfaces and facelets)
> and works well.
>
> I believe this change fix MYFACES-1790
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org
Re: HtmlColumn 1.2
Posted by Leonardo Uribe <lu...@gmail.com>.
Hi
Checking one test for h:column headerClass and footerClass (a test for
see if issue 4 of JSR 252), after MYFACES-1790
does not work.
The change from javax.faces.HtmlColumn to javax.faces.Column let this
code on shared without effect:
org.apache.myfaces.shared.renderkit.html.HtmlTableRendererBase
protected void renderColumnChildHeaderOrFooterRow(FacesContext facesContext,
ResponseWriter writer, UIComponent uiComponent, String
styleClass, boolean isHeader) throws IOException
{
if (uiComponent instanceof UIColumn)
{
// allow column to override style class, new in JSF 1.2
if (uiComponent instanceof HtmlColumn) {
HtmlColumn column = (HtmlColumn)uiComponent;
if (isHeader && column.getHeaderClass()!=null)
styleClass = column.getHeaderClass();
else if (!isHeader && column.getFooterClass()!=null)
styleClass = column.getFooterClass();
}
.........
I don't like what spec says (it's just my opinion), because in runtime
HtmlColumn is never used!.
Testing this against facelets, this library creates UIColumn instances.
Anyway the solution is to make this:
protected void renderColumnChildHeaderOrFooterRow(FacesContext facesContext,
ResponseWriter writer, UIComponent uiComponent, String
styleClass, boolean isHeader) throws IOException
{
if (uiComponent instanceof UIColumn)
{
// allow column to override style class, new in JSF 1.2
if (uiComponent instanceof HtmlColumn) {
HtmlColumn column = (HtmlColumn)uiComponent;
if (isHeader && column.getHeaderClass()!=null)
styleClass = column.getHeaderClass();
else if (!isHeader && column.getFooterClass()!=null)
styleClass = column.getFooterClass();
}else{
//This code corrects MYFACES-1790, because HtmlColumnTag
//has as component type javax.faces.Column, so as side
//effect it not create HtmlColumn, it create UIColumn
//classes.
UIColumn column = (UIColumn) uiComponent;
if (isHeader){
String headerClass = (String)
column.getAttributes().get("headerClass");
if (headerClass != null){
styleClass = (String) headerClass;
}
}else{
String footerClass = (String)
column.getAttributes().get("footerClass");
if (footerClass != null){
styleClass = (String) footerClass;
}
}
}
......................
I have tested this in both environments (pure myfaces and facelets)
and works well.
I believe this change fix MYFACES-1790
Re: HtmlColumn 1.2
Posted by Martin Marinschek <ma...@gmail.com>.
I would agree with Mario - the spec is wrong if this is treated differently.
regards,
Martin
On 1/3/08, Matthias Wessendorf <ma...@apache.org> wrote:
> this one is a special guy;
>
> On Jan 3, 2008 11:37 AM, Mario Ivankovits <ma...@ops.co.at> wrote:
> > Hi!
> > > AFAIK this tag-class is the only tag that the RI folks don't generate.
> > > I don't like to fuck the plugin as well; so we could have this tag as
> > > real code as well;
> > >
> > > regarding the std-faces-cfg I agree that HtmlColumn should
> > > reflect it's type.
> > >
> > > With wrong, you talk about the UIColumn (since 1.2) itself ?
> > >
> > I think that mapping the javax.faces.Column to HtmlColumn in the
> > HtmlColumnTag is wrong. If it is required by the spec, then the spec is
> > wrong, no?
> > Though, I don't know what's the idea behind all this .... I just don't
> > think that any other component behaves that way.
> >
> > Ciao,
> > Mario
> >
> >
>
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> mail: matzew-at-apache-dot-org
>
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
Re: HtmlColumn 1.2
Posted by Matthias Wessendorf <ma...@apache.org>.
this one is a special guy;
On Jan 3, 2008 11:37 AM, Mario Ivankovits <ma...@ops.co.at> wrote:
> Hi!
> > AFAIK this tag-class is the only tag that the RI folks don't generate.
> > I don't like to fuck the plugin as well; so we could have this tag as
> > real code as well;
> >
> > regarding the std-faces-cfg I agree that HtmlColumn should
> > reflect it's type.
> >
> > With wrong, you talk about the UIColumn (since 1.2) itself ?
> >
> I think that mapping the javax.faces.Column to HtmlColumn in the
> HtmlColumnTag is wrong. If it is required by the spec, then the spec is
> wrong, no?
> Though, I don't know what's the idea behind all this .... I just don't
> think that any other component behaves that way.
>
> Ciao,
> Mario
>
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org
Re: HtmlColumn 1.2
Posted by Mario Ivankovits <ma...@ops.co.at>.
Hi!
> AFAIK this tag-class is the only tag that the RI folks don't generate.
> I don't like to fuck the plugin as well; so we could have this tag as
> real code as well;
>
> regarding the std-faces-cfg I agree that HtmlColumn should
> reflect it's type.
>
> With wrong, you talk about the UIColumn (since 1.2) itself ?
>
I think that mapping the javax.faces.Column to HtmlColumn in the
HtmlColumnTag is wrong. If it is required by the spec, then the spec is
wrong, no?
Though, I don't know what's the idea behind all this .... I just don't
think that any other component behaves that way.
Ciao,
Mario
Re: HtmlColumn 1.2
Posted by Matthias Wessendorf <ma...@apache.org>.
AFAIK this tag-class is the only tag that the RI folks don't generate.
I don't like to fuck the plugin as well; so we could have this tag as
real code as well;
regarding the std-faces-cfg I agree that HtmlColumn should
reflect it's type.
With wrong, you talk about the UIColumn (since 1.2) itself ?
On Jan 3, 2008 11:27 AM, Mario Ivankovits <ma...@ops.co.at> wrote:
> Matthias Wessendorf schrieb:
> > I think the TAG-Clazz should cast against UIColumn
> > (instanceof) and not against HtmlColumn;
> >
> Ok, I'll do that, still, I think there is something very wrong if we
> have to check for this special case in the generator all around.
>
> Ciao,
> Mario
>
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org
Re: HtmlColumn 1.2
Posted by Mario Ivankovits <ma...@ops.co.at>.
Matthias Wessendorf schrieb:
> I think the TAG-Clazz should cast against UIColumn
> (instanceof) and not against HtmlColumn;
>
Ok, I'll do that, still, I think there is something very wrong if we
have to check for this special case in the generator all around.
Ciao,
Mario
Re: HtmlColumn 1.2
Posted by Matthias Wessendorf <ma...@apache.org>.
I think the TAG-Clazz should cast against UIColumn
(instanceof) and not against HtmlColumn;
I can look at the generator next week, after vacation.
-M
On Jan 3, 2008 11:20 AM, Mario Ivankovits <ma...@ops.co.at> wrote:
> Hi!
> >
> > After checking against ri and spec; I think we do it in the right
> > way.
> >
> > The component type in htmlcolumntag is javax.faces.column and the
> > component-type in standard-config for htmlcolumn is
> > javax.faces.HtmlColumn.
> >
> I think the componentType in HtmlColumnTag should be javax.faces.HtmlColumn.
> This is what the standard-faces-config.xml reflects too.
> With javax.faces.HtmlColumn you get a
> javax.faces.component.html.HtmlColumn, and with javax.faces.Column you
> get a javax.faces.component.Column.
>
> If the spec thinks a component type of javax.faces.Column should create
> a HtmlColumn it is wrong, no?
>
> I need to have this fixed to being able to proceed with another
> myfaces-1.2 fix - and with my project ...
>
> Ciao,
> Mario
>
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org
Re: HtmlColumn 1.2
Posted by Mario Ivankovits <ma...@ops.co.at>.
Hi!
>
> After checking against ri and spec; I think we do it in the right
> way.
>
> The component type in htmlcolumntag is javax.faces.column and the
> component-type in standard-config for htmlcolumn is
> javax.faces.HtmlColumn.
>
I think the componentType in HtmlColumnTag should be javax.faces.HtmlColumn.
This is what the standard-faces-config.xml reflects too.
With javax.faces.HtmlColumn you get a
javax.faces.component.html.HtmlColumn, and with javax.faces.Column you
get a javax.faces.component.Column.
If the spec thinks a component type of javax.faces.Column should create
a HtmlColumn it is wrong, no?
I need to have this fixed to being able to proceed with another
myfaces-1.2 fix - and with my project ...
Ciao,
Mario
Re: HtmlColumn 1.2
Posted by Martin Marinschek <ma...@gmail.com>.
Hi Cagatay,
but shouldn't the component type be the same in the faces-config and in the
tag?
regards,
Martin
On Dec 24, 2007 12:20 PM, Cagatay Civici <ca...@gmail.com> wrote:
> After checking against ri and spec; I think we do it in the right way.
>
> The component type in htmlcolumntag is javax.faces.column and the
> component-type in standard-config for htmlcolumn is javax.faces.HtmlColumn
> .
>
> The error I get;
>
> Caused by: java.lang.IllegalArgumentException : Component
> javax.faces.component.UIColumn is no HtmlColumn
> at org.apache.myfaces.taglib.html.HtmlColumnTag.setProperties(
> HtmlColumnTag.java:71)
>
> Happened in testing tomahawk 1.2 with myfaces 1.2.1-snapshot, another test
> with plain myfaces(no tomahawk-1.2 around) worked. So I dont think there's
> a need for a change in the plugins for now.
>
> But I cant figure how this is related to tomahawk though since I just use
> h:datatable and h:column.
>
> On Dec 24, 2007 9:36 AM, Matthias Wessendorf <ma...@apache.org> wrote:
>
> > it is just using 1.2.5 of the plugins;
> >
> > -M
> >
> > On Dec 23, 2007 2:48 PM, Matthias Wessendorf <matzew@apache.org > wrote:
> > > +1 on that
> > >
> > >
> > > On Dec 23, 2007 2:46 PM, Bruno Aranda <br...@gmail.com> wrote:
> > > > True, then reverting the fix for the bug should solve everything and
> >
> > > > would allow us to release properly,
> > > >
> > > > Cheers,
> > > >
> > > > Bruno
> > > >
> > > >
> > > > On 23/12/2007, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > btw. javax.faces.HtmlColumn is correct for HtmlColumn
> > > > >
> > > > > see:
> > > > >
> > http://java.sun.com/javaee/javaserverfaces/1.2_MR1/docs/api/constant-values.html#javax.faces.component.html.HtmlColumn.COMPONENT_TYPE
> > > > >
> > > > >
> > > > >
> > > > > On Dec 23, 2007 1:14 PM, Cagatay Civici < cagatay.civici@gmail.com>
> > wrote:
> > > > > > Ok, I see.
> > > > > >
> > > > > > But the component-type for HtmlColumn in standart faces-config
> > is still
> > > > > > "javax.faces.HtmlColumn".
> > > > > >
> > > > > > I see this strange issue when using h:column and h:datatable;
> > > > > >
> > > > > > Caused by: java.lang.IllegalArgumentException : Component
> > > > > > javax.faces.component.UIColumn is no HtmlColumn
> > > > > > at
> > > > > > org.apache.myfaces.taglib.html.HtmlColumnTag.setProperties (
> > HtmlColumnTag.java:71)
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Dec 23, 2007 3:09 AM, Bruno Aranda < brunoaranda@gmail.com >
> > wrote:
> > > > > > > Hi, see https://issues.apache.org/jira/browse/MYFACES-1790
> > > > > > >
> > > > > > > Acording to the release (section 4.1.1.1) the component type
> > for
> > > > > > > UIColumn is "javax.faces.Column", bug which was fixed last
> > week, but
> > > > > > > apparently fixing it has provoked some side effect. And the
> > component
> > > > > > > type in the xml should be that one (I don't understand why
> > what you
> > > > > > > describe happens though).
> > > > > > >
> > > > > > > Cheers,
> > > > > > >
> > > > > > > Bruno
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On 23/12/2007, Cagatay Civici < cagatay.civici@gmail.com>
> > wrote:
> > > > > > > > Hi,
> > > > > > > >
> > > > > > > > I've noticed this weird thing in impl 1.2 build. In
> > myfaces-build ->
> > > > > > > > HtmlColumn.xml the component type is set as;
> > > > > > > >
> > > > > > > > <component-type>javax.faces.HtmlColumn </component-type>
> > > > > > > >
> > > > > > > > But in the generated HtmlColumnTag.java in myfaces-impl 1.2by faces
> > > > > > plugin,
> > > > > > > > it is;
> > > > > > > >
> > > > > > > > @Override
> > > > > > > > public String getComponentType()
> > > > > > > > {
> > > > > > > > return " javax.faces.Column";
> > > > > > > > }
> > > > > > > >
> > > > > > > > Shouldn't it return " javax.faces.HtmlColumn "?
> > > > > > > >
> > > > > > > > Cagatay
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > >
> > > > > further stuff:
> > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > sessions: http://www.slideshare.net/mwessendorf
> > > > > mail: matzew-at-apache-dot-org
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > >
> > > Matthias Wessendorf
> > >
> > > further stuff:
> > > blog: http://matthiaswessendorf.wordpress.com/
> > > sessions: http://www.slideshare.net/mwessendorf
> > > mail: matzew-at-apache-dot-org
> > >
> >
> >
> >
> > --
> > Matthias Wessendorf
> >
> > further stuff:
> > blog: http://matthiaswessendorf.wordpress.com/
> > sessions: http://www.slideshare.net/mwessendorf
> > mail: matzew-at-apache-dot-org
> >
>
>
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
Re: HtmlColumn 1.2
Posted by Cagatay Civici <ca...@gmail.com>.
Just checked RI's ColumnTag, they do a cast to UIColumn. Yes, then the
plugins need a change.
On Dec 24, 2007 1:20 PM, Cagatay Civici <ca...@gmail.com> wrote:
> After checking against ri and spec; I think we do it in the right way.
>
> The component type in htmlcolumntag is javax.faces.column and the
> component-type in standard-config for htmlcolumn is javax.faces.HtmlColumn
> .
>
> The error I get;
>
> Caused by: java.lang.IllegalArgumentException : Component
> javax.faces.component.UIColumn is no HtmlColumn
> at org.apache.myfaces.taglib.html.HtmlColumnTag.setProperties(
> HtmlColumnTag.java:71)
>
> Happened in testing tomahawk 1.2 with myfaces 1.2.1-snapshot, another test
> with plain myfaces(no tomahawk-1.2 around) worked. So I dont think there's
> a need for a change in the plugins for now.
>
> But I cant figure how this is related to tomahawk though since I just use
> h:datatable and h:column.
>
> On Dec 24, 2007 9:36 AM, Matthias Wessendorf <ma...@apache.org> wrote:
>
> > it is just using 1.2.5 of the plugins;
> >
> > -M
> >
> > On Dec 23, 2007 2:48 PM, Matthias Wessendorf <matzew@apache.org > wrote:
> > > +1 on that
> > >
> > >
> > > On Dec 23, 2007 2:46 PM, Bruno Aranda <br...@gmail.com> wrote:
> > > > True, then reverting the fix for the bug should solve everything and
> >
> > > > would allow us to release properly,
> > > >
> > > > Cheers,
> > > >
> > > > Bruno
> > > >
> > > >
> > > > On 23/12/2007, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > btw. javax.faces.HtmlColumn is correct for HtmlColumn
> > > > >
> > > > > see:
> > > > >
> > http://java.sun.com/javaee/javaserverfaces/1.2_MR1/docs/api/constant-values.html#javax.faces.component.html.HtmlColumn.COMPONENT_TYPE
> > > > >
> > > > >
> > > > >
> > > > > On Dec 23, 2007 1:14 PM, Cagatay Civici < cagatay.civici@gmail.com>
> > wrote:
> > > > > > Ok, I see.
> > > > > >
> > > > > > But the component-type for HtmlColumn in standart faces-config
> > is still
> > > > > > "javax.faces.HtmlColumn".
> > > > > >
> > > > > > I see this strange issue when using h:column and h:datatable;
> > > > > >
> > > > > > Caused by: java.lang.IllegalArgumentException : Component
> > > > > > javax.faces.component.UIColumn is no HtmlColumn
> > > > > > at
> > > > > > org.apache.myfaces.taglib.html.HtmlColumnTag.setProperties (
> > HtmlColumnTag.java:71)
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Dec 23, 2007 3:09 AM, Bruno Aranda < brunoaranda@gmail.com >
> > wrote:
> > > > > > > Hi, see https://issues.apache.org/jira/browse/MYFACES-1790
> > > > > > >
> > > > > > > Acording to the release (section 4.1.1.1) the component type
> > for
> > > > > > > UIColumn is "javax.faces.Column", bug which was fixed last
> > week, but
> > > > > > > apparently fixing it has provoked some side effect. And the
> > component
> > > > > > > type in the xml should be that one (I don't understand why
> > what you
> > > > > > > describe happens though).
> > > > > > >
> > > > > > > Cheers,
> > > > > > >
> > > > > > > Bruno
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On 23/12/2007, Cagatay Civici < cagatay.civici@gmail.com>
> > wrote:
> > > > > > > > Hi,
> > > > > > > >
> > > > > > > > I've noticed this weird thing in impl 1.2 build. In
> > myfaces-build ->
> > > > > > > > HtmlColumn.xml the component type is set as;
> > > > > > > >
> > > > > > > > <component-type>javax.faces.HtmlColumn </component-type>
> > > > > > > >
> > > > > > > > But in the generated HtmlColumnTag.java in myfaces-impl 1.2by faces
> > > > > > plugin,
> > > > > > > > it is;
> > > > > > > >
> > > > > > > > @Override
> > > > > > > > public String getComponentType()
> > > > > > > > {
> > > > > > > > return " javax.faces.Column";
> > > > > > > > }
> > > > > > > >
> > > > > > > > Shouldn't it return " javax.faces.HtmlColumn "?
> > > > > > > >
> > > > > > > > Cagatay
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > >
> > > > > further stuff:
> > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > sessions: http://www.slideshare.net/mwessendorf
> > > > > mail: matzew-at-apache-dot-org
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > >
> > > Matthias Wessendorf
> > >
> > > further stuff:
> > > blog: http://matthiaswessendorf.wordpress.com/
> > > sessions: http://www.slideshare.net/mwessendorf
> > > mail: matzew-at-apache-dot-org
> > >
> >
> >
> >
> > --
> > Matthias Wessendorf
> >
> > further stuff:
> > blog: http://matthiaswessendorf.wordpress.com/
> > sessions: http://www.slideshare.net/mwessendorf
> > mail: matzew-at-apache-dot-org
> >
>
>
Re: HtmlColumn 1.2
Posted by Cagatay Civici <ca...@gmail.com>.
After checking against ri and spec; I think we do it in the right way.
The component type in htmlcolumntag is javax.faces.column and the
component-type in standard-config for htmlcolumn is javax.faces.HtmlColumn.
The error I get;
Caused by: java.lang.IllegalArgumentException : Component
javax.faces.component.UIColumn is no HtmlColumn
at org.apache.myfaces.taglib.html.HtmlColumnTag.setProperties(
HtmlColumnTag.java:71)
Happened in testing tomahawk 1.2 with myfaces 1.2.1-snapshot, another test
with plain myfaces(no tomahawk-1.2 around) worked. So I dont think there's a
need for a change in the plugins for now.
But I cant figure how this is related to tomahawk though since I just use
h:datatable and h:column.
On Dec 24, 2007 9:36 AM, Matthias Wessendorf <ma...@apache.org> wrote:
> it is just using 1.2.5 of the plugins;
>
> -M
>
> On Dec 23, 2007 2:48 PM, Matthias Wessendorf <ma...@apache.org> wrote:
> > +1 on that
> >
> >
> > On Dec 23, 2007 2:46 PM, Bruno Aranda <br...@gmail.com> wrote:
> > > True, then reverting the fix for the bug should solve everything and
> > > would allow us to release properly,
> > >
> > > Cheers,
> > >
> > > Bruno
> > >
> > >
> > > On 23/12/2007, Matthias Wessendorf <ma...@apache.org> wrote:
> > > > btw. javax.faces.HtmlColumn is correct for HtmlColumn
> > > >
> > > > see:
> > > >
> http://java.sun.com/javaee/javaserverfaces/1.2_MR1/docs/api/constant-values.html#javax.faces.component.html.HtmlColumn.COMPONENT_TYPE
> > > >
> > > >
> > > >
> > > > On Dec 23, 2007 1:14 PM, Cagatay Civici <ca...@gmail.com>
> wrote:
> > > > > Ok, I see.
> > > > >
> > > > > But the component-type for HtmlColumn in standart faces-config is
> still
> > > > > "javax.faces.HtmlColumn".
> > > > >
> > > > > I see this strange issue when using h:column and h:datatable;
> > > > >
> > > > > Caused by: java.lang.IllegalArgumentException : Component
> > > > > javax.faces.component.UIColumn is no HtmlColumn
> > > > > at
> > > > > org.apache.myfaces.taglib.html.HtmlColumnTag.setProperties(
> HtmlColumnTag.java:71)
> > > > >
> > > > >
> > > > >
> > > > > On Dec 23, 2007 3:09 AM, Bruno Aranda < brunoaranda@gmail.com>
> wrote:
> > > > > > Hi, see https://issues.apache.org/jira/browse/MYFACES-1790
> > > > > >
> > > > > > Acording to the release (section 4.1.1.1) the component type for
> > > > > > UIColumn is "javax.faces.Column", bug which was fixed last week,
> but
> > > > > > apparently fixing it has provoked some side effect. And the
> component
> > > > > > type in the xml should be that one (I don't understand why what
> you
> > > > > > describe happens though).
> > > > > >
> > > > > > Cheers,
> > > > > >
> > > > > > Bruno
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > On 23/12/2007, Cagatay Civici <ca...@gmail.com> wrote:
> > > > > > > Hi,
> > > > > > >
> > > > > > > I've noticed this weird thing in impl 1.2 build. In
> myfaces-build ->
> > > > > > > HtmlColumn.xml the component type is set as;
> > > > > > >
> > > > > > > <component-type>javax.faces.HtmlColumn</component-type>
> > > > > > >
> > > > > > > But in the generated HtmlColumnTag.java in myfaces-impl 1.2 by
> faces
> > > > > plugin,
> > > > > > > it is;
> > > > > > >
> > > > > > > @Override
> > > > > > > public String getComponentType()
> > > > > > > {
> > > > > > > return "javax.faces.Column";
> > > > > > > }
> > > > > > >
> > > > > > > Shouldn't it return " javax.faces.HtmlColumn "?
> > > > > > >
> > > > > > > Cagatay
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Matthias Wessendorf
> > > >
> > > > further stuff:
> > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > sessions: http://www.slideshare.net/mwessendorf
> > > > mail: matzew-at-apache-dot-org
> > > >
> > >
> >
> >
> >
> > --
> >
> > Matthias Wessendorf
> >
> > further stuff:
> > blog: http://matthiaswessendorf.wordpress.com/
> > sessions: http://www.slideshare.net/mwessendorf
> > mail: matzew-at-apache-dot-org
> >
>
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> mail: matzew-at-apache-dot-org
>
Re: HtmlColumn 1.2
Posted by Matthias Wessendorf <ma...@apache.org>.
it is just using 1.2.5 of the plugins;
-M
On Dec 23, 2007 2:48 PM, Matthias Wessendorf <ma...@apache.org> wrote:
> +1 on that
>
>
> On Dec 23, 2007 2:46 PM, Bruno Aranda <br...@gmail.com> wrote:
> > True, then reverting the fix for the bug should solve everything and
> > would allow us to release properly,
> >
> > Cheers,
> >
> > Bruno
> >
> >
> > On 23/12/2007, Matthias Wessendorf <ma...@apache.org> wrote:
> > > btw. javax.faces.HtmlColumn is correct for HtmlColumn
> > >
> > > see:
> > > http://java.sun.com/javaee/javaserverfaces/1.2_MR1/docs/api/constant-values.html#javax.faces.component.html.HtmlColumn.COMPONENT_TYPE
> > >
> > >
> > >
> > > On Dec 23, 2007 1:14 PM, Cagatay Civici <ca...@gmail.com> wrote:
> > > > Ok, I see.
> > > >
> > > > But the component-type for HtmlColumn in standart faces-config is still
> > > > "javax.faces.HtmlColumn".
> > > >
> > > > I see this strange issue when using h:column and h:datatable;
> > > >
> > > > Caused by: java.lang.IllegalArgumentException : Component
> > > > javax.faces.component.UIColumn is no HtmlColumn
> > > > at
> > > > org.apache.myfaces.taglib.html.HtmlColumnTag.setProperties(HtmlColumnTag.java:71)
> > > >
> > > >
> > > >
> > > > On Dec 23, 2007 3:09 AM, Bruno Aranda < brunoaranda@gmail.com> wrote:
> > > > > Hi, see https://issues.apache.org/jira/browse/MYFACES-1790
> > > > >
> > > > > Acording to the release (section 4.1.1.1) the component type for
> > > > > UIColumn is "javax.faces.Column", bug which was fixed last week, but
> > > > > apparently fixing it has provoked some side effect. And the component
> > > > > type in the xml should be that one (I don't understand why what you
> > > > > describe happens though).
> > > > >
> > > > > Cheers,
> > > > >
> > > > > Bruno
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > On 23/12/2007, Cagatay Civici <ca...@gmail.com> wrote:
> > > > > > Hi,
> > > > > >
> > > > > > I've noticed this weird thing in impl 1.2 build. In myfaces-build ->
> > > > > > HtmlColumn.xml the component type is set as;
> > > > > >
> > > > > > <component-type>javax.faces.HtmlColumn</component-type>
> > > > > >
> > > > > > But in the generated HtmlColumnTag.java in myfaces-impl 1.2 by faces
> > > > plugin,
> > > > > > it is;
> > > > > >
> > > > > > @Override
> > > > > > public String getComponentType()
> > > > > > {
> > > > > > return "javax.faces.Column";
> > > > > > }
> > > > > >
> > > > > > Shouldn't it return " javax.faces.HtmlColumn "?
> > > > > >
> > > > > > Cagatay
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Matthias Wessendorf
> > >
> > > further stuff:
> > > blog: http://matthiaswessendorf.wordpress.com/
> > > sessions: http://www.slideshare.net/mwessendorf
> > > mail: matzew-at-apache-dot-org
> > >
> >
>
>
>
> --
>
> Matthias Wessendorf
>
> further stuff:
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> mail: matzew-at-apache-dot-org
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org
Re: HtmlColumn 1.2
Posted by Matthias Wessendorf <ma...@apache.org>.
+1 on that
On Dec 23, 2007 2:46 PM, Bruno Aranda <br...@gmail.com> wrote:
> True, then reverting the fix for the bug should solve everything and
> would allow us to release properly,
>
> Cheers,
>
> Bruno
>
>
> On 23/12/2007, Matthias Wessendorf <ma...@apache.org> wrote:
> > btw. javax.faces.HtmlColumn is correct for HtmlColumn
> >
> > see:
> > http://java.sun.com/javaee/javaserverfaces/1.2_MR1/docs/api/constant-values.html#javax.faces.component.html.HtmlColumn.COMPONENT_TYPE
> >
> >
> >
> > On Dec 23, 2007 1:14 PM, Cagatay Civici <ca...@gmail.com> wrote:
> > > Ok, I see.
> > >
> > > But the component-type for HtmlColumn in standart faces-config is still
> > > "javax.faces.HtmlColumn".
> > >
> > > I see this strange issue when using h:column and h:datatable;
> > >
> > > Caused by: java.lang.IllegalArgumentException : Component
> > > javax.faces.component.UIColumn is no HtmlColumn
> > > at
> > > org.apache.myfaces.taglib.html.HtmlColumnTag.setProperties(HtmlColumnTag.java:71)
> > >
> > >
> > >
> > > On Dec 23, 2007 3:09 AM, Bruno Aranda < brunoaranda@gmail.com> wrote:
> > > > Hi, see https://issues.apache.org/jira/browse/MYFACES-1790
> > > >
> > > > Acording to the release (section 4.1.1.1) the component type for
> > > > UIColumn is "javax.faces.Column", bug which was fixed last week, but
> > > > apparently fixing it has provoked some side effect. And the component
> > > > type in the xml should be that one (I don't understand why what you
> > > > describe happens though).
> > > >
> > > > Cheers,
> > > >
> > > > Bruno
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > On 23/12/2007, Cagatay Civici <ca...@gmail.com> wrote:
> > > > > Hi,
> > > > >
> > > > > I've noticed this weird thing in impl 1.2 build. In myfaces-build ->
> > > > > HtmlColumn.xml the component type is set as;
> > > > >
> > > > > <component-type>javax.faces.HtmlColumn</component-type>
> > > > >
> > > > > But in the generated HtmlColumnTag.java in myfaces-impl 1.2 by faces
> > > plugin,
> > > > > it is;
> > > > >
> > > > > @Override
> > > > > public String getComponentType()
> > > > > {
> > > > > return "javax.faces.Column";
> > > > > }
> > > > >
> > > > > Shouldn't it return " javax.faces.HtmlColumn "?
> > > > >
> > > > > Cagatay
> > > > >
> > > > >
> > > > >
> > > >
> > >
> > >
> >
> >
> >
> > --
> > Matthias Wessendorf
> >
> > further stuff:
> > blog: http://matthiaswessendorf.wordpress.com/
> > sessions: http://www.slideshare.net/mwessendorf
> > mail: matzew-at-apache-dot-org
> >
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org
Re: HtmlColumn 1.2
Posted by Bruno Aranda <br...@gmail.com>.
True, then reverting the fix for the bug should solve everything and
would allow us to release properly,
Cheers,
Bruno
On 23/12/2007, Matthias Wessendorf <ma...@apache.org> wrote:
> btw. javax.faces.HtmlColumn is correct for HtmlColumn
>
> see:
> http://java.sun.com/javaee/javaserverfaces/1.2_MR1/docs/api/constant-values.html#javax.faces.component.html.HtmlColumn.COMPONENT_TYPE
>
>
>
> On Dec 23, 2007 1:14 PM, Cagatay Civici <ca...@gmail.com> wrote:
> > Ok, I see.
> >
> > But the component-type for HtmlColumn in standart faces-config is still
> > "javax.faces.HtmlColumn".
> >
> > I see this strange issue when using h:column and h:datatable;
> >
> > Caused by: java.lang.IllegalArgumentException : Component
> > javax.faces.component.UIColumn is no HtmlColumn
> > at
> > org.apache.myfaces.taglib.html.HtmlColumnTag.setProperties(HtmlColumnTag.java:71)
> >
> >
> >
> > On Dec 23, 2007 3:09 AM, Bruno Aranda < brunoaranda@gmail.com> wrote:
> > > Hi, see https://issues.apache.org/jira/browse/MYFACES-1790
> > >
> > > Acording to the release (section 4.1.1.1) the component type for
> > > UIColumn is "javax.faces.Column", bug which was fixed last week, but
> > > apparently fixing it has provoked some side effect. And the component
> > > type in the xml should be that one (I don't understand why what you
> > > describe happens though).
> > >
> > > Cheers,
> > >
> > > Bruno
> > >
> > >
> > >
> > >
> > >
> > > On 23/12/2007, Cagatay Civici <ca...@gmail.com> wrote:
> > > > Hi,
> > > >
> > > > I've noticed this weird thing in impl 1.2 build. In myfaces-build ->
> > > > HtmlColumn.xml the component type is set as;
> > > >
> > > > <component-type>javax.faces.HtmlColumn</component-type>
> > > >
> > > > But in the generated HtmlColumnTag.java in myfaces-impl 1.2 by faces
> > plugin,
> > > > it is;
> > > >
> > > > @Override
> > > > public String getComponentType()
> > > > {
> > > > return "javax.faces.Column";
> > > > }
> > > >
> > > > Shouldn't it return " javax.faces.HtmlColumn "?
> > > >
> > > > Cagatay
> > > >
> > > >
> > > >
> > >
> >
> >
>
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> mail: matzew-at-apache-dot-org
>
Re: HtmlColumn 1.2
Posted by Matthias Wessendorf <ma...@apache.org>.
btw. javax.faces.HtmlColumn is correct for HtmlColumn
see:
http://java.sun.com/javaee/javaserverfaces/1.2_MR1/docs/api/constant-values.html#javax.faces.component.html.HtmlColumn.COMPONENT_TYPE
On Dec 23, 2007 1:14 PM, Cagatay Civici <ca...@gmail.com> wrote:
> Ok, I see.
>
> But the component-type for HtmlColumn in standart faces-config is still
> "javax.faces.HtmlColumn".
>
> I see this strange issue when using h:column and h:datatable;
>
> Caused by: java.lang.IllegalArgumentException : Component
> javax.faces.component.UIColumn is no HtmlColumn
> at
> org.apache.myfaces.taglib.html.HtmlColumnTag.setProperties(HtmlColumnTag.java:71)
>
>
>
> On Dec 23, 2007 3:09 AM, Bruno Aranda < brunoaranda@gmail.com> wrote:
> > Hi, see https://issues.apache.org/jira/browse/MYFACES-1790
> >
> > Acording to the release (section 4.1.1.1) the component type for
> > UIColumn is "javax.faces.Column", bug which was fixed last week, but
> > apparently fixing it has provoked some side effect. And the component
> > type in the xml should be that one (I don't understand why what you
> > describe happens though).
> >
> > Cheers,
> >
> > Bruno
> >
> >
> >
> >
> >
> > On 23/12/2007, Cagatay Civici <ca...@gmail.com> wrote:
> > > Hi,
> > >
> > > I've noticed this weird thing in impl 1.2 build. In myfaces-build ->
> > > HtmlColumn.xml the component type is set as;
> > >
> > > <component-type>javax.faces.HtmlColumn</component-type>
> > >
> > > But in the generated HtmlColumnTag.java in myfaces-impl 1.2 by faces
> plugin,
> > > it is;
> > >
> > > @Override
> > > public String getComponentType()
> > > {
> > > return "javax.faces.Column";
> > > }
> > >
> > > Shouldn't it return " javax.faces.HtmlColumn "?
> > >
> > > Cagatay
> > >
> > >
> > >
> >
>
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org
Re: HtmlColumn 1.2
Posted by Cagatay Civici <ca...@gmail.com>.
Ok, I see.
But the component-type for HtmlColumn in standart faces-config is still "
javax.faces.HtmlColumn".
I see this strange issue when using h:column and h:datatable;
Caused by: java.lang.IllegalArgumentException: Component
javax.faces.component.UIColumn is no HtmlColumn
at org.apache.myfaces.taglib.html.HtmlColumnTag.setProperties(
HtmlColumnTag.java:71)
On Dec 23, 2007 3:09 AM, Bruno Aranda <br...@gmail.com> wrote:
> Hi, see https://issues.apache.org/jira/browse/MYFACES-1790
>
> Acording to the release (section 4.1.1.1) the component type for
> UIColumn is "javax.faces.Column", bug which was fixed last week, but
> apparently fixing it has provoked some side effect. And the component
> type in the xml should be that one (I don't understand why what you
> describe happens though).
>
> Cheers,
>
> Bruno
>
>
> On 23/12/2007, Cagatay Civici <ca...@gmail.com> wrote:
> > Hi,
> >
> > I've noticed this weird thing in impl 1.2 build. In myfaces-build ->
> > HtmlColumn.xml the component type is set as;
> >
> > <component-type>javax.faces.HtmlColumn</component-type>
> >
> > But in the generated HtmlColumnTag.java in myfaces-impl 1.2 by faces
> plugin,
> > it is;
> >
> > @Override
> > public String getComponentType()
> > {
> > return "javax.faces.Column";
> > }
> >
> > Shouldn't it return "javax.faces.HtmlColumn "?
> >
> > Cagatay
> >
> >
> >
>
Re: HtmlColumn 1.2
Posted by Bruno Aranda <br...@gmail.com>.
Hi, see https://issues.apache.org/jira/browse/MYFACES-1790
Acording to the release (section 4.1.1.1) the component type for
UIColumn is "javax.faces.Column", bug which was fixed last week, but
apparently fixing it has provoked some side effect. And the component
type in the xml should be that one (I don't understand why what you
describe happens though).
Cheers,
Bruno
On 23/12/2007, Cagatay Civici <ca...@gmail.com> wrote:
> Hi,
>
> I've noticed this weird thing in impl 1.2 build. In myfaces-build ->
> HtmlColumn.xml the component type is set as;
>
> <component-type>javax.faces.HtmlColumn</component-type>
>
> But in the generated HtmlColumnTag.java in myfaces-impl 1.2 by faces plugin,
> it is;
>
> @Override
> public String getComponentType()
> {
> return "javax.faces.Column";
> }
>
> Shouldn't it return "javax.faces.HtmlColumn "?
>
> Cagatay
>
>
>