[GitHub] [superset] hughhhh commented on a diff in pull request #19855: feat(explore): Frontend implementation of dataset creation from infobox

[GitBox <gi...@apache.org>]

hughhhh commented on code in PR #19855:
URL: https://github.com/apache/superset/pull/19855#discussion_r860138295


##########
superset-frontend/src/explore/components/DatasourcePanel/index.tsx:
##########
@@ -26,6 +26,19 @@ import {
 import { debounce } from 'lodash';
 import { matchSorter, rankings } from 'match-sorter';
 import Collapse from 'src/components/Collapse';
+import Alert from 'src/components/Alert';
+import { SaveDatasetModal } from 'src/SqlLab/components/SaveDatasetModal';
+import { exploreChart } from 'src/explore/exploreUtils';
+import moment from 'moment';
+import rison from 'rison';
+import {
+  DatasetRadioState,
+  EXPLORE_CHART_DEFAULT,
+  DatasetOwner,
+  DatasetOptionAutocomplete,
+  updateDataset,
+} from 'src/SqlLab/components/ResultSet';

Review Comment:
   we should centralize this in a types file now instead of pulling it from `ResultSet`
   
   Can you move this to `superset/superset-frontend/src/SqlLab/types.ts` and import from there



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org