You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/11/14 23:14:49 UTC

Review Request 28054: Add wizard hangs adding hosts with NPE

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28054/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley and Tom Beerbower.


Bugs: AMBARI-8337
    https://issues.apache.org/jira/browse/AMBARI-8337


Repository: ambari


Description
-------

There is an edge case where the host status field creates an NPE.  Fix is to initialize the field to a value.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 619859c 

Diff: https://reviews.apache.org/r/28054/diff/


Testing
-------

No additional test created


Thanks,

Nate Cole


Re: Review Request 28054: Add wizard hangs adding hosts with NPE

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28054/#review61535
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Nov. 14, 2014, 10:16 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28054/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 10:16 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8337
>     https://issues.apache.org/jira/browse/AMBARI-8337
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There is an edge case where the host status field creates an NPE.  Fix is to initialize the field to a value.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 619859c 
> 
> Diff: https://reviews.apache.org/r/28054/diff/
> 
> 
> Testing
> -------
> 
> No additional test created
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:39.225s
> [INFO] Finished at: Fri Nov 14 17:16:30 EST 2014
> [INFO] Final Memory: 27M/226M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 28054: Add wizard hangs adding hosts with NPE

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28054/#review61540
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On Nov. 14, 2014, 10:16 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28054/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 10:16 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8337
>     https://issues.apache.org/jira/browse/AMBARI-8337
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There is an edge case where the host status field creates an NPE.  Fix is to initialize the field to a value.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 619859c 
> 
> Diff: https://reviews.apache.org/r/28054/diff/
> 
> 
> Testing
> -------
> 
> No additional test created
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:39.225s
> [INFO] Finished at: Fri Nov 14 17:16:30 EST 2014
> [INFO] Final Memory: 27M/226M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 28054: Add wizard hangs adding hosts with NPE

Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28054/#review61532
-----------------------------------------------------------

Ship it!


Ship It!

- Mahadev Konar


On Nov. 14, 2014, 10:16 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28054/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 10:16 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8337
>     https://issues.apache.org/jira/browse/AMBARI-8337
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There is an edge case where the host status field creates an NPE.  Fix is to initialize the field to a value.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 619859c 
> 
> Diff: https://reviews.apache.org/r/28054/diff/
> 
> 
> Testing
> -------
> 
> No additional test created
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:39.225s
> [INFO] Finished at: Fri Nov 14 17:16:30 EST 2014
> [INFO] Final Memory: 27M/226M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 28054: Add wizard hangs adding hosts with NPE

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28054/
-----------------------------------------------------------

(Updated Nov. 14, 2014, 5:16 p.m.)


Review request for Ambari, Jonathan Hurley and Tom Beerbower.


Bugs: AMBARI-8337
    https://issues.apache.org/jira/browse/AMBARI-8337


Repository: ambari


Description
-------

There is an edge case where the host status field creates an NPE.  Fix is to initialize the field to a value.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 619859c 

Diff: https://reviews.apache.org/r/28054/diff/


Testing (updated)
-------

No additional test created

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:39.225s
[INFO] Finished at: Fri Nov 14 17:16:30 EST 2014
[INFO] Final Memory: 27M/226M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole