You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/25 18:17:39 UTC

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9297: ARROW-11354: [Rust] Speed-up cast of dates and times (2-4x)

jorgecarleitao commented on a change in pull request #9297:
URL: https://github.com/apache/arrow/pull/9297#discussion_r563940743



##########
File path: rust/arrow/src/compute/kernels/mod.rs
##########
@@ -30,3 +30,4 @@ pub mod sort;
 pub mod substring;
 pub mod take;
 pub mod temporal;
+pub mod unary;

Review comment:
       Since this was only unary, I gave it that name. Note that we can lift all binary arithmetics into a generic like this one and place it there.
   
   I do not have strong feelings here, but it is the first time I hear about `arity` xD




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org