You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by ja...@apache.org on 2010/05/28 14:21:35 UTC

svn commit: r949159 - /myfaces/core/trunk/api/src/main/java/javax/faces/convert/EnumConverter.java

Author: jakobk
Date: Fri May 28 12:21:34 2010
New Revision: 949159

URL: http://svn.apache.org/viewvc?rev=949159&view=rev
Log:
MYFACES-2738 Use isInstance() instead of iterating through the enum constants in EnumConverter

Modified:
    myfaces/core/trunk/api/src/main/java/javax/faces/convert/EnumConverter.java

Modified: myfaces/core/trunk/api/src/main/java/javax/faces/convert/EnumConverter.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/convert/EnumConverter.java?rev=949159&r1=949158&r2=949159&view=diff
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/convert/EnumConverter.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/convert/EnumConverter.java Fri May 28 12:21:34 2010
@@ -68,12 +68,10 @@ public class EnumConverter implements Co
         if (value == null)
             return null;
 
-        for (Object enumConstant : targetClass.getEnumConstants())
+        // check if the value is an instance of the enum class
+        if (targetClass.isInstance(value))
         {
-            if (enumConstant == value)
-            {
-                return ((Enum<?>) enumConstant).name();
-            }
+            return ((Enum<?>) value).name();
         }
         
         Object[] params =