You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Thomas Mueller (JIRA)" <ji...@apache.org> on 2016/08/11 09:22:20 UTC

[jira] [Commented] (OAK-4665) ServiceEvent on each session login/logout, take 2

    [ https://issues.apache.org/jira/browse/OAK-4665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416937#comment-15416937 ] 

Thomas Mueller commented on OAK-4665:
-------------------------------------

I see now it _should_ not be an issue, because it should only be called for sessions that live longer than one minute: when logging in, sessions are not immediately registered. Instead, they are only registered after one minute, unless the session was closed:

{noformat}
RepositoryImpl.createSessionDelegate

    private SessionDelegate createSessionDelegate(
    ...
            // Defer session MBean registration to avoid cluttering the
            // JMX name space with short lived sessions
            RegistrationTask registrationTask = new RegistrationTask(getSessionStats(), whiteboard);
            ScheduledFuture<?> scheduledTask = scheduledExecutor.schedule(registrationTask, 1, TimeUnit.MINUTES);

            @Override
            public void logout() {
                refreshOnGC.close();
                // Cancel session MBean registration
                registrationTask.cancel();
                scheduledTask.cancel(false);
                super.logout();
            }
{noformat}


> ServiceEvent on each session login/logout, take 2
> -------------------------------------------------
>
>                 Key: OAK-4665
>                 URL: https://issues.apache.org/jira/browse/OAK-4665
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>            Reporter: Thomas Mueller
>
> In OAK-2576 we saw a GCMonitor is registered on login, which result in a lot of service events when there are many short-lived sessions.
> But even with OAK-2576, we still have a service event per session. Example stack trace:
> {noformat}
> 	- waiting to lock <0x00000004e0057678> (a org.apache.felix.eventadmin.impl.tasks.DefaultThreadPool)
> 	at org.apache.felix.eventadmin.impl.tasks.DefaultThreadPool.executeTask(DefaultThreadPool.java:101)
> 	at org.apache.felix.eventadmin.impl.tasks.AsyncDeliverTasks.execute(AsyncDeliverTasks.java:105)
> 	at org.apache.felix.eventadmin.impl.handler.EventAdminImpl.postEvent(EventAdminImpl.java:100)
> 	at org.apache.felix.eventadmin.impl.adapter.ServiceEventAdapter.serviceChanged(ServiceEventAdapter.java:137)
> 	at org.apache.felix.framework.util.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:987)
> 	at org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
> 	at org.apache.felix.framework.util.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
> 	at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4560)
> 	at org.apache.felix.framework.Felix.access$000(Felix.java:106)
> 	at org.apache.felix.framework.Felix$1.serviceChanged(Felix.java:419)
> 	at org.apache.felix.framework.ServiceRegistry.unregisterService(ServiceRegistry.java:171)
> 	at org.apache.felix.framework.ServiceRegistrationImpl.unregister(ServiceRegistrationImpl.java:144)
> 	at org.apache.jackrabbit.oak.osgi.OsgiWhiteboard$1.unregister(OsgiWhiteboard.java:81)
> 	at org.apache.jackrabbit.oak.jcr.repository.RepositoryImpl$RegistrationTask.cancel(RepositoryImpl.java:498)
> 	- locked <0x0000000520e13120> (a org.apache.jackrabbit.oak.jcr.repository.RepositoryImpl$RegistrationTask)
> 	at org.apache.jackrabbit.oak.jcr.repository.RepositoryImpl$1.logout(RepositoryImpl.java:292)
> 	at org.apache.jackrabbit.oak.jcr.session.SessionImpl$10.performVoid(SessionImpl.java:452)
> 	at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.performVoid(SessionDelegate.java:266)
> 	at org.apache.jackrabbit.oak.jcr.session.SessionImpl.logout(SessionImpl.java:448)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)