You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "maskit (via GitHub)" <gi...@apache.org> on 2025/10/09 16:03:03 UTC
[PR] realip: Add null check for netvc [trafficserver]
maskit opened a new pull request, #12554:
URL: https://github.com/apache/trafficserver/pull/12554
Apparently, client netvc is not always available on `READ_REQUEST_HDR_HOOK`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] realip: Add null check for netvc [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on PR #12554:
URL: https://github.com/apache/trafficserver/pull/12554#issuecomment-3399214915
I would like to see the implementation being safer by doing null check on the input arguments and return TS_ERROR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] realip: Add null check for netvc [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #12554:
URL: https://github.com/apache/trafficserver/pull/12554#issuecomment-3402372037
> Looks fine, approving as is. But would a debug log for the else case be helpful potentially?
There's a debug log on the caller side, and that works for all address sources.
> I would like to see the implementation being safer by doing null check on the input arguments and return TS_ERROR.
I do not think that is a good idea. If we took that way, null check would be done again and again by all functions that receive vconn on every call. So redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] realip: Add null check for netvc [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit merged PR #12554:
URL: https://github.com/apache/trafficserver/pull/12554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org