You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/01/12 05:13:15 UTC
[GitHub] [hudi] satishkotha opened a new pull request #4570: [HUDI-3058] Simplify Precommit file system view
satishkotha opened a new pull request #4570:
URL: https://github.com/apache/hudi/pull/4570
## What is the purpose of the pull request
Simplify building precommit file system view.
## Brief change log
Avoid mutating list and only use immutable stream API to build precommit file system view. This helps avoid ConcurrentModificationException that happens occasionally (HUDI-3058)
## Verify this pull request
Minor refactoring. Existing tests in TestHoodieClientOnCopyOnWriteStorage cover functional correctness.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan edited a comment on pull request #4570: [HUDI-3058] Simplify Precommit file system view
Posted by GitBox <gi...@apache.org>.
nsivabalan edited a comment on pull request #4570:
URL: https://github.com/apache/hudi/pull/4570#issuecomment-1018028755
@bhasudha : let me know if the patch works for you. have assigned the PR to you. feel free to review and land as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4570: [HUDI-3058] Simplify Precommit file system view
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4570:
URL: https://github.com/apache/hudi/pull/4570#issuecomment-1010646023
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5ba7c21ea02d72999ef3d62e8b53a1ff3c0448aa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5132",
"triggerID" : "5ba7c21ea02d72999ef3d62e8b53a1ff3c0448aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5ba7c21ea02d72999ef3d62e8b53a1ff3c0448aa Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5132)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #4570: [HUDI-3058] Simplify Precommit file system view
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4570:
URL: https://github.com/apache/hudi/pull/4570#issuecomment-1018028755
@bhasudha : let me know if the patch works for you and we can land.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4570: [HUDI-3058] Simplify Precommit file system view
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4570:
URL: https://github.com/apache/hudi/pull/4570#issuecomment-1010708772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5ba7c21ea02d72999ef3d62e8b53a1ff3c0448aa",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5132",
"triggerID" : "5ba7c21ea02d72999ef3d62e8b53a1ff3c0448aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5ba7c21ea02d72999ef3d62e8b53a1ff3c0448aa Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5132)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #4570: [HUDI-3058] Simplify Precommit file system view
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4570:
URL: https://github.com/apache/hudi/pull/4570#issuecomment-1014921992
@satishkotha :
https://issues.apache.org/jira/browse/HUDI-3058 I see some steps given here to try out w/ quick start.
Can you confirm the issue reported is fixed with this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] satishkotha commented on pull request #4570: [HUDI-3058] Simplify Precommit file system view
Posted by GitBox <gi...@apache.org>.
satishkotha commented on pull request #4570:
URL: https://github.com/apache/hudi/pull/4570#issuecomment-1016015774
> @satishkotha :
> https://issues.apache.org/jira/browse/HUDI-3058 I see some steps given here to try out w/ quick start.
> Can you confirm the issue reported is fixed with this patch?
The issue never happened in my environment (Never seen at Uber production environment). I'm basing this fix completely on stack trace. I've also asked @bhasudha on slack to verify since she was able to consistently get this error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4570: [HUDI-3058] Simplify Precommit file system view
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4570:
URL: https://github.com/apache/hudi/pull/4570#issuecomment-1010644375
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5ba7c21ea02d72999ef3d62e8b53a1ff3c0448aa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5ba7c21ea02d72999ef3d62e8b53a1ff3c0448aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5ba7c21ea02d72999ef3d62e8b53a1ff3c0448aa UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bhasudha commented on pull request #4570: [HUDI-3058] Simplify Precommit file system view
Posted by GitBox <gi...@apache.org>.
bhasudha commented on pull request #4570:
URL: https://github.com/apache/hudi/pull/4570#issuecomment-1031879192
> @bhasudha : let me know if the patch works for you. have assigned the PR to you. feel free to review and land as well
I tested by reproducing the same steps I did before and the patch is working fine. I ll review and land it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bhasudha merged pull request #4570: [HUDI-3058] Simplify Precommit file system view
Posted by GitBox <gi...@apache.org>.
bhasudha merged pull request #4570:
URL: https://github.com/apache/hudi/pull/4570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4570: [HUDI-3058] Simplify Precommit file system view
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4570:
URL: https://github.com/apache/hudi/pull/4570#issuecomment-1010646023
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5ba7c21ea02d72999ef3d62e8b53a1ff3c0448aa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5132",
"triggerID" : "5ba7c21ea02d72999ef3d62e8b53a1ff3c0448aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5ba7c21ea02d72999ef3d62e8b53a1ff3c0448aa Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5132)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4570: [HUDI-3058] Simplify Precommit file system view
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4570:
URL: https://github.com/apache/hudi/pull/4570#issuecomment-1010644375
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5ba7c21ea02d72999ef3d62e8b53a1ff3c0448aa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5ba7c21ea02d72999ef3d62e8b53a1ff3c0448aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5ba7c21ea02d72999ef3d62e8b53a1ff3c0448aa UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] satishkotha edited a comment on pull request #4570: [HUDI-3058] Simplify Precommit file system view
Posted by GitBox <gi...@apache.org>.
satishkotha edited a comment on pull request #4570:
URL: https://github.com/apache/hudi/pull/4570#issuecomment-1016015774
> @satishkotha :
> https://issues.apache.org/jira/browse/HUDI-3058 I see some steps given here to try out w/ quick start.
> Can you confirm the issue reported is fixed with this patch?
The issue never happened in my environment (Never seen at Uber production environment also). I'm basing this fix completely on stack trace. I've also asked @bhasudha on slack to verify since she was able to consistently get this error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org