You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/11 08:37:28 UTC

[GitHub] [iotdb] zhanglingzhe0820 opened a new pull request #2811: Fix compaction with cluster snapshot deletion

zhanglingzhe0820 opened a new pull request #2811:
URL: https://github.com/apache/iotdb/pull/2811


   ## Behavior
   Compaction run with cluster snapshot together and meet error.
   
   ## Reason
   If run as below:
   (1) Start compaction task;
   (2) Cluster pull snapshot;
   (3) The snapshot pulled is fully overlapped with some merging local file and delete them.
   (4) The compaction cannot find the file to be read and exit.
   The temp file will not be deleted.
   
   ## Solution
   1、Add restore logic when meet exception.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] jt2594838 commented on a change in pull request #2811: Fix compaction with cluster snapshot deletion

Posted by GitBox <gi...@apache.org>.
jt2594838 commented on a change in pull request #2811:
URL: https://github.com/apache/iotdb/pull/2811#discussion_r592851115



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/utils/CompactionUtils.java
##########
@@ -271,6 +271,9 @@ public static void merge(
       for (TsFileResource tsFileResource : tsFileResources) {
         TsFileSequenceReader reader =
             buildReaderFromTsFileResource(tsFileResource, tsFileSequenceReaderMap, storageGroup);
+        if (reader == null) {
+          throw new IOException();

Review comment:
       Add some message in this exception.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] zhanglingzhe0820 commented on a change in pull request #2811: Fix compaction with cluster snapshot deletion

Posted by GitBox <gi...@apache.org>.
zhanglingzhe0820 commented on a change in pull request #2811:
URL: https://github.com/apache/iotdb/pull/2811#discussion_r592852562



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/utils/CompactionUtils.java
##########
@@ -271,6 +271,9 @@ public static void merge(
       for (TsFileResource tsFileResource : tsFileResources) {
         TsFileSequenceReader reader =
             buildReaderFromTsFileResource(tsFileResource, tsFileSequenceReaderMap, storageGroup);
+        if (reader == null) {
+          throw new IOException();

Review comment:
       okay




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] jt2594838 commented on pull request #2811: Fix compaction with cluster snapshot deletion

Posted by GitBox <gi...@apache.org>.
jt2594838 commented on pull request #2811:
URL: https://github.com/apache/iotdb/pull/2811#issuecomment-797173642


   There is a failed test, please look into it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] jt2594838 merged pull request #2811: Fix compaction with cluster snapshot deletion

Posted by GitBox <gi...@apache.org>.
jt2594838 merged pull request #2811:
URL: https://github.com/apache/iotdb/pull/2811


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] zhanglingzhe0820 commented on pull request #2811: Fix compaction with cluster snapshot deletion

Posted by GitBox <gi...@apache.org>.
zhanglingzhe0820 commented on pull request #2811:
URL: https://github.com/apache/iotdb/pull/2811#issuecomment-797174426


   > There is a failed test, please look into it.
   
   This test has nothing to do with this pr.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org