[GitHub] [storm] agresch commented on a change in pull request #3419: STORM-3802 allow adding system metrics reporters to all topologies

[GitBox <gi...@apache.org>]

agresch commented on a change in pull request #3419:
URL: https://github.com/apache/storm/pull/3419#discussion_r734634038



##########
File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -1152,6 +1152,15 @@ private static void addToSerializers(Map<String, String> ser, List<Object> conf)
             ret.put(Config.TOPOLOGY_METRICS_REPORTERS, mergedConf.get(Config.STORM_METRICS_REPORTERS));
         }
 
+        // add any system metrics reporters to the topology metrics reporters
+        if (conf.containsKey(Config.STORM_TOPOLOGY_METRICS_SYSTEM_REPORTERS)) {
+            List<Map<String, Object>> reporters = (List<Map<String, Object>>)
+                    ret.computeIfAbsent(Config.TOPOLOGY_METRICS_REPORTERS, (key) -> new ArrayList<>());
+            List<Map<String, Object>> systemReporters = (List<Map<String, Object>>)
+                    conf.get(Config.STORM_TOPOLOGY_METRICS_SYSTEM_REPORTERS);

Review comment:
       STORM_TOPOLOGY_METRICS_SYSTEM_REPORTERS was already verified as existing on line 1155.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org