You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/07/10 15:23:13 UTC

[GitHub] [couchdb] iilyak opened a new pull request #2993: Do not fail when emilio detects errors

iilyak opened a new pull request #2993:
URL: https://github.com/apache/couchdb/pull/2993


   ## Overview
   
   Adding emilio check into Makefile was a mistake. Without automatic linter it is almost impossible to fix the style. Also emilio doesn’t allow disabling the checks. The idea was that by checking only warnings around (+-3 lines) modified lines we could gradually update the style as we go. However by updating these extra lines we trigger even more warnings and you end up changing style for the whole module. Things like “402 - import declaration found” is especially hard to fix.
   
   ## Testing recommendations
   
   1. Change style for one of the erlang source files
   2. Run tests `make check` - the execution output should pass the point where emilio warnings are displayed
   
   ## Related Issues or Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] iilyak merged pull request #2993: Do not fail when emilio detects errors

Posted by GitBox <gi...@apache.org>.
iilyak merged pull request #2993:
URL: https://github.com/apache/couchdb/pull/2993


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org