[jira] [Commented] (ZOOKEEPER-1797) PurgeTxnLog may delete data logs during roll

["Rakesh R (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988628#comment-13988628 ] 

Rakesh R commented on ZOOKEEPER-1797:
-------------------------------------

Thank you [~bhavanki] for the reviews. Attaching new patch addressing the comments given in review board.

> PurgeTxnLog may delete data logs during roll
> --------------------------------------------
>
>                 Key: ZOOKEEPER-1797
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1797
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.5
>            Reporter: Derek Dagit
>            Assignee: Rakesh R
>            Priority: Blocker
>             Fix For: 3.4.7, 3.5.0
>
>         Attachments: ZOOKEEPER-1797.patch, ZOOKEEPER-1797.patch, ZOOKEEPER-1797.patch, ZOOKEEPER-1797.patch
>
>
> org.apache.zookeeper.server.PurgeTxnLog deletes old data logs and snapshots, keeping the newest N snapshots and any data logs that have been written since the snapshot.
> It does this by listing the available snapshots & logs and creates a blacklist of snapshots and logs that should not be deleted.  Then, it searches for and deletes all logs and snapshots that are not in this list.
> It appears that if logs are rolling or a new snapshot is created during this process, then these newer files will be unintentionally deleted.



--
This message was sent by Atlassian JIRA
(v6.2#6252)