You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/11/06 15:07:16 UTC
[GitHub] [nifi] mattyb149 commented on a change in pull request #3789:
NIFI-6740: Add configuration options to specify NiFi/Bootstrap
communication ports
mattyb149 commented on a change in pull request #3789: NIFI-6740: Add configuration options to specify NiFi/Bootstrap communication ports
URL: https://github.com/apache/nifi/pull/3789#discussion_r343146737
##########
File path: nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java
##########
@@ -81,6 +81,7 @@
public static final String PROCESSOR_SCHEDULING_TIMEOUT = "nifi.processor.scheduling.timeout";
public static final String BACKPRESSURE_COUNT = "nifi.queue.backpressure.count";
public static final String BACKPRESSURE_SIZE = "nifi.queue.backpressure.size";
+ public static final String COMMANDCONTROL_LISTEN_PORT = "nifi.commandcontrol.listen.port";
Review comment:
Command & Control already has a different meaning in the NiFi ecosystem context: https://cwiki.apache.org/confluence/display/MINIFI/C2+Design
In the code we already refer to it as a "bootstrap listener", so maybe `nifi.bootstrap.port` and `nifi.bootstrap.listener.port` are better names for the properties?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services