[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #891: [#417] refactor: Eliminate raw use of parameterized class

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on code in PR #891:
URL: https://github.com/apache/incubator-uniffle/pull/891#discussion_r1206282271


##########
coordinator/src/main/java/org/apache/uniffle/coordinator/web/servlet/BaseServlet.java:
##########
@@ -44,9 +44,9 @@ protected void doPost(HttpServletRequest req, HttpServletResponse resp) throws I
     writeJSON(resp, handlerRequest(() -> handlePost(req, resp)));
   }
 
-  private Response handlerRequest(
-      Callable<Response> function) {
-    Response response;
+  private <T> Response<T> handlerRequest(

Review Comment:
   >  I am open to whether make BaseServlet a generic class or not. Willing to do the change if we have a conclusion.
   
   Let's make it a generic class first, then we could replace it with jersey



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org