You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by jp...@apache.org on 2014/08/03 19:29:15 UTC

git commit: Remove unused SessionAccept::createNetAccept()

Repository: trafficserver
Updated Branches:
  refs/heads/master 97761c4bc -> fab202517


Remove unused SessionAccept::createNetAccept()


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/fab20251
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/fab20251
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/fab20251

Branch: refs/heads/master
Commit: fab2025175d073bbdeeae491ee4547f5c0e8ced6
Parents: 97761c4
Author: James Peach <jp...@apache.org>
Authored: Sun Aug 3 10:19:38 2014 -0700
Committer: James Peach <jp...@apache.org>
Committed: Sun Aug 3 10:19:38 2014 -0700

----------------------------------------------------------------------
 iocore/net/I_SessionAccept.h | 16 ++++++---------
 iocore/net/Makefile.am       |  1 -
 iocore/net/SessionAccept.cc  | 41 ---------------------------------------
 3 files changed, 6 insertions(+), 52 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/fab20251/iocore/net/I_SessionAccept.h
----------------------------------------------------------------------
diff --git a/iocore/net/I_SessionAccept.h b/iocore/net/I_SessionAccept.h
index e6e3b4d..9ac9e2b 100644
--- a/iocore/net/I_SessionAccept.h
+++ b/iocore/net/I_SessionAccept.h
@@ -30,18 +30,14 @@
 class SessionAccept: public Continuation
 {
 public:
-  SessionAccept(ProxyMutex *amutex);
-  ~SessionAccept();
+  SessionAccept(ProxyMutex *amutex) : Continuation(amutex) {
+    SET_HANDLER(&SessionAccept::mainEvent);
+  }
 
-  virtual void accept(NetVConnection *, MIOBuffer *, IOBufferReader *) = 0;
+  ~SessionAccept() {
+  }
 
-  // Virtual function allows creation of an SSLNetAccept
-  // or NetAccept transparent to NetProcessor.
-  //
-  // This function should return a pointer
-  // of NetAccept or its subclass.
-  //
-  virtual void *createNetAccept();
+  virtual void accept(NetVConnection *, MIOBuffer *, IOBufferReader *) = 0;
 
 private:
   virtual int mainEvent(int event, void * netvc) = 0;

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/fab20251/iocore/net/Makefile.am
----------------------------------------------------------------------
diff --git a/iocore/net/Makefile.am b/iocore/net/Makefile.am
index cfbdb4b..907be2e 100644
--- a/iocore/net/Makefile.am
+++ b/iocore/net/Makefile.am
@@ -53,7 +53,6 @@ libinknet_a_SOURCES = \
   I_UDPPacket.h \
   Inline.cc \
   I_SessionAccept.h \
-  SessionAccept.cc \
   Net.cc \
   NetVConnection.cc \
   P_CompletionUtil.h \

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/fab20251/iocore/net/SessionAccept.cc
----------------------------------------------------------------------
diff --git a/iocore/net/SessionAccept.cc b/iocore/net/SessionAccept.cc
deleted file mode 100644
index 138501e..0000000
--- a/iocore/net/SessionAccept.cc
+++ /dev/null
@@ -1,41 +0,0 @@
-/** @file
-
-  SessionAccept
-
-  @section license License
-
-  Licensed to the Apache Software Foundation (ASF) under one
-  or more contributor license agreements.  See the NOTICE file
-  distributed with this work for additional information
-  regarding copyright ownership.  The ASF licenses this file
-  to you under the Apache License, Version 2.0 (the
-  "License"); you may not use this file except in compliance
-  with the License.  You may obtain a copy of the License at
-
-      http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing, software
-  distributed under the License is distributed on an "AS IS" BASIS,
-  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  See the License for the specific language governing permissions and
-  limitations under the License.
- */
-
-#include "I_SessionAccept.h"
-#include "P_Net.h"
-
-SessionAccept::SessionAccept(ProxyMutex *amutex)
-  : Continuation(amutex)
-{
-  SET_HANDLER(&SessionAccept::mainEvent);
-}
-
-SessionAccept::~SessionAccept()
-{
-}
-
-void *
-SessionAccept::createNetAccept()
-{
-  return new NetAccept;
-}