You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ray Chen (JIRA)" <ji...@apache.org> on 2009/12/23 07:03:29 UTC
[jira] Created: (HARMONY-6413) [java6][classlib][luni]DatagramSock
do NOT throw IllegalArgumentException
[java6][classlib][luni]DatagramSock do NOT throw IllegalArgumentException
-------------------------------------------------------------------------
Key: HARMONY-6413
URL: https://issues.apache.org/jira/browse/HARMONY-6413
Project: Harmony
Issue Type: Sub-task
Components: Classlib
Reporter: Ray Chen
Run following simple test case, got different results from RI:
public static void main(String[] args) throws SocketException, IOException {
InetSocketAddress sa = InetSocketAddress.createUnresolved("localhost",0);
new DatagramSocket().send(new DatagramPacket(new byte[272], 3, sa));
}
RI 6:
Exception in thread "main" java.lang.IllegalArgumentException: unresolved address
at java.net.DatagramPacket.setSocketAddress(DatagramPacket.java:295)
at java.net.DatagramPacket.<init>(DatagramPacket.java:123)
at java.net.DatagramPacket.<init>(DatagramPacket.java:158)
at DST2.main(DST2.java:10)
Harmony 6: No Exception
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-6413) [java6][classlib][luni]DatagramSock
do NOT throw IllegalArgumentException
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Regis Xu reassigned HARMONY-6413:
---------------------------------
Assignee: Regis Xu
> [java6][classlib][luni]DatagramSock do NOT throw IllegalArgumentException
> -------------------------------------------------------------------------
>
> Key: HARMONY-6413
> URL: https://issues.apache.org/jira/browse/HARMONY-6413
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ray Chen
> Assignee: Regis Xu
> Fix For: 6.0M1
>
> Attachments: Harmony-6413.diff, Harmony-6413_v2.diff, Harmony-6413_v3.diff
>
>
> Run following simple test case, got different results from RI:
> public static void main(String[] args) throws SocketException, IOException {
> InetSocketAddress sa = InetSocketAddress.createUnresolved("localhost",0);
> new DatagramSocket().send(new DatagramPacket(new byte[272], 3, sa));
> }
> RI 6:
> Exception in thread "main" java.lang.IllegalArgumentException: unresolved address
> at java.net.DatagramPacket.setSocketAddress(DatagramPacket.java:295)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:123)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:158)
> at DST2.main(DST2.java:10)
> Harmony 6: No Exception
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6413) [java6][classlib][luni]DatagramSock
do NOT throw IllegalArgumentException
Posted by "Ray Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ray Chen updated HARMONY-6413:
------------------------------
Attachment: Harmony-6413.diff
This patch will make harmony's behavior same as RI's.
Just one more thing, I notice that there are two places in luni module to store messages:
[1]org/apache/harmony/luni/internalnls/messages.properties
[2]org/apache/harmony/luni/util/ExternalMessages.properties
Can anybody tell what is the difference between them?
Is there any rule I can follow to put the message in the right place?
> [java6][classlib][luni]DatagramSock do NOT throw IllegalArgumentException
> -------------------------------------------------------------------------
>
> Key: HARMONY-6413
> URL: https://issues.apache.org/jira/browse/HARMONY-6413
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ray Chen
> Attachments: Harmony-6413.diff
>
>
> Run following simple test case, got different results from RI:
> public static void main(String[] args) throws SocketException, IOException {
> InetSocketAddress sa = InetSocketAddress.createUnresolved("localhost",0);
> new DatagramSocket().send(new DatagramPacket(new byte[272], 3, sa));
> }
> RI 6:
> Exception in thread "main" java.lang.IllegalArgumentException: unresolved address
> at java.net.DatagramPacket.setSocketAddress(DatagramPacket.java:295)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:123)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:158)
> at DST2.main(DST2.java:10)
> Harmony 6: No Exception
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6413)
[java6][classlib][luni]DatagramSock do NOT throw IllegalArgumentException
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830868#action_12830868 ]
Hudson commented on HARMONY-6413:
---------------------------------
Integrated in Harmony-1.5-head-linux-x86_64 #611 (See [http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/611/])
Apply patch for : [java6][classlib][luni]DatagramSock do NOT throw IllegalArgumentException
Agreed with Ray, this patch could be also applied to Java5.
> [java6][classlib][luni]DatagramSock do NOT throw IllegalArgumentException
> -------------------------------------------------------------------------
>
> Key: HARMONY-6413
> URL: https://issues.apache.org/jira/browse/HARMONY-6413
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ray Chen
> Assignee: Regis Xu
> Fix For: 5.0M13
>
> Attachments: Harmony-6413.diff, Harmony-6413_v2.diff, Harmony-6413_v3.diff
>
>
> Run following simple test case, got different results from RI:
> public static void main(String[] args) throws SocketException, IOException {
> InetSocketAddress sa = InetSocketAddress.createUnresolved("localhost",0);
> new DatagramSocket().send(new DatagramPacket(new byte[272], 3, sa));
> }
> RI 6:
> Exception in thread "main" java.lang.IllegalArgumentException: unresolved address
> at java.net.DatagramPacket.setSocketAddress(DatagramPacket.java:295)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:123)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:158)
> at DST2.main(DST2.java:10)
> Harmony 6: No Exception
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6413) [java6][classlib][luni]DatagramSock
do NOT throw IllegalArgumentException
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Regis Xu updated HARMONY-6413:
------------------------------
Fix Version/s: (was: 6.0M1)
5.0M13
> [java6][classlib][luni]DatagramSock do NOT throw IllegalArgumentException
> -------------------------------------------------------------------------
>
> Key: HARMONY-6413
> URL: https://issues.apache.org/jira/browse/HARMONY-6413
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ray Chen
> Assignee: Regis Xu
> Fix For: 5.0M13
>
> Attachments: Harmony-6413.diff, Harmony-6413_v2.diff, Harmony-6413_v3.diff
>
>
> Run following simple test case, got different results from RI:
> public static void main(String[] args) throws SocketException, IOException {
> InetSocketAddress sa = InetSocketAddress.createUnresolved("localhost",0);
> new DatagramSocket().send(new DatagramPacket(new byte[272], 3, sa));
> }
> RI 6:
> Exception in thread "main" java.lang.IllegalArgumentException: unresolved address
> at java.net.DatagramPacket.setSocketAddress(DatagramPacket.java:295)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:123)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:158)
> at DST2.main(DST2.java:10)
> Harmony 6: No Exception
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6413) [java6][classlib][luni]DatagramSock
do NOT throw IllegalArgumentException
Posted by "Ray Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ray Chen updated HARMONY-6413:
------------------------------
Patch Info: [Patch Available]
> [java6][classlib][luni]DatagramSock do NOT throw IllegalArgumentException
> -------------------------------------------------------------------------
>
> Key: HARMONY-6413
> URL: https://issues.apache.org/jira/browse/HARMONY-6413
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ray Chen
> Attachments: Harmony-6413.diff
>
>
> Run following simple test case, got different results from RI:
> public static void main(String[] args) throws SocketException, IOException {
> InetSocketAddress sa = InetSocketAddress.createUnresolved("localhost",0);
> new DatagramSocket().send(new DatagramPacket(new byte[272], 3, sa));
> }
> RI 6:
> Exception in thread "main" java.lang.IllegalArgumentException: unresolved address
> at java.net.DatagramPacket.setSocketAddress(DatagramPacket.java:295)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:123)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:158)
> at DST2.main(DST2.java:10)
> Harmony 6: No Exception
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6413)
[java6][classlib][luni]DatagramSock do NOT throw IllegalArgumentException
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830857#action_12830857 ]
Regis Xu commented on HARMONY-6413:
-----------------------------------
As discussion in HARMONY-6412, I'll apply Harmony-6413_v3.diff to java5 trunk.
> [java6][classlib][luni]DatagramSock do NOT throw IllegalArgumentException
> -------------------------------------------------------------------------
>
> Key: HARMONY-6413
> URL: https://issues.apache.org/jira/browse/HARMONY-6413
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ray Chen
> Assignee: Regis Xu
> Fix For: 6.0M1
>
> Attachments: Harmony-6413.diff, Harmony-6413_v2.diff, Harmony-6413_v3.diff
>
>
> Run following simple test case, got different results from RI:
> public static void main(String[] args) throws SocketException, IOException {
> InetSocketAddress sa = InetSocketAddress.createUnresolved("localhost",0);
> new DatagramSocket().send(new DatagramPacket(new byte[272], 3, sa));
> }
> RI 6:
> Exception in thread "main" java.lang.IllegalArgumentException: unresolved address
> at java.net.DatagramPacket.setSocketAddress(DatagramPacket.java:295)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:123)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:158)
> at DST2.main(DST2.java:10)
> Harmony 6: No Exception
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6413) [java6][classlib][luni]DatagramSock
do NOT throw IllegalArgumentException
Posted by "Ray Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ray Chen updated HARMONY-6413:
------------------------------
Fix Version/s: 6.0M1
Set the affect version to 6.0 M1
> [java6][classlib][luni]DatagramSock do NOT throw IllegalArgumentException
> -------------------------------------------------------------------------
>
> Key: HARMONY-6413
> URL: https://issues.apache.org/jira/browse/HARMONY-6413
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ray Chen
> Fix For: 6.0M1
>
> Attachments: Harmony-6413.diff, Harmony-6413_v2.diff, Harmony-6413_v3.diff
>
>
> Run following simple test case, got different results from RI:
> public static void main(String[] args) throws SocketException, IOException {
> InetSocketAddress sa = InetSocketAddress.createUnresolved("localhost",0);
> new DatagramSocket().send(new DatagramPacket(new byte[272], 3, sa));
> }
> RI 6:
> Exception in thread "main" java.lang.IllegalArgumentException: unresolved address
> at java.net.DatagramPacket.setSocketAddress(DatagramPacket.java:295)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:123)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:158)
> at DST2.main(DST2.java:10)
> Harmony 6: No Exception
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-6413) [java6][classlib][luni]DatagramSock
do NOT throw IllegalArgumentException
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Regis Xu resolved HARMONY-6413.
-------------------------------
Resolution: Fixed
Thanks Ray, patch was applied at java5 trunk r907563, please verify.
> [java6][classlib][luni]DatagramSock do NOT throw IllegalArgumentException
> -------------------------------------------------------------------------
>
> Key: HARMONY-6413
> URL: https://issues.apache.org/jira/browse/HARMONY-6413
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ray Chen
> Assignee: Regis Xu
> Fix For: 6.0M1
>
> Attachments: Harmony-6413.diff, Harmony-6413_v2.diff, Harmony-6413_v3.diff
>
>
> Run following simple test case, got different results from RI:
> public static void main(String[] args) throws SocketException, IOException {
> InetSocketAddress sa = InetSocketAddress.createUnresolved("localhost",0);
> new DatagramSocket().send(new DatagramPacket(new byte[272], 3, sa));
> }
> RI 6:
> Exception in thread "main" java.lang.IllegalArgumentException: unresolved address
> at java.net.DatagramPacket.setSocketAddress(DatagramPacket.java:295)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:123)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:158)
> at DST2.main(DST2.java:10)
> Harmony 6: No Exception
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-6413) [java6][classlib][luni]DatagramSock
do NOT throw IllegalArgumentException
Posted by "Ray Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ray Chen closed HARMONY-6413.
-----------------------------
Patch verified.
Thanks Regis
> [java6][classlib][luni]DatagramSock do NOT throw IllegalArgumentException
> -------------------------------------------------------------------------
>
> Key: HARMONY-6413
> URL: https://issues.apache.org/jira/browse/HARMONY-6413
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ray Chen
> Assignee: Regis Xu
> Fix For: 5.0M13
>
> Attachments: Harmony-6413.diff, Harmony-6413_v2.diff, Harmony-6413_v3.diff
>
>
> Run following simple test case, got different results from RI:
> public static void main(String[] args) throws SocketException, IOException {
> InetSocketAddress sa = InetSocketAddress.createUnresolved("localhost",0);
> new DatagramSocket().send(new DatagramPacket(new byte[272], 3, sa));
> }
> RI 6:
> Exception in thread "main" java.lang.IllegalArgumentException: unresolved address
> at java.net.DatagramPacket.setSocketAddress(DatagramPacket.java:295)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:123)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:158)
> at DST2.main(DST2.java:10)
> Harmony 6: No Exception
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6413) [java6][classlib][luni]DatagramSock
do NOT throw IllegalArgumentException
Posted by "Ray Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ray Chen updated HARMONY-6413:
------------------------------
Attachment: Harmony-6413_v2.diff
Patch version 2 fixed the bug in the test, also added one test for this issue.
Test passed on RI version:
java version "1.6.0_14"
Java(TM) SE Runtime Environment (build 1.6.0_14-b08)
Java HotSpot(TM) Client VM (build 14.0-b16, mixed mode, sharing)
> [java6][classlib][luni]DatagramSock do NOT throw IllegalArgumentException
> -------------------------------------------------------------------------
>
> Key: HARMONY-6413
> URL: https://issues.apache.org/jira/browse/HARMONY-6413
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ray Chen
> Attachments: Harmony-6413.diff, Harmony-6413_v2.diff
>
>
> Run following simple test case, got different results from RI:
> public static void main(String[] args) throws SocketException, IOException {
> InetSocketAddress sa = InetSocketAddress.createUnresolved("localhost",0);
> new DatagramSocket().send(new DatagramPacket(new byte[272], 3, sa));
> }
> RI 6:
> Exception in thread "main" java.lang.IllegalArgumentException: unresolved address
> at java.net.DatagramPacket.setSocketAddress(DatagramPacket.java:295)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:123)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:158)
> at DST2.main(DST2.java:10)
> Harmony 6: No Exception
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6413) [java6][classlib][luni]DatagramSock
do NOT throw IllegalArgumentException
Posted by "Ray Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ray Chen updated HARMONY-6413:
------------------------------
Attachment: Harmony-6413_v3.diff
Move the added test case to DatagramPacketTest, which is more reasonable.
> [java6][classlib][luni]DatagramSock do NOT throw IllegalArgumentException
> -------------------------------------------------------------------------
>
> Key: HARMONY-6413
> URL: https://issues.apache.org/jira/browse/HARMONY-6413
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ray Chen
> Attachments: Harmony-6413.diff, Harmony-6413_v2.diff, Harmony-6413_v3.diff
>
>
> Run following simple test case, got different results from RI:
> public static void main(String[] args) throws SocketException, IOException {
> InetSocketAddress sa = InetSocketAddress.createUnresolved("localhost",0);
> new DatagramSocket().send(new DatagramPacket(new byte[272], 3, sa));
> }
> RI 6:
> Exception in thread "main" java.lang.IllegalArgumentException: unresolved address
> at java.net.DatagramPacket.setSocketAddress(DatagramPacket.java:295)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:123)
> at java.net.DatagramPacket.<init>(DatagramPacket.java:158)
> at DST2.main(DST2.java:10)
> Harmony 6: No Exception
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.