[GitHub] [jackrabbit-oak] anchela commented on a diff in pull request #590: OAK-9773: DefaultSyncContext#syncMembership() compares external ids c…

[GitBox <gi...@apache.org>]

anchela commented on code in PR #590:
URL: https://github.com/apache/jackrabbit-oak/pull/590#discussion_r894492915


##########
oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/basic/DefaultSyncContext.java:
##########
@@ -522,7 +522,7 @@ protected void syncMembership(@NotNull ExternalIdentity external, @NotNull Autho
         while (grpIter.hasNext()) {
             Group grp = grpIter.next();
             if (isSameIDP(grp)) {
-                declaredExternalGroups.put(grp.getID(), grp);
+                declaredExternalGroups.put(grp.getID().toLowerCase(), grp);

Review Comment:
   it is an implementation detail that the default user management in oak is not case-sensitive.
   therefore, at the very least this code should log a huge warning if the map already contained a previous value which would be replaced by this call.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org