You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Matthias (Jira)" <ji...@apache.org> on 2020/08/14 10:15:00 UTC

[jira] [Commented] (FLINK-17495) Add custom labels on PrometheusReporter like PrometheusPushGatewayReporter's groupingKey

    [ https://issues.apache.org/jira/browse/FLINK-17495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177682#comment-17177682 ] 

Matthias commented on FLINK-17495:
----------------------------------

We discussed the issue as part of the Engine team's backlog grooming: It's still considered valuable. The feature was requested a few times already on the mailing list. Hence, we keep it open for now.

> Add custom labels on PrometheusReporter like PrometheusPushGatewayReporter's groupingKey
> ----------------------------------------------------------------------------------------
>
>                 Key: FLINK-17495
>                 URL: https://issues.apache.org/jira/browse/FLINK-17495
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Metrics
>            Reporter: jinhai
>            Priority: Major
>              Labels: pull-request-available
>
> We need to add some custom labels on Prometheus, so we can query by them.
> Now we can add jobName\groupingKey to PrometheusPushGatewayReporter in version 1.10, but not in PrometheusReporter.
> Can we add AbstractPrometheusReporter#addDimension method to support this, so they will be no differences except for the metrics exposing mechanism pulling/pushing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)