You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/02/01 12:57:12 UTC

Review Request 56162: Recent workflows in Workflow designer

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56162/
-----------------------------------------------------------

Review request for Ambari, belliraj hb and Nitiraj Rathore.


Bugs: AMBARI-19815
    https://issues.apache.org/jira/browse/AMBARI-19815


Repository: ambari


Description
-------

User needs to easily access his recently saved workflows.
Optionally he should be able to manager the recent workflows by having ability to search recent workflow entry.
When user says open the recent entry,
- it should open the appropriate workflow.
-If the workflow is already opened it should tab and focus on the 
-if the workflow is opened in multiple tables, focus should be on one of the workflow tab.


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js 5b517af 
  contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 885655a 
  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js f863656 
  contrib/views/wfmanager/src/main/resources/ui/app/components/recent-projects.js PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 80bea99 
  contrib/views/wfmanager/src/main/resources/ui/app/helpers/format-unicode-date.js e6dd653 
  contrib/views/wfmanager/src/main/resources/ui/app/models/wfproject.js e90a613 
  contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js b6beef8 
  contrib/views/wfmanager/src/main/resources/ui/app/routes/design/proj-manager-tab.js b37ed83 
  contrib/views/wfmanager/src/main/resources/ui/app/services/current-job.js PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 755a6ad 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 37150f5 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 13f3ae7 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs 46a3f63 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs 54ea25f 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/recent-projects.hbs PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/design.hbs 012d9e7 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/design/proj-manager-tab.hbs b897a4c 

Diff: https://reviews.apache.org/r/56162/diff/


Testing
-------

Manual testing done


Thanks,

venkat sairam

Re: Review Request 56162: Recent workflows in Workflow designer

Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56162/#review163808
-----------------------------------------------------------


Ship it!




Ship It!

- Nitiraj Rathore


On Feb. 1, 2017, 12:57 p.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56162/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2017, 12:57 p.m.)
> 
> 
> Review request for Ambari, belliraj hb and Nitiraj Rathore.
> 
> 
> Bugs: AMBARI-19815
>     https://issues.apache.org/jira/browse/AMBARI-19815
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> User needs to easily access his recently saved workflows.
> Optionally he should be able to manager the recent workflows by having ability to search recent workflow entry.
> When user says open the recent entry,
> - it should open the appropriate workflow.
> -If the workflow is already opened it should tab and focus on the 
> -if the workflow is opened in multiple tables, focus should be on one of the workflow tab.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js 5b517af 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 885655a 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js f863656 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/recent-projects.js PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 80bea99 
>   contrib/views/wfmanager/src/main/resources/ui/app/helpers/format-unicode-date.js e6dd653 
>   contrib/views/wfmanager/src/main/resources/ui/app/models/wfproject.js e90a613 
>   contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js b6beef8 
>   contrib/views/wfmanager/src/main/resources/ui/app/routes/design/proj-manager-tab.js b37ed83 
>   contrib/views/wfmanager/src/main/resources/ui/app/services/current-job.js PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 755a6ad 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 37150f5 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 13f3ae7 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs 46a3f63 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs 54ea25f 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/recent-projects.hbs PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/design.hbs 012d9e7 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/design/proj-manager-tab.hbs b897a4c 
> 
> Diff: https://reviews.apache.org/r/56162/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 56162: Recent workflows in Workflow designer

Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56162/#review163807
-----------------------------------------------------------


Ship it!




Ship It!

- belliraj hb


On Feb. 1, 2017, 12:57 p.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56162/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2017, 12:57 p.m.)
> 
> 
> Review request for Ambari, belliraj hb and Nitiraj Rathore.
> 
> 
> Bugs: AMBARI-19815
>     https://issues.apache.org/jira/browse/AMBARI-19815
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> User needs to easily access his recently saved workflows.
> Optionally he should be able to manager the recent workflows by having ability to search recent workflow entry.
> When user says open the recent entry,
> - it should open the appropriate workflow.
> -If the workflow is already opened it should tab and focus on the 
> -if the workflow is opened in multiple tables, focus should be on one of the workflow tab.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js 5b517af 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 885655a 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js f863656 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/recent-projects.js PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 80bea99 
>   contrib/views/wfmanager/src/main/resources/ui/app/helpers/format-unicode-date.js e6dd653 
>   contrib/views/wfmanager/src/main/resources/ui/app/models/wfproject.js e90a613 
>   contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js b6beef8 
>   contrib/views/wfmanager/src/main/resources/ui/app/routes/design/proj-manager-tab.js b37ed83 
>   contrib/views/wfmanager/src/main/resources/ui/app/services/current-job.js PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 755a6ad 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 37150f5 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 13f3ae7 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs 46a3f63 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs 54ea25f 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/recent-projects.hbs PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/design.hbs 012d9e7 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/design/proj-manager-tab.hbs b897a4c 
> 
> Diff: https://reviews.apache.org/r/56162/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>