You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2016/09/25 02:25:48 UTC

[GitHub] tinkerpop pull request #437: TINKERPOP-790 TraversalSource and Traversal imp...

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/437

    TINKERPOP-790 TraversalSource and Traversal implement AutoCloseable.

    https://issues.apache.org/jira/browse/TINKERPOP-790
    
    This allowed for `TraversalSource` instances created using `withRemote()` to close out open `RemoteConnection` instances. It also sets up for side-effects created by a "remote" `Traversal` to be cleared from cache on the server. That work is not done yet and is reserved for a different ticket.
    
    Builds with `$ mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false`
    
    I won't VOTE on this yet as I suspect there might be some feedback from @okram perhaps.
    
    @davebshow note the placeholder for sending the "close" message for side-effects.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-790

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/437.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #437
    
----
commit 14211691effffec1f9fdf6ddd92c5833dff234de
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-09-25T02:18:56Z

    TraversalSource and Traversal implement AutoCloseable.
    
    This allowed for TraversalSource instances created using withRemote() to close out open RemoteConnection instances. It also sets up for side-effects created by a "remote" Traversal to be cleared from cache on the server. That work is not done yet and is reserved for a different ticket.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #437: TINKERPOP-790 TraversalSource and Traversal imp...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/437


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #437: TINKERPOP-790 TraversalSource and Traversal implement ...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/437
  
    Just rebased on master to clean up conflicts and force pushed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #437: TINKERPOP-790 TraversalSource and Traversal implement ...

Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:

    https://github.com/apache/tinkerpop/pull/437
  
    Good. Was scared at first seeing "new methods" on Traversal and TraversalSource, but I think this is smart. Gotz to release da resourcezzzzzzz...
    
    VOTE +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #437: TINKERPOP-790 TraversalSource and Traversal implement ...

Posted by twilmes <gi...@git.apache.org>.
Github user twilmes commented on the issue:

    https://github.com/apache/tinkerpop/pull/437
  
    VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #437: TINKERPOP-790 TraversalSource and Traversal implement ...

Posted by davebshow <gi...@git.apache.org>.
Github user davebshow commented on the issue:

    https://github.com/apache/tinkerpop/pull/437
  
    Good stuff, I should get there today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---