You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/05/23 14:26:30 UTC

Review Request 21858: CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21858/
-----------------------------------------------------------

Review request for cloudstack and Santhosh Edukulla.


Bugs: CLOUDSTACK-6758
    https://issues.apache.org/jira/browse/CLOUDSTACK-6758


Repository: cloudstack-git


Description
-------

Whenever API returns error message for failed job (not exception), in this case it is returned to test cases as it is. Instead it should throw exceptions for failed jobs.


Diffs
-----

  test/integration/component/test_accounts.py 9b9ae75 
  test/integration/component/test_add_remove_network.py 969d94c 
  test/integration/component/test_affinity_groups.py d31746a 
  test/integration/component/test_assign_vm.py 0b07e9f 
  test/integration/component/test_ip_reservation.py eb193d1 
  test/integration/component/test_non_contiguous_vlan.py 1f74252 
  test/integration/component/test_projects.py cf6cec8 
  test/integration/component/test_volumes.py 4a91e5d 
  test/integration/component/test_vpc.py 31b421c 
  test/integration/component/test_vpc_network.py 8d12ec6 
  test/integration/component/test_vpc_network_lbrules.py 47bdce5 
  test/integration/component/test_vpc_vms_deployment.py 19aa448 
  test/integration/smoke/test_network.py 7cd3973 
  test/integration/smoke/test_nic.py a76e858 
  test/integration/smoke/test_primary_storage.py 5b24b64 
  test/integration/smoke/test_volumes.py cc76e49 
  tools/marvin/marvin/cloudstackConnection.py 8044da7 
  tools/marvin/marvin/codes.py c72a6bd 

Diff: https://reviews.apache.org/r/21858/diff/


Testing
-------

Tested all the changed test cases on VMware.


Thanks,

Gaurav Aradhye

Re: Review Request 21858: CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21858/#review43860
-----------------------------------------------------------

Ship it!


Ship It!

- Santhosh Edukulla


On May 23, 2014, 12:31 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21858/
> -----------------------------------------------------------
> 
> (Updated May 23, 2014, 12:31 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6758
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6758
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Whenever API returns error message for failed job (not exception), in this case it is returned to test cases as it is. Instead it should throw exceptions for failed jobs.
> 
> With this change, reverted changes done in the test cases (Checking for ERROR_CODE_530) with commit https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=8eca37056f5bb1eee10f0bedee785142d7c3437a
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_accounts.py 9b9ae75 
>   test/integration/component/test_add_remove_network.py 969d94c 
>   test/integration/component/test_affinity_groups.py d31746a 
>   test/integration/component/test_assign_vm.py 0b07e9f 
>   test/integration/component/test_ip_reservation.py eb193d1 
>   test/integration/component/test_non_contiguous_vlan.py 1f74252 
>   test/integration/component/test_projects.py cf6cec8 
>   test/integration/component/test_volumes.py 4a91e5d 
>   test/integration/component/test_vpc.py 31b421c 
>   test/integration/component/test_vpc_network.py 8d12ec6 
>   test/integration/component/test_vpc_network_lbrules.py 47bdce5 
>   test/integration/component/test_vpc_vms_deployment.py 19aa448 
>   test/integration/smoke/test_network.py 7cd3973 
>   test/integration/smoke/test_nic.py a76e858 
>   test/integration/smoke/test_primary_storage.py 5b24b64 
>   test/integration/smoke/test_volumes.py cc76e49 
>   tools/marvin/marvin/cloudstackConnection.py 8044da7 
>   tools/marvin/marvin/codes.py c72a6bd 
> 
> Diff: https://reviews.apache.org/r/21858/diff/
> 
> 
> Testing
> -------
> 
> Tested all the changed test cases on VMware.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 21858: CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21858/#review43917
-----------------------------------------------------------


Commit a0ad836fd2ae2a5ebae97b72acbe35ad1c429a82 in cloudstack's branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a0ad836 ]

CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

Signed-off-by: Abhinandan Prateek <ap...@apache.org>


- ASF Subversion and Git Services


On May 23, 2014, 12:31 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21858/
> -----------------------------------------------------------
> 
> (Updated May 23, 2014, 12:31 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6758
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6758
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Whenever API returns error message for failed job (not exception), in this case it is returned to test cases as it is. Instead it should throw exceptions for failed jobs.
> 
> With this change, reverted changes done in the test cases (Checking for ERROR_CODE_530) with commit https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=8eca37056f5bb1eee10f0bedee785142d7c3437a
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_accounts.py 9b9ae75 
>   test/integration/component/test_add_remove_network.py 969d94c 
>   test/integration/component/test_affinity_groups.py d31746a 
>   test/integration/component/test_assign_vm.py 0b07e9f 
>   test/integration/component/test_ip_reservation.py eb193d1 
>   test/integration/component/test_non_contiguous_vlan.py 1f74252 
>   test/integration/component/test_projects.py cf6cec8 
>   test/integration/component/test_volumes.py 4a91e5d 
>   test/integration/component/test_vpc.py 31b421c 
>   test/integration/component/test_vpc_network.py 8d12ec6 
>   test/integration/component/test_vpc_network_lbrules.py 47bdce5 
>   test/integration/component/test_vpc_vms_deployment.py 19aa448 
>   test/integration/smoke/test_network.py 7cd3973 
>   test/integration/smoke/test_nic.py a76e858 
>   test/integration/smoke/test_primary_storage.py 5b24b64 
>   test/integration/smoke/test_volumes.py cc76e49 
>   tools/marvin/marvin/cloudstackConnection.py 8044da7 
>   tools/marvin/marvin/codes.py c72a6bd 
> 
> Diff: https://reviews.apache.org/r/21858/diff/
> 
> 
> Testing
> -------
> 
> Tested all the changed test cases on VMware.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 21858: CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21858/#review43913
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On May 23, 2014, 12:31 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21858/
> -----------------------------------------------------------
> 
> (Updated May 23, 2014, 12:31 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6758
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6758
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Whenever API returns error message for failed job (not exception), in this case it is returned to test cases as it is. Instead it should throw exceptions for failed jobs.
> 
> With this change, reverted changes done in the test cases (Checking for ERROR_CODE_530) with commit https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=8eca37056f5bb1eee10f0bedee785142d7c3437a
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_accounts.py 9b9ae75 
>   test/integration/component/test_add_remove_network.py 969d94c 
>   test/integration/component/test_affinity_groups.py d31746a 
>   test/integration/component/test_assign_vm.py 0b07e9f 
>   test/integration/component/test_ip_reservation.py eb193d1 
>   test/integration/component/test_non_contiguous_vlan.py 1f74252 
>   test/integration/component/test_projects.py cf6cec8 
>   test/integration/component/test_volumes.py 4a91e5d 
>   test/integration/component/test_vpc.py 31b421c 
>   test/integration/component/test_vpc_network.py 8d12ec6 
>   test/integration/component/test_vpc_network_lbrules.py 47bdce5 
>   test/integration/component/test_vpc_vms_deployment.py 19aa448 
>   test/integration/smoke/test_network.py 7cd3973 
>   test/integration/smoke/test_nic.py a76e858 
>   test/integration/smoke/test_primary_storage.py 5b24b64 
>   test/integration/smoke/test_volumes.py cc76e49 
>   tools/marvin/marvin/cloudstackConnection.py 8044da7 
>   tools/marvin/marvin/codes.py c72a6bd 
> 
> Diff: https://reviews.apache.org/r/21858/diff/
> 
> 
> Testing
> -------
> 
> Tested all the changed test cases on VMware.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 21858: CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21858/#review43914
-----------------------------------------------------------


Commit d9066f8d2931acc44ae66fc33f9eaa87b572de6a in cloudstack's branch refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d9066f8 ]

CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

Signed-off-by: Abhinandan Prateek <ap...@apache.org>


- ASF Subversion and Git Services


On May 23, 2014, 12:31 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21858/
> -----------------------------------------------------------
> 
> (Updated May 23, 2014, 12:31 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6758
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6758
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Whenever API returns error message for failed job (not exception), in this case it is returned to test cases as it is. Instead it should throw exceptions for failed jobs.
> 
> With this change, reverted changes done in the test cases (Checking for ERROR_CODE_530) with commit https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=8eca37056f5bb1eee10f0bedee785142d7c3437a
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_accounts.py 9b9ae75 
>   test/integration/component/test_add_remove_network.py 969d94c 
>   test/integration/component/test_affinity_groups.py d31746a 
>   test/integration/component/test_assign_vm.py 0b07e9f 
>   test/integration/component/test_ip_reservation.py eb193d1 
>   test/integration/component/test_non_contiguous_vlan.py 1f74252 
>   test/integration/component/test_projects.py cf6cec8 
>   test/integration/component/test_volumes.py 4a91e5d 
>   test/integration/component/test_vpc.py 31b421c 
>   test/integration/component/test_vpc_network.py 8d12ec6 
>   test/integration/component/test_vpc_network_lbrules.py 47bdce5 
>   test/integration/component/test_vpc_vms_deployment.py 19aa448 
>   test/integration/smoke/test_network.py 7cd3973 
>   test/integration/smoke/test_nic.py a76e858 
>   test/integration/smoke/test_primary_storage.py 5b24b64 
>   test/integration/smoke/test_volumes.py cc76e49 
>   tools/marvin/marvin/cloudstackConnection.py 8044da7 
>   tools/marvin/marvin/codes.py c72a6bd 
> 
> Diff: https://reviews.apache.org/r/21858/diff/
> 
> 
> Testing
> -------
> 
> Tested all the changed test cases on VMware.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 21858: CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21858/#review49095
-----------------------------------------------------------


Commit 34f3a5fd44cd7af9f53f628b71f48d854d498eff in cloudstack's branch refs/heads/4.4 from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=34f3a5f ]

CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

Signed-off-by: Abhinandan Prateek <ap...@apache.org>
(cherry picked from commit d9066f8d2931acc44ae66fc33f9eaa87b572de6a)


- ASF Subversion and Git Services


On May 23, 2014, 12:31 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21858/
> -----------------------------------------------------------
> 
> (Updated May 23, 2014, 12:31 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6758
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6758
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Whenever API returns error message for failed job (not exception), in this case it is returned to test cases as it is. Instead it should throw exceptions for failed jobs.
> 
> With this change, reverted changes done in the test cases (Checking for ERROR_CODE_530) with commit https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=8eca37056f5bb1eee10f0bedee785142d7c3437a
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_accounts.py 9b9ae75 
>   test/integration/component/test_add_remove_network.py 969d94c 
>   test/integration/component/test_affinity_groups.py d31746a 
>   test/integration/component/test_assign_vm.py 0b07e9f 
>   test/integration/component/test_ip_reservation.py eb193d1 
>   test/integration/component/test_non_contiguous_vlan.py 1f74252 
>   test/integration/component/test_projects.py cf6cec8 
>   test/integration/component/test_volumes.py 4a91e5d 
>   test/integration/component/test_vpc.py 31b421c 
>   test/integration/component/test_vpc_network.py 8d12ec6 
>   test/integration/component/test_vpc_network_lbrules.py 47bdce5 
>   test/integration/component/test_vpc_vms_deployment.py 19aa448 
>   test/integration/smoke/test_network.py 7cd3973 
>   test/integration/smoke/test_nic.py a76e858 
>   test/integration/smoke/test_primary_storage.py 5b24b64 
>   test/integration/smoke/test_volumes.py cc76e49 
>   tools/marvin/marvin/cloudstackConnection.py 8044da7 
>   tools/marvin/marvin/codes.py c72a6bd 
> 
> Diff: https://reviews.apache.org/r/21858/diff/
> 
> 
> Testing
> -------
> 
> Tested all the changed test cases on VMware.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 21858: CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21858/
-----------------------------------------------------------

(Updated May 23, 2014, 6:01 p.m.)


Review request for cloudstack and Santhosh Edukulla.


Bugs: CLOUDSTACK-6758
    https://issues.apache.org/jira/browse/CLOUDSTACK-6758


Repository: cloudstack-git


Description (updated)
-------

Whenever API returns error message for failed job (not exception), in this case it is returned to test cases as it is. Instead it should throw exceptions for failed jobs.

With this change, reverted changes done in the test cases (Checking for ERROR_CODE_530) with commit https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=8eca37056f5bb1eee10f0bedee785142d7c3437a


Diffs
-----

  test/integration/component/test_accounts.py 9b9ae75 
  test/integration/component/test_add_remove_network.py 969d94c 
  test/integration/component/test_affinity_groups.py d31746a 
  test/integration/component/test_assign_vm.py 0b07e9f 
  test/integration/component/test_ip_reservation.py eb193d1 
  test/integration/component/test_non_contiguous_vlan.py 1f74252 
  test/integration/component/test_projects.py cf6cec8 
  test/integration/component/test_volumes.py 4a91e5d 
  test/integration/component/test_vpc.py 31b421c 
  test/integration/component/test_vpc_network.py 8d12ec6 
  test/integration/component/test_vpc_network_lbrules.py 47bdce5 
  test/integration/component/test_vpc_vms_deployment.py 19aa448 
  test/integration/smoke/test_network.py 7cd3973 
  test/integration/smoke/test_nic.py a76e858 
  test/integration/smoke/test_primary_storage.py 5b24b64 
  test/integration/smoke/test_volumes.py cc76e49 
  tools/marvin/marvin/cloudstackConnection.py 8044da7 
  tools/marvin/marvin/codes.py c72a6bd 

Diff: https://reviews.apache.org/r/21858/diff/


Testing
-------

Tested all the changed test cases on VMware.


Thanks,

Gaurav Aradhye