You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/23 17:08:21 UTC
[GitHub] [flink] galenwarren opened a new pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
galenwarren opened a new pull request #18452:
URL: https://github.com/apache/flink/pull/18452
## What is the purpose of the change
Fix licensing issues in Java 11 build.
## Brief change log
Exclude javax.annotation.* in flink-gs-fs-hadoop via filter in pom.xml.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no) No
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) No
- The serializers: (yes / no / don't know) No
- The runtime per-record code paths (performance sensitive): (yes / no / don't know) No
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) No
- The S3 file system connector: (yes / no / don't know) No
## Documentation
- Does this pull request introduce a new feature? (yes / no) No
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #18452:
URL: https://github.com/apache/flink/pull/18452#discussion_r790521866
##########
File path: flink-filesystems/flink-gs-fs-hadoop/pom.xml
##########
@@ -214,6 +214,8 @@ under the License.
<exclude>META-INF/*.SF</exclude>
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
+ <!-- exclude javax.annotation because of GPLv2 license, see https://github.com/apache/flink/pull/15599#issuecomment-850241316 -->
+ <exclude>javax/annotation/**</exclude>
Review comment:
Instead of filtering it out when the shading happens, can this dependency be excluded when depending on the dependency which pulls it it (e.g. in the `<dependencies>` section)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #18452:
URL: https://github.com/apache/flink/pull/18452#discussion_r790856111
##########
File path: flink-filesystems/flink-gs-fs-hadoop/pom.xml
##########
@@ -214,6 +214,8 @@ under the License.
<exclude>META-INF/*.SF</exclude>
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
+ <!-- exclude javax.annotation because of GPLv2 license, see https://github.com/apache/flink/pull/15599#issuecomment-850241316 -->
+ <exclude>javax/annotation/**</exclude>
Review comment:
Hmm, what I would like to understand is why javax.annotation ends up in the final jar if it is already excluded?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18452:
URL: https://github.com/apache/flink/pull/18452#issuecomment-1019527627
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29956",
"triggerID" : "6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29956)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18452:
URL: https://github.com/apache/flink/pull/18452#issuecomment-1019527627
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29956",
"triggerID" : "6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff",
"triggerType" : "PUSH"
}, {
"hash" : "ee587b4878f90d9af7eb00b2236901d95146fa00",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee587b4878f90d9af7eb00b2236901d95146fa00",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29956)
* ee587b4878f90d9af7eb00b2236901d95146fa00 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] galenwarren commented on a change in pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
galenwarren commented on a change in pull request #18452:
URL: https://github.com/apache/flink/pull/18452#discussion_r790798748
##########
File path: flink-filesystems/flink-gs-fs-hadoop/pom.xml
##########
@@ -214,6 +214,8 @@ under the License.
<exclude>META-INF/*.SF</exclude>
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
+ <!-- exclude javax.annotation because of GPLv2 license, see https://github.com/apache/flink/pull/15599#issuecomment-850241316 -->
+ <exclude>javax/annotation/**</exclude>
Review comment:
Yes, the dependency is already excluded in that manner, [here](https://github.com/apache/flink/blob/4050cf320fc6c3ad77ad406689dd8a99af75d594/flink-filesystems/flink-gs-fs-hadoop/pom.xml#L89). And for Java 8 builds, that is sufficient -- there is no licensing problem.
In Java 11 builds, those two `package.html` files still seem to be present and causing problems, somehow. Adding the filter is an attempt to remove them from the jar file in those builds. In a local build of the Java 11 jar file, with this configuration, I can confirm by inspection that no file from `javax.annotation` -- including the `package.html` files -- is present. I don't know how to run the license check locally, though, so I can't test whether this fixes the Java 11 issue or not, without having someone merge the code.
I'm certainly open to alternate suggestions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18452:
URL: https://github.com/apache/flink/pull/18452#issuecomment-1019527627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18452:
URL: https://github.com/apache/flink/pull/18452#issuecomment-1019527627
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29956",
"triggerID" : "6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff",
"triggerType" : "PUSH"
}, {
"hash" : "ee587b4878f90d9af7eb00b2236901d95146fa00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29958",
"triggerID" : "ee587b4878f90d9af7eb00b2236901d95146fa00",
"triggerType" : "PUSH"
}, {
"hash" : "d9507c8a77a6674f949c2f19e0f75c2419b87396",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30076",
"triggerID" : "d9507c8a77a6674f949c2f19e0f75c2419b87396",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d9507c8a77a6674f949c2f19e0f75c2419b87396 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30076)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18452:
URL: https://github.com/apache/flink/pull/18452#issuecomment-1019527627
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29956",
"triggerID" : "6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff",
"triggerType" : "PUSH"
}, {
"hash" : "ee587b4878f90d9af7eb00b2236901d95146fa00",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29958",
"triggerID" : "ee587b4878f90d9af7eb00b2236901d95146fa00",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29956)
* ee587b4878f90d9af7eb00b2236901d95146fa00 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29958)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong closed pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
xintongsong closed pull request #18452:
URL: https://github.com/apache/flink/pull/18452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18452:
URL: https://github.com/apache/flink/pull/18452#issuecomment-1019527950
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff (Sun Jan 23 17:12:56 UTC 2022)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18452:
URL: https://github.com/apache/flink/pull/18452#issuecomment-1019527627
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #18452:
URL: https://github.com/apache/flink/pull/18452#discussion_r790521866
##########
File path: flink-filesystems/flink-gs-fs-hadoop/pom.xml
##########
@@ -214,6 +214,8 @@ under the License.
<exclude>META-INF/*.SF</exclude>
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
+ <!-- exclude javax.annotation because of GPLv2 license, see https://github.com/apache/flink/pull/15599#issuecomment-850241316 -->
+ <exclude>javax/annotation/**</exclude>
Review comment:
Instead of filtering it out when the shading happens, can this dependency be excluded when depending on the dependency which pulls it in (e.g. in the `<dependencies>` section)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong closed pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
xintongsong closed pull request #18452:
URL: https://github.com/apache/flink/pull/18452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18452:
URL: https://github.com/apache/flink/pull/18452#issuecomment-1019527627
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29956",
"triggerID" : "6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff",
"triggerType" : "PUSH"
}, {
"hash" : "ee587b4878f90d9af7eb00b2236901d95146fa00",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29958",
"triggerID" : "ee587b4878f90d9af7eb00b2236901d95146fa00",
"triggerType" : "PUSH"
}, {
"hash" : "d9507c8a77a6674f949c2f19e0f75c2419b87396",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d9507c8a77a6674f949c2f19e0f75c2419b87396",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee587b4878f90d9af7eb00b2236901d95146fa00 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29958)
* d9507c8a77a6674f949c2f19e0f75c2419b87396 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] galenwarren commented on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
galenwarren commented on pull request #18452:
URL: https://github.com/apache/flink/pull/18452#issuecomment-1019527513
@MartijnVisser I'm not sure how to run these license checks locally, so this is a bit of a guess. Previously, javax.annotation was excluded via a dependency exclusion, which seemed to work fine for Java 8 but, apparently, not for Java 11. With this change, javax.annotation.* is excluded via a filter in `maven-shade-plugin`, perhaps this will work better for Java 11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18452:
URL: https://github.com/apache/flink/pull/18452#issuecomment-1019527627
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29956",
"triggerID" : "6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff",
"triggerType" : "PUSH"
}, {
"hash" : "ee587b4878f90d9af7eb00b2236901d95146fa00",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29958",
"triggerID" : "ee587b4878f90d9af7eb00b2236901d95146fa00",
"triggerType" : "PUSH"
}, {
"hash" : "d9507c8a77a6674f949c2f19e0f75c2419b87396",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30076",
"triggerID" : "d9507c8a77a6674f949c2f19e0f75c2419b87396",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee587b4878f90d9af7eb00b2236901d95146fa00 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29958)
* d9507c8a77a6674f949c2f19e0f75c2419b87396 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30076)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] galenwarren commented on a change in pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
galenwarren commented on a change in pull request #18452:
URL: https://github.com/apache/flink/pull/18452#discussion_r790971234
##########
File path: flink-filesystems/flink-gs-fs-hadoop/pom.xml
##########
@@ -214,6 +214,8 @@ under the License.
<exclude>META-INF/*.SF</exclude>
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
+ <!-- exclude javax.annotation because of GPLv2 license, see https://github.com/apache/flink/pull/15599#issuecomment-850241316 -->
+ <exclude>javax/annotation/**</exclude>
Review comment:
I had actually just pushed a commit to this PR with those changes, as well: https://github.com/apache/flink/pull/18452/commits/d9507c8a77a6674f949c2f19e0f75c2419b87396.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #18452:
URL: https://github.com/apache/flink/pull/18452#discussion_r790965666
##########
File path: flink-filesystems/flink-gs-fs-hadoop/pom.xml
##########
@@ -214,6 +214,8 @@ under the License.
<exclude>META-INF/*.SF</exclude>
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
+ <!-- exclude javax.annotation because of GPLv2 license, see https://github.com/apache/flink/pull/15599#issuecomment-850241316 -->
+ <exclude>javax/annotation/**</exclude>
Review comment:
I've created a quick PR with the changes #18484. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #18452:
URL: https://github.com/apache/flink/pull/18452#issuecomment-1020379351
I will merge this PR once AZP gives green light.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18452:
URL: https://github.com/apache/flink/pull/18452#issuecomment-1019527627
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29956",
"triggerID" : "6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff",
"triggerType" : "PUSH"
}, {
"hash" : "ee587b4878f90d9af7eb00b2236901d95146fa00",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29958",
"triggerID" : "ee587b4878f90d9af7eb00b2236901d95146fa00",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee587b4878f90d9af7eb00b2236901d95146fa00 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29958)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] galenwarren commented on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
galenwarren commented on pull request #18452:
URL: https://github.com/apache/flink/pull/18452#issuecomment-1019568918
@MartijnVisser
The issues with the Java 11 build were with respect to `package.html` files; perhaps excluding `javax.annotation` as a dependency doesn't prevent such files from making it into the jar?
I added a filter rule that excludes any file matching `javax/annotation/**` from the jar file, and I confirmed that there are no files in the Java 11 jar files that start with `javax/annotation/`. So hopefully this will fix the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #18452:
URL: https://github.com/apache/flink/pull/18452#discussion_r790960376
##########
File path: flink-filesystems/flink-gs-fs-hadoop/pom.xml
##########
@@ -214,6 +214,8 @@ under the License.
<exclude>META-INF/*.SF</exclude>
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
+ <!-- exclude javax.annotation because of GPLv2 license, see https://github.com/apache/flink/pull/15599#issuecomment-850241316 -->
+ <exclude>javax/annotation/**</exclude>
Review comment:
I think the dependency is pulled in by the `gcs-connector` dependency when using Java 11. Hence, adding the exclusion to this dependency should solve the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] galenwarren commented on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
galenwarren commented on pull request #18452:
URL: https://github.com/apache/flink/pull/18452#issuecomment-1020380245
Sounds good - thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18452:
URL: https://github.com/apache/flink/pull/18452#issuecomment-1019527627
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29956",
"triggerID" : "6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cf148aeb02d6fdbaf0bd78fa1d6a1aca76dbeff Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29956)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] galenwarren commented on a change in pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
galenwarren commented on a change in pull request #18452:
URL: https://github.com/apache/flink/pull/18452#discussion_r790882554
##########
File path: flink-filesystems/flink-gs-fs-hadoop/pom.xml
##########
@@ -214,6 +214,8 @@ under the License.
<exclude>META-INF/*.SF</exclude>
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
+ <!-- exclude javax.annotation because of GPLv2 license, see https://github.com/apache/flink/pull/15599#issuecomment-850241316 -->
+ <exclude>javax/annotation/**</exclude>
Review comment:
Agreed, that's the puzzling part.
It doesn't seem that there are any actual code files included in the Java 11 jar, it's just these two `package.html` files. Maybe those files are treated differently in the bundling process, somehow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] galenwarren commented on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
galenwarren commented on pull request #18452:
URL: https://github.com/apache/flink/pull/18452#issuecomment-1020380245
Sounds good - thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #18452:
URL: https://github.com/apache/flink/pull/18452#issuecomment-1020379351
I will merge this PR once AZP gives green light.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org