You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "tatiana (via GitHub)" <gi...@apache.org> on 2023/04/28 13:49:36 UTC
[GitHub] [airflow] tatiana commented on a diff in pull request #30943: Add support for dynamic tasks with template fields that contain `pandas.DataFrame`
tatiana commented on code in PR #30943:
URL: https://github.com/apache/airflow/pull/30943#discussion_r1180434459
##########
airflow/models/abstractoperator.py:
##########
@@ -564,7 +566,7 @@ def _do_render_template_fields(
f"{attr_name!r} is configured as a template field "
f"but {parent.task_type} does not have this attribute."
)
- if not value:
+ if isinstance(value, pd.DataFrame) or not value:
Review Comment:
Do we have a list of supported types we expect to use as `template_fields`? An alternative to skipping `pandas.DataFrame`, would be to check if the value type is within the supported types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org