You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/07 23:19:40 UTC
Review Request 67496: Ported `EnvTest.EraseEnv` to Windows,
with added comments.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67496/
-----------------------------------------------------------
Review request for mesos, James Peach and Radhika Jandhyala.
Repository: mesos
Description
-------
The difference between `os::unsetenv` and `os::eraseenv` is important,
but subtle. Now the reason for the existence of `os::eraseenv` is
documented in comments.
Diffs
-----
3rdparty/stout/include/stout/posix/os.hpp f898f07515bcc663fea1eef52497feb518d4ca53
3rdparty/stout/include/stout/windows/os.hpp 3a728f8cb699c1a4a0bbbf1ecb44f9d33b60e4e3
3rdparty/stout/tests/os/env_tests.cpp b5b124dc6316e661af6dd90335ade5283c26d9f2
Diff: https://reviews.apache.org/r/67496/diff/1/
Testing
-------
stout-tests on Windows
Thanks,
Andrew Schwartzmeyer
Re: Review Request 67496: Ported `EnvTest.EraseEnv` to Windows,
with added comments.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67496/#review204476
-----------------------------------------------------------
PASS: Mesos patch 67496 was successfully built and tested.
Reviews applied: `['67496']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67496
- Mesos Reviewbot Windows
On June 7, 2018, 11:19 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67496/
> -----------------------------------------------------------
>
> (Updated June 7, 2018, 11:19 p.m.)
>
>
> Review request for mesos, James Peach and Radhika Jandhyala.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The difference between `os::unsetenv` and `os::eraseenv` is important,
> but subtle. Now the reason for the existence of `os::eraseenv` is
> documented in comments.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/posix/os.hpp f898f07515bcc663fea1eef52497feb518d4ca53
> 3rdparty/stout/include/stout/windows/os.hpp 3a728f8cb699c1a4a0bbbf1ecb44f9d33b60e4e3
> 3rdparty/stout/tests/os/env_tests.cpp b5b124dc6316e661af6dd90335ade5283c26d9f2
>
>
> Diff: https://reviews.apache.org/r/67496/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 67496: Ported `EnvTest.EraseEnv` to Windows,
with added comments.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67496/#review204477
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67496]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 7, 2018, 4:19 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67496/
> -----------------------------------------------------------
>
> (Updated June 7, 2018, 4:19 p.m.)
>
>
> Review request for mesos, James Peach and Radhika Jandhyala.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The difference between `os::unsetenv` and `os::eraseenv` is important,
> but subtle. Now the reason for the existence of `os::eraseenv` is
> documented in comments.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/posix/os.hpp f898f07515bcc663fea1eef52497feb518d4ca53
> 3rdparty/stout/include/stout/windows/os.hpp 3a728f8cb699c1a4a0bbbf1ecb44f9d33b60e4e3
> 3rdparty/stout/tests/os/env_tests.cpp b5b124dc6316e661af6dd90335ade5283c26d9f2
>
>
> Diff: https://reviews.apache.org/r/67496/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 67496: Ported `EnvTest.EraseEnv` to Windows,
with added comments.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67496/
-----------------------------------------------------------
(Updated June 11, 2018, 3:29 p.m.)
Review request for mesos, James Peach and Radhika Jandhyala.
Repository: mesos
Description
-------
The difference between `os::unsetenv` and `os::eraseenv` is important,
but subtle. Now the reason for the existence of `os::eraseenv` is
documented in comments.
Diffs (updated)
-----
3rdparty/stout/include/stout/posix/os.hpp f898f07515bcc663fea1eef52497feb518d4ca53
3rdparty/stout/include/stout/windows/os.hpp 3a728f8cb699c1a4a0bbbf1ecb44f9d33b60e4e3
3rdparty/stout/tests/os/env_tests.cpp b5b124dc6316e661af6dd90335ade5283c26d9f2
Diff: https://reviews.apache.org/r/67496/diff/2/
Changes: https://reviews.apache.org/r/67496/diff/1-2/
Testing
-------
stout-tests on Windows
Thanks,
Andrew Schwartzmeyer
Re: Review Request 67496: Ported `EnvTest.EraseEnv` to Windows,
with added comments.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67496/#review204564
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/stout/tests/os/env_tests.cpp
Line 86 (original), 97 (patched)
<https://reviews.apache.org/r/67496/#comment287152>
Can you spell `ernvironment` while you are here?
:)
- James Peach
On June 7, 2018, 11:19 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67496/
> -----------------------------------------------------------
>
> (Updated June 7, 2018, 11:19 p.m.)
>
>
> Review request for mesos, James Peach and Radhika Jandhyala.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The difference between `os::unsetenv` and `os::eraseenv` is important,
> but subtle. Now the reason for the existence of `os::eraseenv` is
> documented in comments.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/posix/os.hpp f898f07515bcc663fea1eef52497feb518d4ca53
> 3rdparty/stout/include/stout/windows/os.hpp 3a728f8cb699c1a4a0bbbf1ecb44f9d33b60e4e3
> 3rdparty/stout/tests/os/env_tests.cpp b5b124dc6316e661af6dd90335ade5283c26d9f2
>
>
> Diff: https://reviews.apache.org/r/67496/diff/1/
>
>
> Testing
> -------
>
> stout-tests on Windows
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>