You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Malcolm Rowe <ma...@farside.org.uk> on 2005/11/08 17:29:41 UTC
Re: [PATCH] Fix bogus code in libsvn_client/ra.c: slow_locations()
Ping.
Does anyone have any comments about this patch? What we have now is
clearly bogus, and I'm fairly sure the patch is correct, but I'm not
going to commit without someone else acking it.
(If I don't get any response, I'll just commit a patch that removes the
useless local variable and makes the code run unconditionally, which is
what's really happening now).
(Patch is at http://svn.haxx.se/dev/archive-2005-10/1501.shtml, in case
you've no longer got the original message).
Regards,
Malcolm
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix bogus code in libsvn_client/ra.c: slow_locations()
Posted by Martin Furter <mf...@rola.ch>.
Hi Malcolm
I guess i don't have a deleted and readded file in my repos, but i created
one in my test repos: http://queen.borg.ch:81/svn/test1/
Is a file containing a "hello" enough or do you need a bigger file for
testing?
Martin
On Sat, 26 Nov 2005, Malcolm Rowe wrote:
> On Tue, Nov 08, 2005 at 10:10:39PM +0100, Martin Furter wrote:
>> My server still runs svn 1.0.5: http://queen.borg.ch:81/svn/repos/
>> I can give you write access or setup svnserve if you need that.
>>
>
> Martin, thanks for this. I just wanted you to know that I haven't
> forgotten about the issue - I just haven't had a chance to investigate
> it properly yet.
>
> What I think I need in the repository is a file that has two separate
> lines of history under the same name (in other words, deleted and
> then recreated). I don't suppose you've got a file like this in your
> repository, by any chance?
>
> Regards,
> Malcolm
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix bogus code in libsvn_client/ra.c: slow_locations()
Posted by Malcolm Rowe <ma...@farside.org.uk>.
On Tue, Nov 08, 2005 at 10:10:39PM +0100, Martin Furter wrote:
> My server still runs svn 1.0.5: http://queen.borg.ch:81/svn/repos/
> I can give you write access or setup svnserve if you need that.
>
Martin, thanks for this. I just wanted you to know that I haven't
forgotten about the issue - I just haven't had a chance to investigate
it properly yet.
What I think I need in the repository is a file that has two separate
lines of history under the same name (in other words, deleted and
then recreated). I don't suppose you've got a file like this in your
repository, by any chance?
Regards,
Malcolm
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix bogus code in libsvn_client/ra.c: slow_locations()
Posted by Martin Furter <mf...@rola.ch>.
My server still runs svn 1.0.5: http://queen.borg.ch:81/svn/repos/
I can give you write access or setup svnserve if you need that.
Martin
On Tue, 8 Nov 2005, Malcolm Rowe wrote:
> On Tue, Nov 08, 2005 at 11:21:25AM -0800, Garrett Rooney wrote:
>> On 11/8/05, Malcolm Rowe <ma...@farside.org.uk> wrote:
>>> Does anyone have any comments about this patch? What we have now is
>>> clearly bogus, and I'm fairly sure the patch is correct, but I'm not
>>> going to commit without someone else acking it.
>>>
>>> (If I don't get any response, I'll just commit a patch that removes the
>>> useless local variable and makes the code run unconditionally, which is
>>> what's really happening now).
>>>
>>> (Patch is at http://svn.haxx.se/dev/archive-2005-10/1501.shtml, in case
>>> you've no longer got the original message).
>>
>> The patch seems reasonable to me, although I didn't go so far as to
>> commit it myself because I didn't have a good way to test it easily.
>> What kind of testing have you done with it?
>>
>
> I have the same problem as you: no 1.0.x server to test against (does
> anyone know of a public one?), so compile-tested and tested-by-inspection
> only.
>
> The patch _should_ be safe, since it's just reverting to the behaviour
> that we had in 1.2.1, and the changes Greg made in r15581 were mainly
> to change the log revisions we requested, not to change the latter part
> of the code (as far as I can see from the log message, anyway).
>
> Even so, without any way to exercise the code, I'm not going to commit
> it myself without review, however trivial.
>
> Regards,
> Malcolm
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix bogus code in libsvn_client/ra.c: slow_locations()
Posted by Malcolm Rowe <ma...@farside.org.uk>.
On Tue, Nov 08, 2005 at 11:21:25AM -0800, Garrett Rooney wrote:
> On 11/8/05, Malcolm Rowe <ma...@farside.org.uk> wrote:
> > Does anyone have any comments about this patch? What we have now is
> > clearly bogus, and I'm fairly sure the patch is correct, but I'm not
> > going to commit without someone else acking it.
> >
> > (If I don't get any response, I'll just commit a patch that removes the
> > useless local variable and makes the code run unconditionally, which is
> > what's really happening now).
> >
> > (Patch is at http://svn.haxx.se/dev/archive-2005-10/1501.shtml, in case
> > you've no longer got the original message).
>
> The patch seems reasonable to me, although I didn't go so far as to
> commit it myself because I didn't have a good way to test it easily.
> What kind of testing have you done with it?
>
I have the same problem as you: no 1.0.x server to test against (does
anyone know of a public one?), so compile-tested and tested-by-inspection
only.
The patch _should_ be safe, since it's just reverting to the behaviour
that we had in 1.2.1, and the changes Greg made in r15581 were mainly
to change the log revisions we requested, not to change the latter part
of the code (as far as I can see from the log message, anyway).
Even so, without any way to exercise the code, I'm not going to commit
it myself without review, however trivial.
Regards,
Malcolm
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix bogus code in libsvn_client/ra.c: slow_locations()
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 11/8/05, Malcolm Rowe <ma...@farside.org.uk> wrote:
> Ping.
>
> Does anyone have any comments about this patch? What we have now is
> clearly bogus, and I'm fairly sure the patch is correct, but I'm not
> going to commit without someone else acking it.
>
> (If I don't get any response, I'll just commit a patch that removes the
> useless local variable and makes the code run unconditionally, which is
> what's really happening now).
>
> (Patch is at http://svn.haxx.se/dev/archive-2005-10/1501.shtml, in case
> you've no longer got the original message).
The patch seems reasonable to me, although I didn't go so far as to
commit it myself because I didn't have a good way to test it easily.
What kind of testing have you done with it?
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org