You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2022/04/19 14:02:36 UTC

[GitHub] [mesos] qianzhangxa commented on a diff in pull request #426: Fixed a crash in Storage Local Resource ProviderProcess.

qianzhangxa commented on code in PR #426:
URL: https://github.com/apache/mesos/pull/426#discussion_r853115971


##########
src/resource_provider/storage/provider.cpp:
##########
@@ -471,7 +471,7 @@ StorageLocalResourceProviderProcess::StorageLocalResourceProviderProcess(
 
 void StorageLocalResourceProviderProcess::connected()
 {
-  CHECK_EQ(DISCONNECTED, state);
+  CHECK(state == DISCONNECTED || state == READY) << state;

Review Comment:
   Suggest to change it to:
   
   ```
   CHECK(state == DISCONNECTED || state == READY) << "Unexpected state: " << state;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org