You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2026/05/09 07:47:54 UTC
[PR] [SPARK-56806][BUILD] Fix `jetty-proxy` artifact ID in `core/pom.xml`'s `includeArtifactIds` [spark]
cloud-fan opened a new pull request, #55779:
URL: https://github.com/apache/spark/pull/55779
### What changes were proposed in this pull request?
In `core/pom.xml`, the `<includeArtifactIds>` list under the `maven-dependency-plugin`'s `copy-dependencies` execution still references the old artifact ID `jetty-proxy`, while the actual `<dependency>` declared in the same file (and the corresponding `<include>` in the `maven-shade-plugin`) both use the renamed `jetty-ee10-proxy`. This PR renames `jetty-proxy` → `jetty-ee10-proxy` in the `<includeArtifactIds>` list to keep all three locations consistent.
### Why are the changes needed?
Because there is no longer any artifact with id `jetty-proxy` on the classpath, the `copy-dependencies` execution silently skips the proxy JAR. With `SPARK_PREPEND_CLASSES`, Spark relies on the unshaded original JARs being copied to `target/`, so the proxy JAR is missing in that mode. Renaming the entry restores the intended behavior.
### Does this PR introduce _any_ user-facing change?
No. Build-only fix.
### How was this patch tested?
Existing build. Verified that the dependency block (`org.eclipse.jetty.ee10:jetty-ee10-proxy`) and the `maven-shade-plugin` `<include>` already use the same renamed artifact ID.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (claude-opus-4-7)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56806][BUILD] Fix `jetty-proxy` artifact ID in `core/pom.xml`'s `includeArtifactIds` [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #55779: [SPARK-56806][BUILD] Fix `jetty-proxy` artifact ID in `core/pom.xml`'s `includeArtifactIds`
URL: https://github.com/apache/spark/pull/55779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56806][BUILD] Fix `jetty-proxy` artifact ID in `core/pom.xml`'s `includeArtifactIds` [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #55779:
URL: https://github.com/apache/spark/pull/55779#issuecomment-4414098075
docker test failure is unrelated, thanks for review, merging to master/4.x!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org