You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/07/30 17:09:17 UTC
[GitHub] [iceberg] rdblue commented on a change in pull request #2881: API: Close the underlying iterator in ClosingIterator correctly.
rdblue commented on a change in pull request #2881:
URL: https://github.com/apache/iceberg/pull/2881#discussion_r680099221
##########
File path: api/src/main/java/org/apache/iceberg/io/ClosingIterator.java
##########
@@ -25,33 +25,30 @@
public class ClosingIterator<T> implements Iterator<T> {
Review comment:
I think this was an oversight. I don't see a reason why it shouldn't be `Closeable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org