You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2014/07/08 14:22:51 UTC
[Issue 125222] New: embedded OLE object imported with wrong style
from PPTX
https://issues.apache.org/ooo/show_bug.cgi?id=125222
Issue ID: 125222
Issue Type: DEFECT
Summary: embedded OLE object imported with wrong style from
PPTX
Product: Impress
Version: 4.1.0
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: open-import
Assignee: issues@openoffice.apache.org
Reporter: szurketestver@gmail.com
Created attachment 83658
--> https://issues.apache.org/ooo/attachment.cgi?id=83658&action=edit
Slide with embedded Excel sheet
The attached file was created with PowerPoint 2010. I inserted an Excel sheet
as OLE object into the slide. In OpenOffice it is imported with Default style,
which is not good, because the background fill color is blue instead of none.
It should have been imported with "Object with no fill and no line".
The blue background is a regression from r1344740.
#119287# exchanged hard attributes for OLE and GraphicObject with new default
StyleSheet for these objects
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125222] embedded OLE object imported with wrong style from
PPTX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125222
--- Comment #6 from Armin Le Grand <Ar...@me.com> ---
Note: Issue 125224 is similar and I guess OLE import was never added to PPTX,
too. If then this should lead to a separate enhancement request; this task will
correct the fill attributes/styles
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
4.1.1_release_blocker requested: [Issue 125222] embedded OLE object
imported with wrong style from PPTX
Posted by bu...@apache.org.
Armin Le Grand <Ar...@me.com> has asked for 4.1.1_release_blocker:
Issue 125222: embedded OLE object imported with wrong style from PPTX
https://issues.apache.org/ooo/show_bug.cgi?id=125222
------- Additional Comments from Armin Le Grand <Ar...@me.com>
Commited to trunk, done.
Safe fix (AFAIK), regression from AOO341. A candidate for AOO411. Requesting
flag...
[Issue 125222] embedded OLE object imported with wrong style from
PPTX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125222
Rekha S <re...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rekhask@gmail.com
--- Comment #16 from Rekha S <re...@gmail.com> ---
Verified fixed on AOO 4.1.1 m3 build: 9772
on Windows 8
Now importing a excel table object from excel works as expected ,with no fill &
no line!
Yuzhen, pls mark as verified .
Thanks
Rekha
--
You are receiving this mail because:
You are watching all issue changes.
4.1.1_release_blocker granted: [Issue 125222] embedded OLE object
imported with wrong style from PPTX
Posted by bu...@apache.org.
jsc@apache.org has granted Armin Le Grand <Ar...@me.com>'s request for
4.1.1_release_blocker:
Issue 125222: embedded OLE object imported with wrong style from PPTX
https://issues.apache.org/ooo/show_bug.cgi?id=125222
------- Additional Comments from jsc@apache.org
grant showstopper flag
[Issue 125222] embedded OLE object imported with wrong style from
PPTX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125222
jsc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jsc@apache.org
Flags|4.1.1_release_blocker? |4.1.1_release_blocker+
--- Comment #11 from jsc@apache.org ---
grant showstopper flag
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 125222] embedded OLE object imported with wrong style from
PPTX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125222
--- Comment #8 from Armin Le Grand <Ar...@me.com> ---
Re-checked, looks good. Preparing commit...
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 125222] embedded OLE object imported with wrong style from
PPTX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125222
--- Comment #5 from Armin Le Grand <Ar...@me.com> ---
The metafile is okay, but the graphic object containing it gets no default fill
style as needed, probably because it's not a real object but a artificial one
to get the OLE content visualized, so it probably will not get attributes read
from the import file.
In any case in SdGenericDrawPage::_CreateSdrObject the correct default style
has to be used for graphic and ole shapes, similar to SdrOle2Obj::SetPage and
SdrGrafObj::SetPage, thus I will add and test that...
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125222] embedded OLE object imported with wrong style from
PPTX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125222
--- Comment #2 from Armin Le Grand <Ar...@me.com> ---
The same should happen with pptx containing graphic objects, thus checked that.
The object has no fill, no line and default as style. It still works, but
somehow fill seems to be set as hard attributes, using 'format default
formatting' shows the expected blue background. Checking where this is done
(would be an alternative to do the same for OLEs)...
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125222] embedded OLE object imported with wrong style from
PPTX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125222
--- Comment #13 from Armin Le Grand <Ar...@me.com> ---
"alg" committed SVN revision 1609460 into branches/AOO410:
i125222 corrected default style for draw objects created using UNO API
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 125222] embedded OLE object imported with wrong style from
PPTX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125222
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ACCEPTED |RESOLVED
Resolution|--- |FIXED
Flags| |4.1.1_release_blocker?
--- Comment #9 from Armin Le Grand <Ar...@me.com> ---
Commited to trunk, done.
Safe fix (AFAIK), regression from AOO341. A candidate for AOO411. Requesting
flag...
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 125222] embedded OLE object imported with wrong style from
PPTX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125222
fanyuzhen@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--- Comment #17 from fanyuzhen@gmail.com ---
Thanks Rekha!
Marking it as verified
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 125222] embedded OLE object imported with wrong style from
PPTX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125222
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ACCEPTED
Assignee|issues@openoffice.apache.or |Armin.Le.Grand@me.com
|g |
Target Milestone|--- |4.2.0
Ever confirmed|0 |1
--- Comment #7 from Armin Le Grand <Ar...@me.com> ---
Tested with changed SdGenericDrawPage::_CreateSdrObject, works as expected. It
is an intended and needed change, it's about the place where the UNO API
incarnates implementation objects for existing XShape UNO objects. In the cases
I saw setting the style is not even needed - this is already done in object
construction - but I will not risk that this is missing. As noted in the issue
119287 this will change in aw080 anyways since there SdrObjects will get a
default style at construction time; adding a tagged (TTTT for aw080 changes)
note there to adapt again when aw080 is ready...
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125222] embedded OLE object imported with wrong style from
PPTX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125222
fanyuzhen@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fanyuzhen@gmail.com
--- Comment #15 from fanyuzhen@gmail.com ---
Per Juergen on July 16:
"The translation deadline is on July 18th and then a new milestone will be
prepared.
I expect it being available mid of next week"
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 125222] embedded OLE object imported with wrong style from
PPTX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125222
--- Comment #4 from Armin Le Grand <Ar...@me.com> ---
This also means that the OLE import in PPTX is not working - what it should
create is one OLE with the correct content. The content is currently
represented as metafile and lost (as it seems). Do we have a task for this?
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125222] embedded OLE object imported with wrong style from
PPTX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125222
szurketestver@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |Armin.Le.Grand@me.com
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125222] embedded OLE object imported with wrong style from
PPTX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125222
Shenfeng Liu <li...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |liushenf@gmail.com
--- Comment #14 from Shenfeng Liu <li...@gmail.com> ---
The fix is not in AOO 4.1.1 Milestone 2 build (1608452). So need to verify it
in the next build.
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 125222] embedded OLE object imported with wrong style from
PPTX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125222
--- Comment #3 from Armin Le Grand <Ar...@me.com> ---
Could not find out where the background fill for the OLE is created; after
quite some debugging I saw that the loaded bugdoc creates *two* objects, an OLE
and a GraphicObject containing a metafile. The OLE is empty and shows the
'emptyole' symbol and is *not filled* as it should be, while for the graphic
object the metafile itself contains the blue filled background. Argh!
Thus the error is some mechanism in the PPTX import that creates that metafile,
not at the objects (which still could have the 'Object with no fill and no
line' set as style, but get the correct no fill attribute already as hard
attribute)
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125222] embedded OLE object imported with wrong style from
PPTX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125222
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.2.0 |4.1.1
--- Comment #12 from Armin Le Grand <Ar...@me.com> ---
Added to branch AOO410, checked, works. Adapting target, committing there...
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 125222] embedded OLE object imported with wrong style from
PPTX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125222
--- Comment #1 from Armin Le Grand <Ar...@me.com> ---
Indeed the object has correctly no fill or line style, but uses the default
style which leads to being filled blue. This is identical in AOO411, AOO410,
AOO401 and trunk. What AOO version is r1344740, could you please give the AOO
version directly? Its AOO341 where it also gets the default style, but is not
filled. Reason for this is that in former AOO versions OLEs and GraphicObjects
got the default style, but their line and fill style was hard-wired to ignore
that, so no graphic attributes were possible for those object types. OLEs and
GraphicObjects should indeed use 'NoFillNoLine' as style as they do when you
create/add one. For some reason this is not the case for the PPTX import.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125222] embedded OLE object imported with wrong style from
PPTX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125222
--- Comment #10 from Armin Le Grand <Ar...@me.com> ---
Upps, had wrong task-ID in commit, the commit message is (from issue 119287)
----------------------
"alg" committed SVN revision 1609118 into trunk:
i119287 corrected default style for draw objects created using UNO API
--
You are receiving this mail because:
You are watching all issue changes.