You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2019/05/11 21:11:13 UTC
[GitHub] [commons-compress] hboutemy commented on a change in pull request
#78: COMPRESS-485 keep zip entries order in parallel zip creation
hboutemy commented on a change in pull request #78: COMPRESS-485 keep zip entries order in parallel zip creation
URL: https://github.com/apache/commons-compress/pull/78#discussion_r283111605
##########
File path: src/main/java/org/apache/commons/compress/archivers/zip/ParallelScatterZipCreator.java
##########
@@ -255,8 +257,13 @@ public void writeTo(final ZipArchiveOutputStream targetStream)
compressionDoneAt = System.currentTimeMillis();
synchronized (streams) {
+ // write zip entries in the order they were added (kept as futures)
+ for (final Future<ScatterZipOutputStream> future : futures) {
Review comment:
please provide a PR, my branch is https://github.com/hboutemy/commons-compress/tree/COMPRESS-485
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services