You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Arno Toell (JIRA)" <ji...@apache.org> on 2011/05/05 19:32:11 UTC
[jira] [Created] (TS-759) Makefile incorrectly
Makefile incorrectly
---------------------
Key: TS-759
URL: https://issues.apache.org/jira/browse/TS-759
Project: Traffic Server
Issue Type: Bug
Components: Build
Affects Versions: 2.1.8
Environment: ATS 2.1.8 tagged in SVN as of today
Reporter: Arno Toell
Priority: Trivial
Fix For: 2.1.9
The Makefile does not honor GNU's _$DESTDIR_ coding standard anymore (see http://www.gnu.org/prep/standards/standards.html#DESTDIR), many build environments depend on. This is a regression to ATS 2.1.7 which had not this problem, and I believe it was introduced as fix for TS-624 (didn't verify).
In _proxy/config/Makefile.am_ there is now am _install-exec-hook_ which causes this regression. This is trivially to fix though:
{code}
--- a/proxy/config/Makefile.am
+++ b/proxy/config/Makefile.am
@@ -53,5 +53,5 @@
for dfltcfgfile in $(dist_sysconf_DATA) $(nodist_sysconf_DATA) ; \
do \
cfgfile=`echo $$dfltcfgfile | sed 's/\.default$$//'` ; \
- test -f $(sysconfdir)/$$cfgfile || mv $(sysconfdir)/$$dfltcfgfile $(sysconfdir)/$$cfgfile ; \
+ test -f $(DESTDIR)/$(sysconfdir)/$$cfgfile || mv $(DESTDIR)/$(sysconfdir)/$$dfltcfgfile $(DESTDIR)/$(sysconfdir)/$$cfgfile ; \
done
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-759) Makefile handles $DESTDIR incorrectly
Posted by "Arno Toell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arno Toell updated TS-759:
--------------------------
Summary: Makefile handles $DESTDIR incorrectly (was: Makefile incorrectly )
> Makefile handles $DESTDIR incorrectly
> --------------------------------------
>
> Key: TS-759
> URL: https://issues.apache.org/jira/browse/TS-759
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Affects Versions: 2.1.8
> Environment: ATS 2.1.8 tagged in SVN as of today
> Reporter: Arno Toell
> Priority: Trivial
> Fix For: 2.1.9
>
>
> The Makefile does not honor GNU's _$DESTDIR_ coding standard anymore (see http://www.gnu.org/prep/standards/standards.html#DESTDIR), many build environments depend on. This is a regression to ATS 2.1.7 which had not this problem, and I believe it was introduced as fix for TS-624 (didn't verify).
> In _proxy/config/Makefile.am_ there is now am _install-exec-hook_ which causes this regression. This is trivially to fix though:
> {code}
> --- a/proxy/config/Makefile.am
> +++ b/proxy/config/Makefile.am
> @@ -53,5 +53,5 @@
> for dfltcfgfile in $(dist_sysconf_DATA) $(nodist_sysconf_DATA) ; \
> do \
> cfgfile=`echo $$dfltcfgfile | sed 's/\.default$$//'` ; \
> - test -f $(sysconfdir)/$$cfgfile || mv $(sysconfdir)/$$dfltcfgfile $(sysconfdir)/$$cfgfile ; \
> + test -f $(DESTDIR)/$(sysconfdir)/$$cfgfile || mv $(DESTDIR)/$(sysconfdir)/$$dfltcfgfile $(DESTDIR)/$(sysconfdir)/$$cfgfile ; \
> done
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-759) Makefile handles $DESTDIR incorrectly
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom reassigned TS-759:
--------------------------------
Assignee: Leif Hedstrom
> Makefile handles $DESTDIR incorrectly
> --------------------------------------
>
> Key: TS-759
> URL: https://issues.apache.org/jira/browse/TS-759
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Affects Versions: 2.1.8
> Environment: ATS 2.1.8 tagged in SVN as of today
> Reporter: Arno Toell
> Assignee: Leif Hedstrom
> Priority: Trivial
> Fix For: 2.1.9
>
>
> The Makefile does not honor GNU's _$DESTDIR_ coding standard anymore (see http://www.gnu.org/prep/standards/standards.html#DESTDIR), many build environments depend on. This is a regression to ATS 2.1.7 which had not this problem, and I believe it was introduced as fix for TS-624 (didn't verify).
> In _proxy/config/Makefile.am_ there is now am _install-exec-hook_ which causes this regression. This is trivially to fix though:
> {code}
> --- a/proxy/config/Makefile.am
> +++ b/proxy/config/Makefile.am
> @@ -53,5 +53,5 @@
> for dfltcfgfile in $(dist_sysconf_DATA) $(nodist_sysconf_DATA) ; \
> do \
> cfgfile=`echo $$dfltcfgfile | sed 's/\.default$$//'` ; \
> - test -f $(sysconfdir)/$$cfgfile || mv $(sysconfdir)/$$dfltcfgfile $(sysconfdir)/$$cfgfile ; \
> + test -f $(DESTDIR)/$(sysconfdir)/$$cfgfile || mv $(DESTDIR)/$(sysconfdir)/$$dfltcfgfile $(DESTDIR)/$(sysconfdir)/$$cfgfile ; \
> done
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TS-759) Makefile handles $DESTDIR incorrectly
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom resolved TS-759.
------------------------------
Resolution: Fixed
> Makefile handles $DESTDIR incorrectly
> --------------------------------------
>
> Key: TS-759
> URL: https://issues.apache.org/jira/browse/TS-759
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Affects Versions: 2.1.8
> Environment: ATS 2.1.8 tagged in SVN as of today
> Reporter: Arno Toell
> Assignee: Leif Hedstrom
> Priority: Trivial
> Fix For: 2.1.9
>
>
> The Makefile does not honor GNU's _$DESTDIR_ coding standard anymore (see http://www.gnu.org/prep/standards/standards.html#DESTDIR), many build environments depend on. This is a regression to ATS 2.1.7 which had not this problem, and I believe it was introduced as fix for TS-624 (didn't verify).
> In _proxy/config/Makefile.am_ there is now am _install-exec-hook_ which causes this regression. This is trivially to fix though:
> {code}
> --- a/proxy/config/Makefile.am
> +++ b/proxy/config/Makefile.am
> @@ -53,5 +53,5 @@
> for dfltcfgfile in $(dist_sysconf_DATA) $(nodist_sysconf_DATA) ; \
> do \
> cfgfile=`echo $$dfltcfgfile | sed 's/\.default$$//'` ; \
> - test -f $(sysconfdir)/$$cfgfile || mv $(sysconfdir)/$$dfltcfgfile $(sysconfdir)/$$cfgfile ; \
> + test -f $(DESTDIR)/$(sysconfdir)/$$cfgfile || mv $(DESTDIR)/$(sysconfdir)/$$dfltcfgfile $(DESTDIR)/$(sysconfdir)/$$cfgfile ; \
> done
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira