You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by GitBox <gi...@apache.org> on 2020/02/27 14:01:49 UTC
[GitHub] [mina-sshd] gnodet commented on issue #114: SSHD-968 interpret
SSH_MSG_UNIMPLEMENTED response to a global request as its failure
gnodet commented on issue #114: SSHD-968 interpret SSH_MSG_UNIMPLEMENTED response to a global request as its failure
URL: https://github.com/apache/mina-sshd/pull/114#issuecomment-591986308
I thought you wanted a less invasive fix ;-)
I don't really like the artificial split with the introduction of the `preProcessEncodeBuffer` method as it's only called from `AbstractSession. encode`, while the `preProcessEncodeBuffer` is defined in the `SessionHelper` and overriden in the `AbstractSession`. This looks rather complex instead of simply adding the few needed lines in the existing `encode` method (https://github.com/apache/mina-sshd/pull/114/commits/efdb7c3de1e32592c91536cf699fb3a0bfc48462#diff-916a03c44b5846431681a4411891d952R843-R849).
Anyway, if you really wanted something simple, we could go for https://github.com/gnodet/mina-sshd/commit/cdefec7ebd5214694a4c578bc01066c6f3c6cbde which is much simpler ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org