You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/28 20:36:44 UTC
[GitHub] [incubator-mxnet] Zha0q1 opened a new pull request #19439: OpenMP License Update v1.8x
Zha0q1 opened a new pull request #19439:
URL: https://github.com/apache/incubator-mxnet/pull/19439
https://github.com/apache/incubator-mxnet/issues/19427
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19439: OpenMP License Update v1.8x
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19439:
URL: https://github.com/apache/incubator-mxnet/pull/19439#issuecomment-718238011
> You need to read the license file. It states:
>
> ```
> ==============================================================================
> The LLVM Project is under the Apache License v2.0 with LLVM Exceptions:
> ==============================================================================
> ```
>
> as well as
>
> ```
> ==============================================================================
> Software from third parties included in the LLVM Project:
> ==============================================================================
> The LLVM Project contains third party software which is under different license
> terms. All such code will be identified clearly using at least one of two
> mechanisms:
> 1) It will be in a separate directory tree with its own `LICENSE.txt` or
> `LICENSE` file at the top containing the specific license and restrictions
> which apply to that software, or
> 2) It will contain specific license and restriction terms at the top of every
> file.
> ```
>
> Based on these instructions, you need to modify the MXNet LICENSE so that it separately lists
>
> * an entry for the LLVM openmp project together with a reference to the LICENSE.txt file in the openmp folder
>
> * an entry for each sub-project of the openmp project as identified by other LICENSE.txt files located someweher the openmp folders and subfolders
>
> * an entry for each set of files that "contain [the same] specific license and restriction terms at the top of every file." which are not already covered by the two points above
>
>
> The latter may best be scripted.
I totally agree with this methodology but I checked all the file, and there was no mentioning of any license other than Apache 2.0. I tried to associate those extra licenses with specific files/submodules but I could not find any such links.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19439: OpenMP License Update v1.8x
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19439:
URL: https://github.com/apache/incubator-mxnet/pull/19439#issuecomment-718193828
Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-cpu, windows-cpu, website, miscellaneous, sanity, centos-gpu, unix-gpu, windows-gpu, edge, unix-cpu, clang]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 edited a comment on pull request #19439: OpenMP License Update v1.8x
Posted by GitBox <gi...@apache.org>.
Zha0q1 edited a comment on pull request #19439:
URL: https://github.com/apache/incubator-mxnet/pull/19439#issuecomment-718244759
> In that case you don't need to include them. Referencing the LICENSE.txt is sufficient. We don't need to copy the license text into our LICENSE file. We only need to ensure that we point to each file / set of files of a particular license and provide a pointer where the user can read their license
Sounds good. I have deleted these licenses from our file. In the end I think it suffices to update the copyright statement year
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 closed pull request #19439: OpenMP License Update v1.8x
Posted by GitBox <gi...@apache.org>.
Zha0q1 closed pull request #19439:
URL: https://github.com/apache/incubator-mxnet/pull/19439
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 edited a comment on pull request #19439: OpenMP License Update v1.8x
Posted by GitBox <gi...@apache.org>.
Zha0q1 edited a comment on pull request #19439:
URL: https://github.com/apache/incubator-mxnet/pull/19439#issuecomment-718244759
> In that case you don't need to include them. Referencing the LICENSE.txt is sufficient. We don't need to copy the license text into our LICENSE file. We only need to ensure that we point to each file / set of files of a particular license and provide a pointer where the user can read their license
Sounds good. I have deleted these licenses from our file. Given our discussion I think it suffices to update the copyright statement year
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19439: OpenMP License Update v1.8x
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19439:
URL: https://github.com/apache/incubator-mxnet/pull/19439#issuecomment-718243144
In that case you don't need to include them. Referencing the LICENSE.txt is sufficient. We don't need to copy the license text into our LICENSE file. We only need to ensure that we point to each file / set of files of a particular license and provide a pointer where the user can read their license
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19439: OpenMP License Update v1.8x
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19439:
URL: https://github.com/apache/incubator-mxnet/pull/19439#issuecomment-718244759
> In that case you don't need to include them. Referencing the LICENSE.txt is sufficient. We don't need to copy the license text into our LICENSE file. We only need to ensure that we point to each file / set of files of a particular license and provide a pointer where the user can read their license
Sounds good. I have deleted these licenses from our file
sounds good, will do it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19439: OpenMP License Update v1.8x
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19439:
URL: https://github.com/apache/incubator-mxnet/pull/19439#issuecomment-718233514
You need to read the license file. It states:
> ==============================================================================
> The LLVM Project is under the Apache License v2.0 with LLVM Exceptions:
> ==============================================================================
as well as
> ==============================================================================
> Software from third parties included in the LLVM Project:
> ==============================================================================
> The LLVM Project contains third party software which is under different license
> terms. All such code will be identified clearly using at least one of two
> mechanisms:
> 1) It will be in a separate directory tree with its own `LICENSE.txt` or
> `LICENSE` file at the top containing the specific license and restrictions
> which apply to that software, or
> 2) It will contain specific license and restriction terms at the top of every
> file.
Based on these instructions, you need to modify the MXNet LICENSE so that it separately lists
- an entry for the LLVM openmp project together with a reference to the LICENSE.txt file in the openmp folder
- an entry for each sub-project of the openmp project as identified by other LICENSE.txt files located someweher the openmp folders and subfolders
- an entry for each set of files that "contain [the same] specific license and restriction terms at the top of every file."
The latter may best be scripted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19439: OpenMP License Update v1.8x
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19439:
URL: https://github.com/apache/incubator-mxnet/pull/19439#issuecomment-718234951
The easiest option here is to delete the 3rdparty/openmp folder as it's unused by the default Makefile build and optional for the cmake build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19439: OpenMP License Update v1.8x
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19439:
URL: https://github.com/apache/incubator-mxnet/pull/19439#issuecomment-718260549
@leezu Yeah sorry did not notice that. I moved it under the apache list and also attached the llvm exception at the bottom
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu edited a comment on pull request #19439: OpenMP License Update v1.8x
Posted by GitBox <gi...@apache.org>.
leezu edited a comment on pull request #19439:
URL: https://github.com/apache/incubator-mxnet/pull/19439#issuecomment-718233514
You need to read the license file. It states:
```
==============================================================================
The LLVM Project is under the Apache License v2.0 with LLVM Exceptions:
==============================================================================
```
as well as
```
==============================================================================
Software from third parties included in the LLVM Project:
==============================================================================
The LLVM Project contains third party software which is under different license
terms. All such code will be identified clearly using at least one of two
mechanisms:
1) It will be in a separate directory tree with its own `LICENSE.txt` or
`LICENSE` file at the top containing the specific license and restrictions
which apply to that software, or
2) It will contain specific license and restriction terms at the top of every
file.
```
Based on these instructions, you need to modify the MXNet LICENSE so that it separately lists
- an entry for the LLVM openmp project together with a reference to the LICENSE.txt file in the openmp folder
- an entry for each sub-project of the openmp project as identified by other LICENSE.txt files located someweher the openmp folders and subfolders
- an entry for each set of files that "contain [the same] specific license and restriction terms at the top of every file." which are not already covered by the two points above
The latter may best be scripted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19439: OpenMP License Update v1.8x
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19439:
URL: https://github.com/apache/incubator-mxnet/pull/19439#issuecomment-718223220
> You're attaching a bunch of licenses under the keyword "OpenMP", but it's not clear to what files the apply. We need to specify the licenses with respect to the files (subfolders) they apply to.
> Sometimes, multiple licenses may apply to a particular code and we should state if the users can choose one of the or what their relation is
Those licenses are from the master License.txt in the root directory. There they do not specify to which submodules those license apply to. In fact there is no clear submodule by the way they structure the directories https://github.com/llvm-mirror/openmp/tree/b76842ed16984ae5edcbbc4b00a94fda20419431
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19439: OpenMP License Update v1.8x
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19439:
URL: https://github.com/apache/incubator-mxnet/pull/19439#issuecomment-718194160
@samskalicky @leezu Could you review thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org