You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/12 09:25:00 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27888: [SPARK-31116][SQL] Consider case sensitivity in ParquetRowConverter

dongjoon-hyun commented on a change in pull request #27888: [SPARK-31116][SQL] Consider case sensitivity in ParquetRowConverter
URL: https://github.com/apache/spark/pull/27888#discussion_r391491836
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetQuerySuite.scala
 ##########
 @@ -804,6 +804,162 @@ abstract class ParquetQuerySuite extends QueryTest with ParquetTest with SharedS
     }
   }
 
+  test("SPARK-31116: Select simple parquet columns correctly in case insensitive manner") {
 
 Review comment:
   Could you move new test cases into `FileBasedDataSourceSuite` and run with `Orc/Parquet/Json` at least?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org