You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/05/01 23:30:22 UTC
Review Request 20984: Upgradestack only handles specific OSs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20984/
-----------------------------------------------------------
Review request for Ambari, Sid Wagle and Tom Beerbower.
Bugs: AMBARI-5653
https://issues.apache.org/jira/browse/AMBARI-5653
Repository: ambari
Description
-------
Moving to OS "families" broke the upgrade process. Instead of using a helper method, access the DB entity directly. Adds both the specific and the family override (per Jeff).
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 61e2954
ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java fda9fc9
ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java 5f96326
ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeUtilTest.java 5cda29c
Diff: https://reviews.apache.org/r/20984/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:01.988s
[INFO] Finished at: Thu May 01 17:27:35 EDT 2014
[INFO] Final Memory: 22M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 20984: Upgradestack only handles specific OSs
Posted by Tom Beerbower <tb...@hortonworks.com>.
> On May 1, 2014, 10:11 p.m., Tom Beerbower wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java, lines 47-48
> > <https://reviews.apache.org/r/20984/diff/1/?file=573039#file573039line47>
> >
> > Could you just use OsFamily.valueOf(String os), instead of writing your own?
Just looked at it again. I see that its not the same.
- Tom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20984/#review41957
-----------------------------------------------------------
On May 1, 2014, 9:30 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20984/
> -----------------------------------------------------------
>
> (Updated May 1, 2014, 9:30 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-5653
> https://issues.apache.org/jira/browse/AMBARI-5653
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Moving to OS "families" broke the upgrade process. Instead of using a helper method, access the DB entity directly. Adds both the specific and the family override (per Jeff).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 61e2954
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java fda9fc9
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java 5f96326
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeUtilTest.java 5cda29c
>
> Diff: https://reviews.apache.org/r/20984/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:01.988s
> [INFO] Finished at: Thu May 01 17:27:35 EDT 2014
> [INFO] Final Memory: 22M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 20984: Upgradestack only handles specific OSs
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20984/#review41957
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java
<https://reviews.apache.org/r/20984/#comment75625>
Could you just use OsFamily.valueOf(String os), instead of writing your own?
- Tom Beerbower
On May 1, 2014, 9:30 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20984/
> -----------------------------------------------------------
>
> (Updated May 1, 2014, 9:30 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-5653
> https://issues.apache.org/jira/browse/AMBARI-5653
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Moving to OS "families" broke the upgrade process. Instead of using a helper method, access the DB entity directly. Adds both the specific and the family override (per Jeff).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 61e2954
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java fda9fc9
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java 5f96326
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeUtilTest.java 5cda29c
>
> Diff: https://reviews.apache.org/r/20984/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:01.988s
> [INFO] Finished at: Thu May 01 17:27:35 EDT 2014
> [INFO] Final Memory: 22M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 20984: Upgradestack only handles specific OSs
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20984/#review41967
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On May 1, 2014, 9:30 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20984/
> -----------------------------------------------------------
>
> (Updated May 1, 2014, 9:30 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-5653
> https://issues.apache.org/jira/browse/AMBARI-5653
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Moving to OS "families" broke the upgrade process. Instead of using a helper method, access the DB entity directly. Adds both the specific and the family override (per Jeff).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 61e2954
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java fda9fc9
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java 5f96326
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeUtilTest.java 5cda29c
>
> Diff: https://reviews.apache.org/r/20984/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:01.988s
> [INFO] Finished at: Thu May 01 17:27:35 EDT 2014
> [INFO] Final Memory: 22M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>