[jira] [Resolved] (STORM-584) LoggingMetricsConsumer metrics.log file is shared by multiple topologies.

["Robert Joseph Evans (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/STORM-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans resolved STORM-584.
---------------------------------------
       Resolution: Fixed
    Fix Version/s: 2.0.0
                   0.10.1
                   1.0.0

Thanks [~jnioche],

I merged this into master 1.x-branch and 0.10.x-branch.

> LoggingMetricsConsumer metrics.log file is shared by multiple topologies.
> -------------------------------------------------------------------------
>
>                 Key: STORM-584
>                 URL: https://issues.apache.org/jira/browse/STORM-584
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>    Affects Versions: 0.9.6
>            Reporter: Robert Joseph Evans
>            Assignee: Julien Nioche
>             Fix For: 1.0.0, 0.10.1, 2.0.0
>
>
> The current cluster.xml file has special configuration for the LoggingMetricsConsumer to place it in a metrics.log file.  There are several issues with this.
> The worker, where the LoggingMetricsConsumer is run, is configured using worker.xml and not cluster.xml.
> The metrics.log file is shared by all workers running on the same node.  So if by chance we have LoggingMetricsConsumer instances running at the same time, the resulting log file could have a number of issues, including data corruption.
> This becomes much worse under security where only the first LoggingMetricsConsumer to run on the node will own the file, and all others will fail to log metrics.
> Also there is no way to access metrics.log through the ui now.
> Ideally the metrics.log file will follow a pattern similar to the worker log file, and have the topology name and the worker port a part of it.  We also would want to update the logviewer daemon to allow serving up these files and deleting them after a specific period of time.  The it would be awesome if the UI could detect that a logging metrics consumer is installed, and provide links to the metrics.log file as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)