[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7826: test: fix that E2E is not run, also add ElasticSearch 7.15 to test matrix

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #7826:
URL: https://github.com/apache/skywalking/pull/7826#discussion_r717320558



##########
File path: oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/query/TraceQueryEsDAO.java
##########
@@ -121,7 +121,7 @@ public TraceBrief queryBasicTraces(long startSecondTB,
         }
         if (CollectionUtils.isNotEmpty(tags)) {
             BoolQueryBuilder tagMatchQuery = Query.bool();
-            tags.forEach(tag -> tagMatchQuery.must(Query.term(SegmentRecord.TAGS, tag)));
+            tags.forEach(tag -> tagMatchQuery.must(Query.term(SegmentRecord.TAGS, tag.toString())));

Review comment:
       Before: `tag` was serialized as `{"key":"value"}` and was considered as ES query syntax.
   Now: `tag` is `key=value`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org